From patchwork Sat Dec 22 09:50:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 1017801 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::12; helo=lists.nongnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZCpS5e17"; dkim-atps=neutral Received: from lists.nongnu.org (lists.nongnu.org [IPv6:2001:4830:134:3::12]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43MLP85f7wz9sDP for ; Sat, 22 Dec 2018 20:51:39 +1100 (AEDT) Received: from localhost ([::1]:36915 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadwV-000694-IR for incoming@patchwork.ozlabs.org; Sat, 22 Dec 2018 04:51:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gadvl-00068o-46 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gadvh-0006Gq-D9 for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:47 -0500 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:35989) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gadvf-0006EK-EC for qemu-devel@nongnu.org; Sat, 22 Dec 2018 04:50:45 -0500 Received: by mail-wr1-x444.google.com with SMTP id u4so7504234wrp.3 for ; Sat, 22 Dec 2018 01:50:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5dVeTlzdJ2AeoFg6ycMVcl5pJNQT/zzvsAlsV3kRw0c=; b=ZCpS5e17KwabCelouqJltx2gGYSflRbmOLgUeOBton0NxaPrN/LLCPUdAQDWInLMWq Pld1scsIS+jAI2v83IjG2rNuwoODM6K/M8TNMuqr2DUDepAIOZON+31koKaF3VEOTJ+w /rqS1nV8x/O78mnNqUpGcvamTWvDQrJ4GNTuuMKLuXYK+rBACCzuCQa+CqXgfbvk31q2 iZBaNFl81FwVwvXhg+Cc6SJXkD3bmPhdbKzn+UqSaYyoGj/tUvfINroiJtye/KdnEo/b fW3gkxkDnOVEdcBOkBPAjQyjjkxw3ySVycFDTpVQBdy5OfTdscJrfMOAFy3rTAV3v58Q alUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5dVeTlzdJ2AeoFg6ycMVcl5pJNQT/zzvsAlsV3kRw0c=; b=DV3IcUd110JWQwBAfpy3Sp+1slxXA5EqRn5rg4PybJImIT57fze0WA1AcQSyGQW+Zs ByAdkV+6tRJy0JKylqgpf3+0AOQEwjNKexV6ZWIAyMoXLZXPDS++jbLV/h289eppFFv/ olDKHP8vsrWrB+QItonYNT4qCbF3zmzrlnSgZCQngMXMB/DAsJCgGSyTT+Hl9HxAmj3d OB2Vi/Qbd5cWp8DCXws7JyUVQOatC4k2eJHcaPzJ3+nKcKKs3tS3IagmRHCrpOgB16eu DNFgBmBqKRCUwYOsOak6CQSo1BtkWlXNLiygIT9WxVH4sGf3Gcgh+g0lLU6HGysznYHa VpyQ== X-Gm-Message-State: AJcUukeZY7gNJEc6w4FQTSK3y2tqrbwotKeVxD4B0xfXfnjxeVKEUJkG dLtQSHGH7XVWCbQJfTNLfbxx/Hmc X-Google-Smtp-Source: ALg8bN4IBnbop2kj2CikJeU71sdHOo/AB4VGe7NS1qNTjCBz4sghbdEQ68iXFaAxtWcxwoEnTALTKw== X-Received: by 2002:adf:f390:: with SMTP id m16mr5521470wro.71.1545472240966; Sat, 22 Dec 2018 01:50:40 -0800 (PST) Received: from localhost.localdomain ([176.228.155.165]) by smtp.gmail.com with ESMTPSA id s3sm9557371wmj.23.2018.12.22.01.50.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Dec 2018 01:50:40 -0800 (PST) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sat, 22 Dec 2018 11:50:06 +0200 Message-Id: <20181222095036.29743-2-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> References: <20181222095036.29743-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH PULL 01/31] hw/pvrdma: Check the correct return value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: yuval.shaia@oracle.com, pjp@fedoraproject.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Yuval Shaia Return value of 0 means ok, we want to free the memory only in case of error. Signed-off-by: Yuval Shaia Message-Id: <20181025061700.17050-1-yuval.shaia@oracle.com> Reviewed-by: Marcel Apfelbaum Signed-off-by: Marcel Apfelbaum --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 4faeb21631..57d6f41ae6 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req *req, cmd->start, cmd->length, host_virt, cmd->access_flags, &resp->mr_handle, &resp->lkey, &resp->rkey); - if (host_virt && !resp->hdr.err) { + if (resp->hdr.err && host_virt) { munmap(host_virt, cmd->length); }