Message ID | 20181212175817.815-1-ppandit@redhat.com |
---|---|
State | New |
Headers | show |
Series | pvrdma: release device resources in case of an error | expand |
On Wed, Dec 12, 2018 at 11:28:17PM +0530, P J P wrote: > From: Prasad J Pandit <pjp@fedoraproject.org> > > If during pvrdma device initialisation an error occurs, > pvrdma_realize() does not release memory resources, leading > to memory leakage. > > Reported-by: Li Qiang <liq3ea@163.com> > Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> > --- > hw/rdma/vmw/pvrdma_main.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c > index 8a03ab4669..b65f8662df 100644 > --- a/hw/rdma/vmw/pvrdma_main.c > +++ b/hw/rdma/vmw/pvrdma_main.c > @@ -579,7 +579,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, void *opaque) > > static void pvrdma_realize(PCIDevice *pdev, Error **errp) > { > - int rc; > + int rc = 0; > PVRDMADev *dev = PVRDMA_DEV(pdev); > Object *memdev_root; > bool ram_shared = false; > @@ -655,6 +655,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp) > > out: > if (rc) { > + pvrdma_fini(pdev); > error_append_hint(errp, "Device fail to load\n"); > } Thanks. Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> > } > -- > 2.19.2 >
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c index 8a03ab4669..b65f8662df 100644 --- a/hw/rdma/vmw/pvrdma_main.c +++ b/hw/rdma/vmw/pvrdma_main.c @@ -579,7 +579,7 @@ static void pvrdma_shutdown_notifier(Notifier *n, void *opaque) static void pvrdma_realize(PCIDevice *pdev, Error **errp) { - int rc; + int rc = 0; PVRDMADev *dev = PVRDMA_DEV(pdev); Object *memdev_root; bool ram_shared = false; @@ -655,6 +655,7 @@ static void pvrdma_realize(PCIDevice *pdev, Error **errp) out: if (rc) { + pvrdma_fini(pdev); error_append_hint(errp, "Device fail to load\n"); } }