From patchwork Tue Nov 27 13:50:30 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1003838 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="Apzxyxmn"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4345Dx6nGLz9s3l for ; Wed, 28 Nov 2018 01:06:41 +1100 (AEDT) Received: from localhost ([::1]:42594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRe0d-0007NI-6L for incoming@patchwork.ozlabs.org; Tue, 27 Nov 2018 09:06:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRdlh-0002bl-5A for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRdlc-0000XZ-RQ for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:13 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51237) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRdlc-0000Wd-Kc for qemu-devel@nongnu.org; Tue, 27 Nov 2018 08:51:08 -0500 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127135107euoutp02ffe370c8134f9759dc5fc0461961b33a~q-21uOOKj2313823138euoutp02W for ; Tue, 27 Nov 2018 13:51:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127135107euoutp02ffe370c8134f9759dc5fc0461961b33a~q-21uOOKj2313823138euoutp02W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543326667; bh=w4Jv8ksWorck56mIfI6cvuADBi/bwNFiq1e9hNPUSn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Apzxyxmnwpg0fsi0l9lpQPBBcMtEXKMkGk0nRCkbqaHwLOTdXunAA6o1MLzw6o2UW lqDpCv4IjRAzELy252JICjb9G/eFGPcfhkP/MiKSE7CcZs2vi0s2PgporgB45h170g XKULyVWttZiFdDBLKRej8qGQUbdXnvmMjBpcTFuo= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181127135107eucas1p226b728235aebcd19f1edd6058553f01f~q-21GPsFx0501505015eucas1p2T; Tue, 27 Nov 2018 13:51:07 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 00.53.04806.ACB4DFB5; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb~q-20ahf7s1194811948eucas1p11; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181127135106eusmtrp1fda39c624463860bc16f2066d2e13afa~q-20X88IC2190321903eusmtrp1i; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) X-AuditID: cbfec7f5-34dff700000012c6-d3-5bfd4bca7160 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id FB.20.04128.ACB4DFB5; Tue, 27 Nov 2018 13:51:06 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181127135105eusmtip1d64635d542c4e935514d139723e67db7~q-2z2J6cc1872818728eusmtip1K; Tue, 27 Nov 2018 13:51:05 +0000 (GMT) From: Ilya Maximets To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Tue, 27 Nov 2018 16:50:30 +0300 Message-Id: <20181127135030.1671-5-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127135030.1671-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsWy7djP87qnvP9GG3QdNLJouBdqcaX9J7vF 6aMdzBbPbp1ktljQ1s5qsX/bP1aL4707WBzYPZ5c28zk8X7fVTaPvi2rGAOYo7hsUlJzMstS i/TtErgy/r/qYC+4wVXRcsaogfEZexcjB4eEgIlEfzdHFyMXh5DACkaJK/e/sUE4Xxglps96 wgLhfGaU+PRjDlMXIydYR+u8NVBVyxklTiz4zArh/GCUuDungx2kik1AR+LU6iOMILaIgJvE iwfHwTqYBW4ySiz9uIAFJCEsYCqx4OcnMJtFQFXiavcEsGZeASuJ5b1t7BDr5CVWbzjADGJz ClhLfP+3hA2iRlDi5MwnYL3MQDXNW2czgyyQEOhnl/hxeh0jRLOLROPaW1CDhCVeHd8CZctI nJ7cwwJh10vcb3nJCNHcAfT1oX9Qj9pLbHl9DhxMzAKaEut36UOEHSXaNjaxQUKPT+LGW0GI G/gkJm2bzgwR5pXoaBOCqFaR+H1wOTOELSVx891nqAs8JJoeNzJNYFScheSbWUi+mYWwdwEj 8ypG8dTS4tz01GLjvNRyveLE3OLSvHS95PzcTYzAtHL63/GvOxj3/Uk6xCjAwajEwxvx9Xe0 EGtiWXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYpTlYlMR5qxkeRAsJpCeWpGan phakFsFkmTg4pRoY59b5OizN6+NaaMW0Vkff/tPR68dfH3KaoWavIfH+eGD4Q/6ZzW6lCkdW LDuXN/dv4sou+b6UC4XZRld2LdJN7J3A7GuX/ntqUlAlW17y7ccCWzcIun9TnRwT3v54f9+N JKua9JMuC7NLPIOr46/ZHviXzWH44M6uyG8fFmU/37pyrtwVucdMSizFGYmGWsxFxYkAZD4R QicDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xu7qnvP9GGyx/LmDRcC/U4kr7T3aL 00c7mC2e3TrJbLGgrZ3VYv+2f6wWx3t3sDiwezy5tpnJ4/2+q2wefVtWMQYwR+nZFOWXlqQq ZOQXl9gqRRtaGOkZWlroGZlY6hkam8daGZkq6dvZpKTmZJalFunbJehl/H/VwV5wg6ui5YxR A+Mz9i5GTg4JAROJ1nlr2EBsIYGljBIX7pZAxKUkfvy6wAphC0v8udYFVMMFVPONUWLZhGuM IAk2AR2JU6uPgNkiAm4SLx4cBytiFrjPKHFs01SwqcICphILfn5iAbFZBFQlrnZPANvMK2Al sby3DeoKeYnVGw4wg9icAtYS3/8tgbrISuLTgVdsEPWCEidnPgGawwG0QF1i/TwhkDAzUGvz 1tnMExgFZyGpmoVQNQtJ1QJG5lWMIqmlxbnpucVGesWJucWleel6yfm5mxiBsbLt2M8tOxi7 3gUfYhTgYFTi4d3w/Xe0EGtiWXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYTYFe m8gsJZqcD4zjvJJ4Q1NDcwtLQ3Njc2MzCyVx3vMGlVFCAumJJanZqakFqUUwfUwcnFINjFqO a6YKH00R3cv33KHQLMPyRPbCc9fasrzqL9c+MLI6Jq576mFe0EO37W9kbrRwLMg4GPJSWDvl ovHjKZoNVj92fXu1y3DdrmmyHq6GrMvfSdXI2RYEeDnd+rzhyvHXHxwyX+56P/ugStajz2fe bTk59cI+8S2PlXRktl31+DZ3Wp1RYYS9ZKISS3FGoqEWc1FxIgCtUztzqwIAAA== X-CMS-MailID: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb X-Msg-Generator: CA X-RootMTR: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127135106eucas1p119ab7de9758f13ea52adc0f4829ab9cb References: <20181127135030.1671-1-i.maximets@samsung.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v2 4/4] memfd: improve error messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This gives more information about the failure. Additionally 'ENOSYS' returned for a non-Linux platforms instead of 'errno', which is not initilaized in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-André Lureau --- util/memfd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 393d23da96..00334e5b21 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -71,14 +71,18 @@ int qemu_memfd_create(const char *name, size_t size, bool hugetlb, } mfd = memfd_create(name, flags); if (mfd < 0) { + error_setg_errno(errp, errno, + "failed to create memfd with flags 0x%x", flags); goto err; } if (ftruncate(mfd, size) == -1) { + error_setg_errno(errp, errno, "failed to resize memfd to %zu", size); goto err; } if (seals && fcntl(mfd, F_ADD_SEALS, seals) == -1) { + error_setg_errno(errp, errno, "failed to add seals 0x%x", seals); goto err; } @@ -88,8 +92,9 @@ err: if (mfd >= 0) { close(mfd); } +#else + error_setg_errno(errp, ENOSYS, "failed to create memfd"); #endif - error_setg_errno(errp, errno, "failed to create memfd"); return -1; }