From patchwork Tue Nov 20 21:26:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aaron Lindsay X-Patchwork-Id: 1000734 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=os.amperecomputing.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amperemail.onmicrosoft.com header.i=@amperemail.onmicrosoft.com header.b="OYQnuYoz"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42zzTK0jj3z9s8r for ; Wed, 21 Nov 2018 08:33:09 +1100 (AEDT) Received: from localhost ([::1]:36038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPDdq-0005Hi-Mv for incoming@patchwork.ozlabs.org; Tue, 20 Nov 2018 16:33:06 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gPDXq-0000Co-Dz for qemu-devel@nongnu.org; Tue, 20 Nov 2018 16:26:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gPDXm-0005rq-IS for qemu-devel@nongnu.org; Tue, 20 Nov 2018 16:26:54 -0500 Received: from mail-eopbgr740133.outbound.protection.outlook.com ([40.107.74.133]:63072 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gPDXd-0005JL-W0; Tue, 20 Nov 2018 16:26:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-os-amperecomputing-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kPY28nOOWI+M8fjuRCxMaBexF31RO05K6GmpfP9pCEI=; b=OYQnuYozRldhcUcuiLWIcP8pTxWEQuVHDEipuuclSu+caobjNrrLjtvgX/Sbko09o9vVOXMbx76vsp63oPsRTI4uuFVB9P125zO0K0ucQ7u14KcB15/YAtk5Zoy14ndG3YMMbJ3OiFSFexLflru2QGE/wRIAXWjaKTxyTi9ai40= Received: from DM6PR01MB4825.prod.exchangelabs.com (20.177.218.222) by DM6PR01MB5228.prod.exchangelabs.com (20.177.219.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1339.23; Tue, 20 Nov 2018 21:26:39 +0000 Received: from DM6PR01MB4825.prod.exchangelabs.com ([fe80::d5ed:ce81:19eb:c9ea]) by DM6PR01MB4825.prod.exchangelabs.com ([fe80::d5ed:ce81:19eb:c9ea%5]) with mapi id 15.20.1294.048; Tue, 20 Nov 2018 21:26:39 +0000 From: Aaron Lindsay To: "qemu-arm@nongnu.org" , Peter Maydell , Alistair Francis , Wei Huang , Peter Crosthwaite , Richard Henderson Thread-Topic: [PATCH v8 06/13] target/arm: Implement PMOVSSET Thread-Index: AQHUgRe5ox1hLzP5+kabVTvza5yyCg== Date: Tue, 20 Nov 2018 21:26:39 +0000 Message-ID: <20181120212553.8480-7-aaron@os.amperecomputing.com> References: <20181120212553.8480-1-aaron@os.amperecomputing.com> In-Reply-To: <20181120212553.8480-1-aaron@os.amperecomputing.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: CY4PR04CA0037.namprd04.prod.outlook.com (2603:10b6:903:c6::23) To DM6PR01MB4825.prod.exchangelabs.com (2603:10b6:5:6b::30) x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [216.85.170.155] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; DM6PR01MB5228; 6:i8Z777xII34amD4bjVh3jWh6c1L1yxurcxemceQqelPZaiMCvnw7D2+NRcblFvFTUAsqJGimb31W5CA72E0me2DmSMBEG+VIgf0S56ADMSxmfgbi34m0vLaDtjI8RLvW8HyrOquZUx2TzXGUxBYwHwAbI62AbTWend+o/EXm0ngh0cw1v7HtnSp/7RukEsPgRLLUfC8Ux4yyuf23Iv9kkgalj62LaP+Wr+6+310YfR7zKFBWDpnzcpOtnPeP8VWv8Q1qCEDFBwHdGSx9UU+uMy6O8mlTC8avYWQLFIFi4Ut0W4FLTb2hzDf5t370r0iE/JliTQ5Zvkp6leuNoNHzqzlVEN+qPeOuSHHCIKaC4N61q/yXEmlIhSqW0prfuliUr8nZn3kYU5/yDWuWUsygdfokC9ToyC7k1wl5lAMrnScGNmlfLHC4rEGiqRAyFilE+BH0sgSbIshJXGntMywNng==; 5:yK9ZMKdE8NsoldZcdU6bPZoEpuQCA1luHgypBEzIO2YbkCQ5D/D5tdOtR1PDleMnbPxTyY5UyLLTCoTmqFhcCdvR0MHUdtRc/Io0vq1YS4wj7eaWNt/V9tNCZJBiGVQNWAp06L6pQRaqb8h3KJ3fzX6TLRFWYssF2SuvSKhWSVg=; 7:J0UqUneC2i03zq4d9LX2BziJVnPjF/p9ajRmZtL3iYrnRe5a+qCeQKBbJU+08hvOSTLJheEPJUnlyJmyIiMN7bjLybsP/xWeYQ2rKCTH3YbpbUK18I4dnB2WPFEy7SF75/o5CgdLirPpi13C91c+Jw== x-ms-office365-filtering-correlation-id: dcecc0ab-b07e-4a5b-eca2-08d64f2edba9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:DM6PR01MB5228; x-ms-traffictypediagnostic: DM6PR01MB5228: authentication-results: spf=none (sender IP is ) smtp.mailfrom=aaron@os.amperecomputing.com; x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(3231442)(944501410)(52105112)(10201501046)(148016)(149066)(150057)(6041310)(20161123558120)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:DM6PR01MB5228; BCL:0; PCL:0; RULEID:; SRVR:DM6PR01MB5228; x-forefront-prvs: 08626BE3A5 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(346002)(376002)(39840400004)(366004)(396003)(136003)(189003)(199004)(305945005)(4326008)(39060400002)(71200400001)(7736002)(71190400001)(2906002)(6436002)(7416002)(14454004)(3846002)(6116002)(14444005)(256004)(1076002)(86362001)(316002)(11346002)(6486002)(446003)(2616005)(53936002)(5660300001)(486006)(110136005)(6512007)(54906003)(476003)(478600001)(186003)(2501003)(66066001)(26005)(97736004)(25786009)(76176011)(68736007)(6506007)(106356001)(99286004)(105586002)(8936002)(386003)(81166006)(102836004)(81156014)(52116002)(8676002)(2900100001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR01MB5228; H:DM6PR01MB4825.prod.exchangelabs.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:0; received-spf: None (protection.outlook.com: os.amperecomputing.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: 8fH0bwAJH1OKzw8fa9+R/UpvnEVv4ETi0z+P2ClxtluUmANqDRverbAK93jkJzWiCgl5Ultk58juIn4+Z/9SbmlAkFGY2c7MLzJ+BuIv6WNYFwNDuTNDvMTg178BmVF+XHqQldG1aOidw47VmVFkI7Xhbje7ra0kBvaDJ9GhaA1P6abXcxvTpQyljWHPNIJLZr2dZUAsdxr9WKwpmmInwVSUPvS4QIvZUL06EjAJDPuREsqJCRp+3Shai0rJhWjN9q/4IW0KT8MRZ+u54HxOjaxeimAccbTQe31wPw+iCw4U/SQfVxmJ7f+gvcxSBOfoqpc8spgqJL4tOn47A1ow1KuHtpnrnGaHB5to4cQP4kU= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcecc0ab-b07e-4a5b-eca2-08d64f2edba9 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2018 21:26:39.4440 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5228 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 40.107.74.133 Subject: [Qemu-devel] [PATCH v8 06/13] target/arm: Implement PMOVSSET X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aaron Lindsay , Michael Spradling , "qemu-devel@nongnu.org" , Digant Desai Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Add an array for PMOVSSET so we only define it for v7ve+ platforms Signed-off-by: Aaron Lindsay Reviewed-by: Richard Henderson --- target/arm/helper.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/target/arm/helper.c b/target/arm/helper.c index 0aff261528..71be6fb578 100644 --- a/target/arm/helper.c +++ b/target/arm/helper.c @@ -1342,6 +1342,13 @@ static void pmovsr_write(CPUARMState *env, const ARMCPRegInfo *ri, env->cp15.c9_pmovsr &= ~value; } +static void pmovsset_write(CPUARMState *env, const ARMCPRegInfo *ri, + uint64_t value) +{ + value &= pmu_counter_mask(env); + env->cp15.c9_pmovsr |= value; +} + static void pmxevtyper_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { @@ -1709,6 +1716,24 @@ static const ARMCPRegInfo v7mp_cp_reginfo[] = { REGINFO_SENTINEL }; +static const ARMCPRegInfo pmovsset_cp_reginfo[] = { + /* PMOVSSET is not implemented in v7 before v7ve */ + { .name = "PMOVSSET", .cp = 15, .opc1 = 0, .crn = 9, .crm = 14, .opc2 = 3, + .access = PL0_RW, .accessfn = pmreg_access, + .type = ARM_CP_ALIAS, + .fieldoffset = offsetoflow32(CPUARMState, cp15.c9_pmovsr), + .writefn = pmovsset_write, + .raw_writefn = raw_write }, + { .name = "PMOVSSET_EL0", .state = ARM_CP_STATE_AA64, + .opc0 = 3, .opc1 = 3, .crn = 9, .crm = 14, .opc2 = 3, + .access = PL0_RW, .accessfn = pmreg_access, + .type = ARM_CP_ALIAS, + .fieldoffset = offsetof(CPUARMState, cp15.c9_pmovsr), + .writefn = pmovsset_write, + .raw_writefn = raw_write }, + REGINFO_SENTINEL +}; + static void teecr_write(CPUARMState *env, const ARMCPRegInfo *ri, uint64_t value) { @@ -5191,6 +5216,9 @@ void register_cp_regs_for_features(ARMCPU *cpu) !arm_feature(env, ARM_FEATURE_PMSA)) { define_arm_cp_regs(cpu, v7mp_cp_reginfo); } + if (arm_feature(env, ARM_FEATURE_V7VE)) { + define_arm_cp_regs(cpu, pmovsset_cp_reginfo); + } if (arm_feature(env, ARM_FEATURE_V7)) { /* v7 performance monitor control register: same implementor * field as main ID register, and we implement only the cycle