From patchwork Thu Nov 15 09:42:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Michel X-Patchwork-Id: 998215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=greensocs.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=greensocs.com header.i=@greensocs.com header.b="CPAZhkg4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="b4c72gY1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="b4c72gY1"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42wc5C4DTJz9s9G for ; Thu, 15 Nov 2018 20:49:02 +1100 (AEDT) Received: from localhost ([::1]:37688 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEGg-0003Kf-Qx for incoming@patchwork.ozlabs.org; Thu, 15 Nov 2018 04:48:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEBG-0007r6-JB for qemu-devel@nongnu.org; Thu, 15 Nov 2018 04:43:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNEBE-00053G-3i for qemu-devel@nongnu.org; Thu, 15 Nov 2018 04:43:22 -0500 Received: from greensocs.com ([193.104.36.180]:41906) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEB3-0004NU-Sf; Thu, 15 Nov 2018 04:43:11 -0500 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id 6892C44325E; Thu, 15 Nov 2018 10:42:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274939; bh=EIdLDC5u0xmtQYqBAdduMjysY1VZBCN7v1PRkawPBBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=CPAZhkg4Oo0nIJt0iuyllTkm77cpAeRotRtxmdzfBW7tx6yUV0SuYn21vC4VZkB7O YhknryzOs5ajsDpmDyc60cnNlFLIp0/1vYMxE5VEXwRmo9M2D+nggZjF1POXRLiavU X0ipuqkDGY5xuDOGg4JbI224x9ySEwC3GOvwrNDQ= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=b4c72gY1; dkim=pass (1024-bit key) header.d=greensocs.com header.b=b4c72gY1 Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 35_EZBPGN4FF; Thu, 15 Nov 2018 10:42:18 +0100 (CET) Received: by greensocs.com (Postfix, from userid 998) id 6F3CC441B67; Thu, 15 Nov 2018 10:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274938; bh=EIdLDC5u0xmtQYqBAdduMjysY1VZBCN7v1PRkawPBBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b4c72gY1ICbj9h0o0ETZSfn4mdQWZxp4Txna0G6q4vRjjSah5K1pCr4SMAO74GZ84 uwuvc56c24YDLqn3u+5YRTyBc6Ei4EgLm/b8ZHPHZjozO0dI4WYCcAme8am0sCVKfn +mrdIgOo7vQqGekScB/RCfJQc3ZXH6osaGH6Ued0= Received: from michell-laptop.hive.antfield.fr (lfbn-1-8165-82.w90-112.abo.wanadoo.fr [90.112.74.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id DBE905BD1BB; Thu, 15 Nov 2018 10:42:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274938; bh=EIdLDC5u0xmtQYqBAdduMjysY1VZBCN7v1PRkawPBBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b4c72gY1ICbj9h0o0ETZSfn4mdQWZxp4Txna0G6q4vRjjSah5K1pCr4SMAO74GZ84 uwuvc56c24YDLqn3u+5YRTyBc6Ei4EgLm/b8ZHPHZjozO0dI4WYCcAme8am0sCVKfn +mrdIgOo7vQqGekScB/RCfJQc3ZXH6osaGH6Ued0= From: Luc Michel To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 10:42:04 +0100 Message-Id: <20181115094207.22846-14-luc.michel@greensocs.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181115094207.22846-1-luc.michel@greensocs.com> References: <20181115094207.22846-1-luc.michel@greensocs.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v6 13/16] gdbstub: processes initialization on new peer connection X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , alistair@alistair23.me, mark.burton@greensocs.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" When a new connection is established, we set the first process to be attached, and the others detached. The first CPU of the first process is selected as the current CPU. Signed-off-by: Luc Michel Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- gdbstub.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 0427d1c4f0..59eed3b878 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2245,13 +2245,14 @@ static bool gdb_accept(void) close(fd); return false; } s = g_malloc0(sizeof(GDBState)); - s->c_cpu = first_cpu; - s->g_cpu = first_cpu; create_unique_process(s); + s->processes[0].attached = true; + s->c_cpu = gdb_first_cpu(s); + s->g_cpu = s->c_cpu; s->fd = fd; gdb_has_xml = false; gdbserver_state = s; return true; @@ -2333,12 +2334,23 @@ static void gdb_chr_receive(void *opaque, const uint8_t *buf, int size) } } static void gdb_chr_event(void *opaque, int event) { + int i; + GDBState *s = (GDBState *) opaque; + switch (event) { case CHR_EVENT_OPENED: + /* Start with first process attached, others detached */ + for (i = 0; i < s->process_num; i++) { + s->processes[i].attached = !i; + } + + s->c_cpu = gdb_first_cpu(s); + s->g_cpu = s->c_cpu; + vm_stop(RUN_STATE_PAUSED); gdb_has_xml = false; break; default: break; @@ -2524,19 +2536,17 @@ int gdbserver_start(const char *device) mon_chr = s->mon_chr; cleanup_processes(s); memset(s, 0, sizeof(GDBState)); s->mon_chr = mon_chr; } - s->c_cpu = first_cpu; - s->g_cpu = first_cpu; create_processes(s); if (chr) { qemu_chr_fe_init(&s->chr, chr, &error_abort); qemu_chr_fe_set_handlers(&s->chr, gdb_chr_can_receive, gdb_chr_receive, - gdb_chr_event, NULL, NULL, NULL, true); + gdb_chr_event, NULL, s, NULL, true); } s->state = chr ? RS_IDLE : RS_INACTIVE; s->mon_chr = mon_chr; s->current_syscall_cb = NULL;