| Message ID | 20181031141925.30026-23-mdroth@linux.vnet.ibm.com |
|---|---|
| State | New |
| Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZXbxZuNL"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42lWBQ3y6Kz9s2P for <incoming@patchwork.ozlabs.org>; Thu, 1 Nov 2018 01:37:02 +1100 (AEDT) Received: from localhost ([::1]:59961 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1gHrcC-0000cb-3o for incoming@patchwork.ozlabs.org; Wed, 31 Oct 2018 10:37:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1gHrMr-00015b-Pn for qemu-devel@nongnu.org; Wed, 31 Oct 2018 10:21:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1gHrMo-0007Ks-3K for qemu-devel@nongnu.org; Wed, 31 Oct 2018 10:21:09 -0400 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]:39703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <flukshun@gmail.com>) id 1gHrMm-0007Gz-Gc for qemu-devel@nongnu.org; Wed, 31 Oct 2018 10:21:04 -0400 Received: by mail-oi1-x229.google.com with SMTP id e3-v6so13739465oiy.6 for <qemu-devel@nongnu.org>; Wed, 31 Oct 2018 07:20:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=aQGNc6BTaCf/YRgBGfwzjlAuGKMF/EXD2CCPOpt5Prw=; b=ZXbxZuNLyWR7ChjRQfVpPPa0dpca9lglQdborglig+L3sawXJf0Qq93HhjRLQN2Gzj 02xzjbNFoCrW5GFnbk4oJLSP7XKexTDyrDCfkdDIk5D3ci2mG8Ygwn6TuQn+tlIIZxjq ikbJDLCEuQC/tdnhAK8q0azMU9Rfw4yYsijj8kBZMNzF2zMfkVwFb2jLpKlP30ZLopH3 NQlrQWZd7ExRwILqIKIe4CR+bTfKdd5+aHwvHvM4qEc6flVZUbzFTQcD/FxVJWS8Npth knT/HvNMrFO2FwbGJAALfWjnHdFrAnyHhF3UjPZLVbcIJd4KYszbj96QZ+XKxkJNBQLn 4wRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=aQGNc6BTaCf/YRgBGfwzjlAuGKMF/EXD2CCPOpt5Prw=; b=rhaCXKy9AxCH3XftVB16U/0rOcntJBEnikdgIJRT98QxljHl6OoJ1PpGGSYMNCwed1 iAzZe8HAueGG+o8dek2bA5UymOpjimP2WmtZp4S+ofCeeJbvoL1d4kSrw3rIELc4b8w1 5v/r+JGHKhPj6hjy+1X6RMIP4zQYUTBuKAGpXG8t5T9jEoMh7Wbo1Ojzu3+OcFxdHOdk AcRmfLvTvM+TfMFZtpR6gwSS1dg0Ezg/aNQhGLgGhVfOh1zZVpg3o8k9/l4htY9U2UEB 6BihzKfpnRcEeTJXPto8E86NKEVMeyCvnKay8qSr0EFw+Ch6FSKvXg0Q77RYqhSdjmMT L1kg== X-Gm-Message-State: AGRZ1gLpRe9THektnRFoCOJaus9t22IfCuKLCKv4fld9Sg0R+DkApSpH 0ojDjAyAquUjymD3G8Z2CwRlUgU5 X-Google-Smtp-Source: AJdET5dRFzJ0d2lai7olCwwQMiPErPJaAPa3WHQjzsJda+c9FuWHuLENjRyLvmbE7hU/i85ZRAK5TQ== X-Received: by 2002:aca:dcd7:: with SMTP id t206-v6mr1816280oig.20.1540995658166; Wed, 31 Oct 2018 07:20:58 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id b82-v6sm1446302oif.19.2018.10.31.07.20.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 31 Oct 2018 07:20:57 -0700 (PDT) From: Michael Roth <mdroth@linux.vnet.ibm.com> To: qemu-devel@nongnu.org Date: Wed, 31 Oct 2018 09:19:23 -0500 Message-Id: <20181031141925.30026-23-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031141925.30026-1-mdroth@linux.vnet.ibm.com> References: <20181031141925.30026-1-mdroth@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::229 Subject: [Qemu-devel] [PULL v3 22/24] qga-win: install service with --retry-path set by default X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
| Series |
[PULL,v3,01/24] qga: Support Unicode paths in guest-file-open on win32
|
expand
|
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs index f751a7e9f7..64bf90bd85 100644 --- a/qga/installer/qemu-ga.wxs +++ b/qga/installer/qemu-ga.wxs @@ -78,7 +78,7 @@ Account="LocalSystem" ErrorControl="ignore" Interactive="no" - Arguments="-d" + Arguments="-d --retry-path" > </ServiceInstall> <ServiceControl Id="StartService" Start="install" Stop="both" Remove="uninstall" Name="QEMU-GA" Wait="no" />
It's nicer from a management perspective that the agent can survive hotplug/unplug of the channel device, or be started prior to the installation of the channel device's driver without and still be able to resume normal function afterward. On linux there are alternatives like systemd to support this, but on w32 --retry-path is the only option so it makes sense to set it by default when installed as a w32 service. Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com> --- qga/installer/qemu-ga.wxs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)