Message ID | 20181025144644.15464-7-cota@braap.org |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=braap.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=braap.org header.i=@braap.org header.b="HitOi8hH"; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="XQvVEVZz"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42gs6S637Tz9sDC for <incoming@patchwork.ozlabs.org>; Fri, 26 Oct 2018 02:50:56 +1100 (AEDT) Received: from localhost ([::1]:55293 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1gFhuQ-00055q-3n for incoming@patchwork.ozlabs.org; Thu, 25 Oct 2018 11:50:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <cota@braap.org>) id 1gFh5V-0002yq-8J for qemu-devel@nongnu.org; Thu, 25 Oct 2018 10:58:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <cota@braap.org>) id 1gFgur-0007q5-Ho for qemu-devel@nongnu.org; Thu, 25 Oct 2018 10:47:18 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:51093) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from <cota@braap.org>) id 1gFgun-0007eu-3y for qemu-devel@nongnu.org; Thu, 25 Oct 2018 10:47:13 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 474AF21F34; Thu, 25 Oct 2018 10:46:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 25 Oct 2018 10:46:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h= from:to:cc:subject:date:message-id:in-reply-to:references; s= mesmtp; bh=YLZe+gFCuTVOuz+1E1nyb15WGSBN2LFKWfYK6jhZJw8=; b=HitOi 8hHdzwtSKTEwkFoMR1cBgB5rW/iwJFRXjxuaInA4tvAOAUbFm5uJiZqgpBgUcVXo niiBIHa1Ufg+7ddT1x0lbGEjDll0GxFlXn71CpHL9pKuKy3bKU/gDSX74kelKlqP BYeYDMTMI2K6gw0uPR8RtGaQi7rAXIomin1ddQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=YLZe+gFCuTVOuz+1E1nyb15WGSBN2 LFKWfYK6jhZJw8=; b=XQvVEVZz0ACf5C4PZ+drfsxUQvJ5hkJZlTIRd08oy2Qm2 oMV3OFxPctp/nLtKMbRkvHgKpAuG36FC109AdN8oNNkdks6V/eQetm7K/WwLhLD3 5dQeMg4K1S9SGIwDamhDs5GhscTKb//UNcP/5/4BasbhnfLrELTUJiORMx5hBqp+ aIMlJoj/B9cCq5IzSrVxcJiQ75658vtjAW2DgwlnQSoa+rpQPkDd5cz5FfRm21+z GFC9MjSH0cL0xt8xPLsn79ghVeIxA4gYCEp9CLm8XsNIfUem+ozMDXK6UxnIn+45 exPrydPV3eVTV02cZ7jgX5bnyEG1nZ537Z2vWpnTA== X-ME-Sender: <xms:V9fRW8PRit9uV0eEml9-IMDoxrOvnubWZnmLYBG-c1_Qdpzj_-yFXg> X-ME-Proxy: <xmx:V9fRW0tTA7xIk3PfWNU7v834ylD67ArQ35j-SaqXMUKwMuPJLsEozA> <xmx:V9fRW-3P4zPREHIy5ypbDA7lj7DmvVMfPOqGrvF2eTkJEATQjYEMbw> <xmx:V9fRW7xqLM4LSE86MtzAlHiAnZTnFo6lIFIgcXbiDYSPjspqG1q-iA> <xmx:V9fRW67c6L_2cSpKjmp9l-Dup8M6xiSjQup4T9G_-jtE9-BzkgxSSw> <xmx:V9fRWwiWbn3Y9f5kJecKYB7r5okvkltFtCC3GVEwA2YGJs5k3BSuKA> <xmx:V9fRW_SHa-QvrThTqDW5HFDpEhzhn3ARzq4SnlXTV0hgJQCsXfeTdA> Received: from localhost (flamenco.cs.columbia.edu [128.59.20.216]) by mail.messagingengine.com (Postfix) with ESMTPA id CC656E421C; Thu, 25 Oct 2018 10:46:46 -0400 (EDT) From: "Emilio G. Cota" <cota@braap.org> To: qemu-devel@nongnu.org Date: Thu, 25 Oct 2018 10:45:40 -0400 Message-Id: <20181025144644.15464-7-cota@braap.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025144644.15464-1-cota@braap.org> References: <20181025144644.15464-1-cota@braap.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 66.111.4.27 Subject: [Qemu-devel] [RFC v4 07/71] tcg-runtime: define helper_cpu_halted_set X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <richard.henderson@linaro.org> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[RFC,v4,01/71] cpu: convert queued work to a QSIMPLEQ
|
expand
|
On 10/25/18 3:45 PM, Emilio G. Cota wrote: > +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val) > +{ > + CPUState *cpu = ENV_GET_CPU(env); > + > + cpu->halted = val; > +} I suppose this is fine as a first step. I'd like to clean up all of the targets to also use a helper like this to also raise EXCP_HALTED. They all perform the same actions, even though this isn't obvious (many of them reuse helpers that also raise target-specific exceptions). That said, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/accel/tcg/tcg-runtime.h b/accel/tcg/tcg-runtime.h index 1bd39d136d..d767f8515b 100644 --- a/accel/tcg/tcg-runtime.h +++ b/accel/tcg/tcg-runtime.h @@ -28,6 +28,8 @@ DEF_HELPER_FLAGS_1(lookup_tb_ptr, TCG_CALL_NO_WG_SE, ptr, env) DEF_HELPER_FLAGS_1(exit_atomic, TCG_CALL_NO_WG, noreturn, env) +DEF_HELPER_FLAGS_2(cpu_halted_set, TCG_CALL_NO_RWG, void, env, i32) + #ifdef CONFIG_SOFTMMU DEF_HELPER_FLAGS_5(atomic_cmpxchgb, TCG_CALL_NO_WG, diff --git a/accel/tcg/tcg-runtime.c b/accel/tcg/tcg-runtime.c index d0d4484406..4aa038465f 100644 --- a/accel/tcg/tcg-runtime.c +++ b/accel/tcg/tcg-runtime.c @@ -167,3 +167,10 @@ void HELPER(exit_atomic)(CPUArchState *env) { cpu_loop_exit_atomic(ENV_GET_CPU(env), GETPC()); } + +void HELPER(cpu_halted_set)(CPUArchState *env, uint32_t val) +{ + CPUState *cpu = ENV_GET_CPU(env); + + cpu->halted = val; +}
Signed-off-by: Emilio G. Cota <cota@braap.org> --- accel/tcg/tcg-runtime.h | 2 ++ accel/tcg/tcg-runtime.c | 7 +++++++ 2 files changed, 9 insertions(+)