diff mbox series

[v2] piix_pci: change the i440fx data sheet link

Message ID 20181011161820.38794-1-liq3ea@163.com
State New
Headers show
Series [v2] piix_pci: change the i440fx data sheet link | expand

Commit Message

Li Qiang Oct. 11, 2018, 4:18 p.m. UTC 
Seems the intel link is unavailable, change it to qemu site.

Signed-off-by: Li Qiang <liq3ea@163.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 hw/pci-host/piix.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Markus Armbruster Oct. 11, 2018, 5:14 p.m. UTC | #1 
Li Qiang <liq3ea@163.com> writes:

> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daud© <philmd@redhat.com>

Mojibake.  Perhaps the maintainer is willing to correct it.
Marcel Apfelbaum Oct. 18, 2018, 1:41 p.m. UTC | #2 
On 10/11/18 7:18 PM, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
>
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   hw/pci-host/piix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..56a42055f1 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>   
>   /*
>    * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/File:29054901.pdf
>    */
>   

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Thanks,
Marcel

>   #define I440FX_PCI_HOST_BRIDGE(obj) \
Philippe Mathieu-Daudé Oct. 18, 2018, 3:48 p.m. UTC | #3 
On 18/10/2018 15:41, Marcel Apfelbaum wrote:
> 
> 
> On 10/11/18 7:18 PM, Li Qiang wrote:
>> Seems the intel link is unavailable, change it to qemu site.
>>
>> Signed-off-by: Li Qiang <liq3ea@163.com>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
>>   hw/pci-host/piix.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
>> index 0e608347c1..56a42055f1 100644
>> --- a/hw/pci-host/piix.c
>> +++ b/hw/pci-host/piix.c
>> @@ -40,7 +40,7 @@
>>     /*
>>    * I440FX chipset data sheet.
>> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
>> + * https://wiki.qemu.org/File:29054901.pdf
>>    */
>>   
> 
> Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>

Perhaps the maintainer can add a space before your email.

> 
> Thanks,
> Marcel
> 
>>   #define I440FX_PCI_HOST_BRIDGE(obj) \
>
Michael S. Tsirkin Oct. 23, 2018, 10:47 p.m. UTC | #4 
On Thu, Oct 11, 2018 at 09:18:20AM -0700, Li Qiang wrote:
> Seems the intel link is unavailable, change it to qemu site.
> 
> Signed-off-by: Li Qiang <liq3ea@163.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

BTW you need to fix up your setup: patches you sent confuse git
am and other tools. Somethig to do with encoding.

> ---
>  hw/pci-host/piix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index 0e608347c1..56a42055f1 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -40,7 +40,7 @@
>  
>  /*
>   * I440FX chipset data sheet.
> - * http://download.intel.com/design/chipsets/datashts/29054901.pdf
> + * https://wiki.qemu.org/File:29054901.pdf
>   */
>  
>  #define I440FX_PCI_HOST_BRIDGE(obj) \
> -- 
> 2.17.1
> 
>
diff mbox series

Patch

diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 0e608347c1..56a42055f1 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -40,7 +40,7 @@ 
 
 /*
  * I440FX chipset data sheet.
- * http://download.intel.com/design/chipsets/datashts/29054901.pdf
+ * https://wiki.qemu.org/File:29054901.pdf
  */
 
 #define I440FX_PCI_HOST_BRIDGE(obj) \