Message ID | 20180830163831.18586-1-marcandre.lureau@redhat.com |
---|---|
State | New |
Headers | show |
Series | libvhost-user: fix clang enum-conversion warning | expand |
On Thu, Aug 30, 2018 at 8:50 PM Marc-André Lureau <marcandre.lureau@redhat.com> wrote: > > Now that the VhostUserMsg.request field is used for both master & > slave requests, since commit d84599f56c820d8c1ac9928a76500dcdfbbf194d: > > contrib/libvhost-user/libvhost-user.c:953:20: error: implicit conversion from enumeration type 'enum VhostUserSlaveRequest' to different enumeration type 'VhostUserRequest' (aka 'enum VhostUserRequest') [-Werror,-Wenum-conversion] > .request = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> ping, thanks > --- > contrib/libvhost-user/libvhost-user.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h > index 4aa55b4d2d..c0133b7f3f 100644 > --- a/contrib/libvhost-user/libvhost-user.h > +++ b/contrib/libvhost-user/libvhost-user.h > @@ -145,7 +145,7 @@ typedef struct VhostUserVringArea { > #endif > > typedef struct VhostUserMsg { > - VhostUserRequest request; > + int request; > > #define VHOST_USER_VERSION_MASK (0x3) > #define VHOST_USER_REPLY_MASK (0x1 << 2) > -- > 2.19.0.rc0.48.gb9dfa238d5 > >
diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h index 4aa55b4d2d..c0133b7f3f 100644 --- a/contrib/libvhost-user/libvhost-user.h +++ b/contrib/libvhost-user/libvhost-user.h @@ -145,7 +145,7 @@ typedef struct VhostUserVringArea { #endif typedef struct VhostUserMsg { - VhostUserRequest request; + int request; #define VHOST_USER_VERSION_MASK (0x3) #define VHOST_USER_REPLY_MASK (0x1 << 2)
Now that the VhostUserMsg.request field is used for both master & slave requests, since commit d84599f56c820d8c1ac9928a76500dcdfbbf194d: contrib/libvhost-user/libvhost-user.c:953:20: error: implicit conversion from enumeration type 'enum VhostUserSlaveRequest' to different enumeration type 'VhostUserRequest' (aka 'enum VhostUserRequest') [-Werror,-Wenum-conversion] .request = VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- contrib/libvhost-user/libvhost-user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)