| Message ID | 20180830155810.17629-4-marcandre.lureau@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | tests: add a few QMP-related tests | expand |
On 2018-08-30 17:58, Marc-André Lureau wrote: > test_qom_set_without_value() is about a bug in infrastructure used by > the QMP core, fixed in commit c489780203. We covered the bug in > infrastructure unit tests (commit bce3035a44). I wrote that test > earlier, to cover QMP level as well, the test could go into qmp-test. > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > tests/qmp-test.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/qmp-test.c b/tests/qmp-test.c index b3472281ae..2b923f02db 100644 --- a/tests/qmp-test.c +++ b/tests/qmp-test.c @@ -321,6 +321,19 @@ static void test_qmp_preconfig(void) qtest_quit(qs); } +static void test_qom_set_without_value(void) +{ + QTestState *qts; + QDict *resp; + + qts = qtest_init(common_args); + resp = qtest_qmp(qts, "{'execute': 'qom-set', 'arguments':" + " { 'path': '/machine', 'property': 'rtc-time' } }"); + g_assert_nonnull(resp); + qmp_assert_error_class(resp, "GenericError"); + qtest_quit(qts); +} + int main(int argc, char *argv[]) { g_test_init(&argc, &argv, NULL); @@ -328,6 +341,7 @@ int main(int argc, char *argv[]) qtest_add_func("qmp/protocol", test_qmp_protocol); qtest_add_func("qmp/oob", test_qmp_oob); qtest_add_func("qmp/preconfig", test_qmp_preconfig); + qtest_add_func("qmp/qom-set-without-value", test_qom_set_without_value); return g_test_run(); }
test_qom_set_without_value() is about a bug in infrastructure used by the QMP core, fixed in commit c489780203. We covered the bug in infrastructure unit tests (commit bce3035a44). I wrote that test earlier, to cover QMP level as well, the test could go into qmp-test. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> --- tests/qmp-test.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)