From patchwork Sun Aug 19 20:22:55 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcel Apfelbaum X-Patchwork-Id: 959682 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="X1tNalzB"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41vDLk19n9z9s9J for ; Mon, 20 Aug 2018 22:55:42 +1000 (AEST) Received: from localhost ([::1]:46930 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frjid-0007tj-Pf for incoming@patchwork.ozlabs.org; Mon, 20 Aug 2018 08:55:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frjYr-0000Cx-4Q for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frjYm-0000io-Rh for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:33 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]:35765) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1frjYh-0000gE-Hh for qemu-devel@nongnu.org; Mon, 20 Aug 2018 08:45:23 -0400 Received: by mail-wr1-x435.google.com with SMTP id g1-v6so12896253wru.2 for ; Mon, 20 Aug 2018 05:45:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jgv9mnSe5UFOKPEhvre7MHygguyrScAx7XFRUOWRBj0=; b=X1tNalzBeVC/wSx+vYz95hwD+K61uaJXjKj6VZlCZmGbJXxjmgDj3VWN35Z2DeZqXx czxbdvKgAhoLtNGClSTHVrBItlSn2G8ngDsA2UZLEbkglmlSIhJVSFtYN+uD3xtYXn5I J6faI/BwS3CIXJ1CotPVj/83xHlCBCuYcIhwfTlQrVGkPZrmiTbPgobKFB8YvBA/2fgu +ZNzr9MRFcdmjlPW1xeogaLz/c88U6ZttmZDofeo4wgUUdWA82yhxpgdhRohOuepLwSR YdNf6rC5GpFrwRuJEjdyqFJBDg+pxkFfD/mKAV1cpnGPgFg1UeFPePcbb+XANEHcWWBi A6IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jgv9mnSe5UFOKPEhvre7MHygguyrScAx7XFRUOWRBj0=; b=NJoFi5yiL8AvGQNJQMkRWolPoUwWUG3oHKQuGAKIPM8qNuc4sygqeMlV26NCyKeZnA sJbfZKcdxliNJjC1e6sLOgXx7aUvrp/wzEEEljK9O0EYzIb3/qczjQIh/frVd2v68B/D wPYYvanm82wdIZ+Ep5IJbKPRcHKFbWaIdWt4zLj8GTn7a04fk7Btnuqg4huEd/9aH+YH USHmycr0kjNSqp9HuzTTph08MjJ1LUVTp8ZaKqRQxylia+Aj34DeMDooXhjKn3UabUuD OiuwaqQSTJ4fuKOVubMg6uDvNUZu8Vj1/lacYkxvrohKBYBG/av7l14Gswwr56kVcujN 2EpQ== X-Gm-Message-State: APzg51AptqXjnex/j+7Yo9mwO+HH13l7ccyANQbVw9VcNIbxbhjuRshB tA2CbHd9nQG8C24DOt0y5s4g/7vn X-Google-Smtp-Source: ANB0VdY23VmOoaCoVJF2k5xavJH+BSZ3ZJMh6HdMeVaPtn6N++II50g0F5N6yilsXnjYXnnRma17KQ== X-Received: by 2002:a5d:4410:: with SMTP id z16-v6mr6996793wrq.272.1534769121662; Mon, 20 Aug 2018 05:45:21 -0700 (PDT) Received: from localhost.localdomain ([176.228.154.53]) by smtp.gmail.com with ESMTPSA id g2-v6sm26704613wrd.71.2018.08.20.05.45.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 20 Aug 2018 05:45:21 -0700 (PDT) From: Marcel Apfelbaum To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sun, 19 Aug 2018 23:22:55 +0300 Message-Id: <20180819202300.10590-11-marcel.apfelbaum@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180819202300.10590-1-marcel.apfelbaum@gmail.com> References: <20180819202300.10590-1-marcel.apfelbaum@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::435 Subject: [Qemu-devel] [PATCH PULL 10/15] hw/rdma: Cosmetic change - move to generic function X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: thuth@redhat.com, yuval.shaia@oracle.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Yuval Shaia To ease maintenance of struct comp_thread move all related code to dedicated function. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum Message-Id: <20180805153518.2983-11-yuval.shaia@oracle.com> Signed-off-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c index 52981d652d..d29acc505b 100644 --- a/hw/rdma/rdma_backend.c +++ b/hw/rdma/rdma_backend.c @@ -146,10 +146,10 @@ static void *comp_handler_thread(void *arg) return NULL; } -static void stop_comp_thread(RdmaBackendDev *backend_dev) +static void stop_backend_thread(RdmaBackendThread *thread) { - backend_dev->comp_thread.run = false; - while (backend_dev->comp_thread.is_running) { + thread->run = false; + while (thread->is_running) { pr_dbg("Waiting for thread to complete\n"); sleep(THR_POLL_TO / SCALE_US / 2); } @@ -159,7 +159,7 @@ static void start_comp_thread(RdmaBackendDev *backend_dev) { char thread_name[THR_NAME_LEN] = {0}; - stop_comp_thread(backend_dev); + stop_backend_thread(&backend_dev->comp_thread); snprintf(thread_name, sizeof(thread_name), "rdma_comp_%s", ibv_get_device_name(backend_dev->ib_dev)); @@ -876,7 +876,7 @@ void rdma_backend_start(RdmaBackendDev *backend_dev) void rdma_backend_stop(RdmaBackendDev *backend_dev) { pr_dbg("Stopping rdma_backend\n"); - stop_comp_thread(backend_dev); + stop_backend_thread(&backend_dev->comp_thread); } void rdma_backend_fini(RdmaBackendDev *backend_dev)