| Message ID | 20180727155602.10148-1-armbru@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 27 July 2018 at 16:55, Markus Armbruster <armbru@redhat.com> wrote: > The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: > > Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) > > are available in the Git repository at: > > git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27 > > for you to fetch changes up to 307fb894ce0608aede990ec40ce84eaeb358c8ec: > > qstring: Move qstring_from_substr()'s @end one to the right (2018-07-27 17:16:03 +0200) > > ---------------------------------------------------------------- > QObject patches for 2018-07-27 (3.0.0-rc3) > > This pull request fixes an integer overflow bug, and hardens the code > in question a bit. Abuse of QMP can make the bug crash QEMU, so it > seems worth fixing at this late stage. > > ---------------------------------------------------------------- > Markus Armbruster (2): > qstring: Assert size calculations don't overflow > qstring: Move qstring_from_substr()'s @end one to the right > > liujunjie (1): > qstring: Fix qstring_from_substr() not to provoke int overflow Hi -- this passes my buildtests, but the commit from liujunjie seems to be missing your maintainer signed-off-by (and possibly a reviewed-by tag ?) Can I ask you to fix that up and resend, please? thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> writes: > On 27 July 2018 at 16:55, Markus Armbruster <armbru@redhat.com> wrote: >> The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: >> >> Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) >> >> are available in the Git repository at: >> >> git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27 >> >> for you to fetch changes up to 307fb894ce0608aede990ec40ce84eaeb358c8ec: >> >> qstring: Move qstring_from_substr()'s @end one to the right (2018-07-27 17:16:03 +0200) >> >> ---------------------------------------------------------------- >> QObject patches for 2018-07-27 (3.0.0-rc3) >> >> This pull request fixes an integer overflow bug, and hardens the code >> in question a bit. Abuse of QMP can make the bug crash QEMU, so it >> seems worth fixing at this late stage. >> >> ---------------------------------------------------------------- >> Markus Armbruster (2): >> qstring: Assert size calculations don't overflow >> qstring: Move qstring_from_substr()'s @end one to the right >> >> liujunjie (1): >> qstring: Fix qstring_from_substr() not to provoke int overflow > > > Hi -- this passes my buildtests, but the commit from liujunjie > seems to be missing your maintainer signed-off-by (and possibly > a reviewed-by tag ?) Can I ask you to fix that up and resend, > please? My apologies. v2 sent.
The following changes since commit 18a398f6a39df4b08ff86ac0d38384193ca5f4cc: Update version for v3.0.0-rc2 release (2018-07-24 22:06:31 +0100) are available in the Git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qobject-2018-07-27 for you to fetch changes up to 307fb894ce0608aede990ec40ce84eaeb358c8ec: qstring: Move qstring_from_substr()'s @end one to the right (2018-07-27 17:16:03 +0200) ---------------------------------------------------------------- QObject patches for 2018-07-27 (3.0.0-rc3) This pull request fixes an integer overflow bug, and hardens the code in question a bit. Abuse of QMP can make the bug crash QEMU, so it seems worth fixing at this late stage. ---------------------------------------------------------------- Markus Armbruster (2): qstring: Assert size calculations don't overflow qstring: Move qstring_from_substr()'s @end one to the right liujunjie (1): qstring: Fix qstring_from_substr() not to provoke int overflow block/blkdebug.c | 2 +- block/blkverify.c | 2 +- block/nbd.c | 2 +- include/qapi/qmp/qstring.h | 2 +- qobject/qstring.c | 12 ++++++++---- tests/check-qobject.c | 2 +- tests/check-qstring.c | 2 +- 7 files changed, 14 insertions(+), 10 deletions(-)