From patchwork Tue Jul 24 22:17:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leonid Bloch X-Patchwork-Id: 948907 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=janustech.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=janustech.onmicrosoft.com header.i=@janustech.onmicrosoft.com header.b="MQh8BfsJ"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41ZtBf5qdyz9s2g for ; Wed, 25 Jul 2018 08:22:02 +1000 (AEST) Received: from localhost ([::1]:42814 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi5gu-00012Q-GT for incoming@patchwork.ozlabs.org; Tue, 24 Jul 2018 18:22:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fi5dj-0006j3-Qo for qemu-devel@nongnu.org; Tue, 24 Jul 2018 18:18:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fi5dg-0007CS-Am for qemu-devel@nongnu.org; Tue, 24 Jul 2018 18:18:43 -0400 Received: from mail-bn3nam01on0132.outbound.protection.outlook.com ([104.47.33.132]:57302 helo=NAM01-BN3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fi5dg-0007Bm-5W; Tue, 24 Jul 2018 18:18:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janustech.onmicrosoft.com; s=selector1-janustech-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aqMmRNU/7KRZTAja561wiGva9NoVtDNSGoa3NKB24bs=; b=MQh8BfsJSG1w2Tcaek1gVqOG6FCSybtlZOjSBnZ/y44o6A0B9bUT8sPPMjIB1vATpDcpebJmKdsfaAlfnkzMkH0tD76LiAsrDlNVvmlnVvqqEJ6wFc+ypnnFVmM7BuAlzvJx1dcGP3FApvecqSq/sJAvaAlOKbq3CK9R/Ze9RmU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=lbloch@janustech.com; Received: from Jupiter.local (141.226.29.227) by BN3PR07MB2612.namprd07.prod.outlook.com (2a01:111:e400:c5f0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Tue, 24 Jul 2018 22:18:36 +0000 From: Leonid Bloch To: qemu-devel@nongnu.org Date: Wed, 25 Jul 2018 01:17:48 +0300 Message-Id: <20180724221750.16282-3-lbloch@janustech.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180724221750.16282-1-lbloch@janustech.com> References: <20180724221750.16282-1-lbloch@janustech.com> MIME-Version: 1.0 X-Originating-IP: [141.226.29.227] X-ClientProxiedBy: HE1PR05CA0128.eurprd05.prod.outlook.com (2603:10a6:7:28::15) To BN3PR07MB2612.namprd07.prod.outlook.com (2a01:111:e400:c5f0::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a00ad46a-6b7b-4561-7249-08d5f1b367b1 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(7021125)(8989117)(5600073)(711020)(4534165)(7022125)(4603075)(4627221)(201702281549075)(8990107)(7048125)(7024125)(7027125)(7028125)(7023125)(2017052603328)(7153060)(7193020); SRVR:BN3PR07MB2612; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 3:vuS3CA6eMiJPhE+jZolC7pYc254ir8UCOJsDAEcMpnIzkiG7hCCJk5nxkuBvLIhv0O9z2caJEDhpNRvWxqOjgw/jMILf6VuRkctcH6zxl2gnBwHAAOXKEyc5fbCUVnTn+/fOG4h9d5lCAMte2EnY+U4XwWZT/RmH8T797SOpg6xpRfw41/AUYNguPkV0jgcspI0stk1ZXrsCm1n1ZCgpip9/S0oYs4OVXaUhNpuprBG2U0DpXr6cp1YbcgPyErX1; 25:ZYztk0DqD0MvPHzNCszl6xPdFuXNcL7pC7a4/K53zYcfUklv9eLisWRp8Lun760E4+7n01/MyfkpToteV/EirdrHkAKPKzOj7B3XYtRkEUlvgLNAAZBd1zd3wdvzp1mM431OofxIrbkT8wYLxOs1WmnwJTqiQrVTzSdZw3cCRf1l2lEKGT81nEPPQQf4z6QeEojO+p86jDLgkbFIim9NwOSYNwAIm60F9HYS93byVA1XQHWqSRcgGoQa6JY5uYj5w3oxPsBIcrje51nE1u84itEdHQDhXUB3MyFJrLJa1EL6m2kgIJ5SIujCaxYzwmID1mo4doBjXQTD9NDclftsaw==; 31:rIcbfBkJHhfrmsyBIVMxJhNJ3DD/M3jsnPDOIj6Kkwjb6mLFL167oXDweii+0X0CrlTVY2xWywLcOoZke6yUf/mE4n9OgIsoBi9e9zrftu6WrTSzG/kxH0tNhqCLJJ01jLL6H14USXC0uR7ohZFQF/bKWzDD9PJheSC3NpDl5ArV4AdAbOxXuzqO+ZmKjS4tcOAnBrHHpcRzATjTihI4bYR8EEWWHQTJiNq+YJeNSzI= X-MS-TrafficTypeDiagnostic: BN3PR07MB2612: X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(2016111802025)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(6043046)(201708071742011)(7699016); SRVR:BN3PR07MB2612; BCL:0; PCL:0; RULEID:; SRVR:BN3PR07MB2612; X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 4:lJUzf5DWmqD+X7+TrK4HD0Wrbatxa07UrvbS3Z3sqHGotzYNQH7Amf3rDAKNFg9E1BNliB8Gv7mWeiRv8ygFyxr8Ma9rKAxvDlb9BeJ04IIPB7VLIKM1gAvdDQy77uT36/5U7Rg1kLPY0nRlKPvgJrm03nX1zESN9HtT5QLWMVNwlc1Ueu5BX/W1ttSVfN62W28MsiBs3MaM9lvcRtpLqa09JYNWPwzbQyFNMqjSkQiBFlX9X0PZ/lneu1Iv+uw8ySwRSiIUXQmyuq5/Urqy2Q== X-Forefront-PRVS: 0743E8D0A6 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(39830400003)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(68736007)(14444005)(3846002)(52116002)(4326008)(51416003)(1076002)(76176011)(2361001)(53936002)(54906003)(5660300001)(25786009)(8676002)(107886003)(2906002)(6486002)(6666003)(6116002)(86362001)(50466002)(48376002)(6916009)(575784001)(486006)(6512007)(36756003)(2351001)(478600001)(97736004)(66066001)(305945005)(7736002)(2616005)(8936002)(956004)(11346002)(476003)(47776003)(446003)(186003)(16586007)(16526019)(81156014)(26005)(316002)(6506007)(50226002)(106356001)(105586002)(81166006)(386003); DIR:OUT; SFP:1102; SCL:1; SRVR:BN3PR07MB2612; H:Jupiter.local; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: janustech.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN3PR07MB2612; 23:1ENaYApwAeN+QD1FwoPmB0NwqU+ZRB2ji1AAt41hr?= MDn6S8+f4JMOUt8uAwE691FdSrEnsJDYo9Nv0orx59D7aC/J0S1BRgoNHe6mGBO/59LhQiWOpiSdIPSEv23hJuafF1IUZknp9SxRMpSGxxgYWJdGcgMnB/dj6FdCbqshsK707E5mHqFBbRPaFPWHE8h/Ka92uKupgsKKi411UCrY8gqWQBEE7kdTDDeL3GNBeFIvUn3zn6A/KehSvQqqM2++fEiSxyTzJYL+YEqqEmRI4ZYv9d3bEuCVtjfSEfjq0lpQ299KeKaL6uwwgn3qwlzV1sPHd8QJlSfdm+UCH/10KlMc6B1E2wE6VUQ840RUSyZ3sp6U1DLszLg1jtEy/VkFPIYQ8welyjNHAyKLnwstb8FjppkDbNk1sUomnTIm1KoflzEr72HjT0je1UMnrd8O1+PL8jOC8gjZX1/MB+qedlChJnFBZrk/9fA7xX+Lig8tlZU1H2mkPieJouhEtqr41/EWAqCuHEHWW3ULfaBybT5YWhXR85fjzGH303TRIw3e+2/tefRSBuehQ1tzAAnRg/tuSPm9jusghmhED5aFlbUiOEWol0CRUY+mENFqdGeuoD7PIom0wQEsjCx6S/0ecTi/OBBowFXgfA+wr/dT4v3JuxXXZF1qt+1bu+vEmcIJqYXB0EbWmFas6br3utN99WsgZjICGdVx8If9plKA4m3d9FRUtElKCcx9gnNfuUbjjHTbU/Zix9gL2rV6BEJqVDIN6GBpzIgXenhlXTjZCkZhgw88AKZtVxMX3Pw4HWINSGfBrnZZ3bMF/OzmDVBGB+Gg3f90EUQvPOOcT7XKRj9cjjSIfx0Zi9a5tiwbbwkk05f5tj5cXtjtn8qiJE0cYpQZhMG4gKo3Q+nzAUcZLlBLrC3zUiiOfr06MMR3MJQaWh2qzlXvclLDqwYqf+7rVoDVl5ImUT4h3B/xbL1kBAELTbCJ7Pv4csTkue3gK7+1f83cLAdVQFJ/M6IdWPRuYnsVnBRXvB47X+RDVSlrAorWnY6g9ctUe59FU3r6qgoUoguAx3tMLgENEX+0Qbesw1ULgmAfeTRe5KLScpAlUf/5Bn7ySKjbeoAsx7+lgi+nmJdxUj5HBWM+EfvmtDd/b8wVXsQrYl45Chw9NchkNcTfki+47QmRiBzKouVhZsqO7fuP9C3qVhWZOUT4jEjHmV0XolsXaKt0nCwyrZlJoNmoa93k4wnIi1HlCytrtETHsV0SxGSiKtwj9+HSP/mALQsSyHzlRCb5UmrnK+jTX/m8Wl6y6dcGxa0+RZSunY= X-Microsoft-Antispam-Message-Info: iLNwI8eytd79Dtg/0wiDy/79QjeFE/cqY95PHsJBzhFjQkqHqRwK880X/3/u2skenktGswS0XZ335r6f5DKgs6P9fKsQUdWMqCGPX2mtlBmh9cOzkGayqNh6unnATsIMSz4yVL6YC9TK+/vIW/H6zZVNE+sAIG1yDfqhePUUbo4jzbwE3ZssgU43SmIiqpakPtAb4ghKDYQ+PB7AHdp6E6TsNwShmReDOZw0ORbeJD+mxxa9wmGFL9Bf9YESgzq2OmghPwWBd2DaqcpTq1wJTdl17U4vtUp7zvZ28p0kRu7w8R2V/S29MH/jpLyI7Us3X/7BIkZLvH0ZihNkmvk5HFkvUPZXV2ntUPjEXTSfk5Q= X-Microsoft-Exchange-Diagnostics: 1; BN3PR07MB2612; 6:1HX6tW4RQIay1jpS4fNs6wfkNxaTUlJIoP9KIt4CeovWxIzyXHezUo1BLyE7TTlcNpdspi3rC3slxOJrflY88BwGmyLPaBeOeQWG7rt2+jxGMukUeIB/nyu5t3M5qvAbUsjcVi37NZAP4EJVK4Z6E6DWi+PdGuiuyQpdCj1lldUGtgjzNWb42H7vHuMX6Bzvihga5KtTe2Y3BZuizER2aGwAYptUcQol6K2U6WaPM1Pc5kERXDS5k/f9NgPeGWOmVbdrj4u5QrZ2u2XVK6blBh2ezwsA/4eC0DtsG4RWNnPOKBeQO0+Q3aRgXPBKEc4vF3SIkXuV62wKRxIBJWUDqhiMi9od+rXabuTIv6XETvXw/p9c14hZLJ1yjmSKaPFZttmfLUsEO+/IN5M5mx0x6I0m41feA4k735YEfmtt+oDAYs5v7d6HjOeV0+2qu2/eYm6DFLul86NR+wpzsxtfKQ==; 5:FV/RpIFQ6taAp+KimdcGw7esp/WBE3YkPYkyTP9CI0y7V2e01I1iTI49C9i+47rUmy1ZwXzqT9K9mqXN5OjNmaynV67Auf9IuitEEMFbg57/IlnxLfMR8QDvcH5AolWfFBkfAWAbi1MHPrvE24Wxs9pMEhSxqQij4q7VIj6ofBs=; 7:evNvseRiJx8jfm5Zc4LjJI+sOeGN7lAlv3ohq/0FoHO6bzrZ65AXKs8ig5Lh2dexrMapuvBex+XQlhHDIZGPlh227duj5aklA70siG2DhXcRAjWOTDNcjYf/BpSpmbpu0dMO84c6QRf/HjfyAn08W9D9hMz+FZ9jAiWCWQN7dkO9eyXMRrlElzro+aY+rbtglNC7Dew52JohwdqREmiBZgnFQdtW04e+yAzd6sV3IekFns448YrM4F8SQJ5mPkIt SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: janustech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jul 2018 22:18:36.3199 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a00ad46a-6b7b-4561-7249-08d5f1b367b1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 34eb020e-3cf3-43a1-afeb-f5cf1310628e X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR07MB2612 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.33.132 Subject: [Qemu-devel] [PATCH v4 2/4 for-3.0] qcow2: Options' documentation fixes X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Leonid Bloch , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Leonid Bloch --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt index 8a09a5cc5f..3673f2be0e 100644 --- a/docs/qcow2-cache.txt +++ b/docs/qcow2-cache.txt @@ -130,6 +130,9 @@ There are a few things that need to be taken into account: memory as possible to the L2 cache before increasing the refcount cache size. +- At most two of "l2-cache-size", "refcount-cache-size", and "cache-size" + can be set simultaneously. + Unlike L2 tables, refcount blocks are not used during normal I/O but only during allocations and internal snapshots. In most cases they are accessed sequentially (even during random guest I/O) so increasing the diff --git a/qemu-options.hx b/qemu-options.hx index b1bf0f485f..13ece21cb6 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -752,15 +752,17 @@ image file) @item cache-size The maximum total size of the L2 table and refcount block caches in bytes -(default: 1048576 bytes or 8 clusters, whichever is larger) @item l2-cache-size -The maximum size of the L2 table cache in bytes -(default: 4/5 of the total cache size) +The maximum size of the L2 table cache. +(default: if cache-size is not defined - 1048576 bytes or 8 clusters, whichever +is larger; otherwise, as large as possible or needed within the cache-size, +while permitting the requested or the minimal refcount cache size) @item refcount-cache-size The maximum size of the refcount block cache in bytes -(default: 1/5 of the total cache size) +(default: 4 times the cluster size, or any portion of the cache-size, if it is +specified and large enough, left over after allocating the full L2 cache) @item cache-clean-interval Clean unused entries in the L2 and refcount caches. The interval is in seconds.