From patchwork Mon Jul 23 20:17:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 948066 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="D+Xa2p7n"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41ZDxV3Ffbz9s3N for ; Tue, 24 Jul 2018 07:23:26 +1000 (AEST) Received: from localhost ([::1]:36740 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhiIe-0000mV-2j for incoming@patchwork.ozlabs.org; Mon, 23 Jul 2018 17:23:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fhhKz-0004AO-42 for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fhhKy-0005Vk-8V for qemu-devel@nongnu.org; Mon, 23 Jul 2018 16:21:45 -0400 Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:36040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fhhKy-0005VQ-2V; Mon, 23 Jul 2018 16:21:44 -0400 Received: by mail-oi0-x22c.google.com with SMTP id n21-v6so3501487oig.3; Mon, 23 Jul 2018 13:21:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8+VpBNagLMbQDxPV1taJiZlYPM1RVAX3Yfi4C69c1rI=; b=D+Xa2p7nMMop5XnNCmJo61G5BcBYtHZNnd9xjSU8KgOZLK3BGSmXIQGwPRly+PqCrP +hs6WAk/1GbWTRzJkKk7E0U6bz0gy/M6J/5H3Sw6LbmVx1A6YDYdaF/aLIxX0Y+vHLx8 fQstbXHNsr9kTea2SvBjwEFYcosKNfhmUXsgVn1DLGiknmfymY885AfeBRxICn/FBdC7 Zoh75O+eUpEetvXHa+iuhoHshteZz1FD0rq4KzooBoMph956WnivFee+pcCpD6zB+6Q0 arjzXrIMw3uCFV9OLdiAjh2snptc7ijzp5Ea5bER/ee8LoPiweKochc/PvWkc0dkEtGY /epw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8+VpBNagLMbQDxPV1taJiZlYPM1RVAX3Yfi4C69c1rI=; b=TFReOWXQJo0FO5BhpeR2ehiVjUFfXLSxdWYpJGnUWSwTNgbm+EazWvPRY9PrfrPiEy sPy4IRGxDYF3MYanyQ9teoTqpSvFsT+fM2TMgaVTVT+OyILu6o+o8o6iK7mfoLxgxgIP hQAwF/0z5VNF5Y5JWl36M7hK3q3h7CrQONrkNUjZy7m/HaVpKhZ5mi5YUQ9EIJLg7jhA KIIdvpXY0wuWB753UXvQEQ3Twy1GZEsFCIGGkTvk8w9PreSBXghTI6Y0BEeXmmkPzIC0 ERSHN9osr7xdwHHoqoOwbUQQv+gSrPH8m2H+Tyw29BXZ3pDwa1lIzRPxWKJgCaeClQBo L+PA== X-Gm-Message-State: AOUpUlFLxefl91xcf3DZb7ZwYX8jX4GEXLNbez7fVGNc96GwRfRsGaC+ Ycyy1V8ICwSo1dYkLMTlRRxo/viemEJK3g== X-Google-Smtp-Source: AAOMgpfXrkgAHNf/U42sxxI7N2NWY9kQ0YsO9MdGQQV77jfqCDO0Y8Hrn4nVJjv/Ysvu4nz5jjpbkg== X-Received: by 2002:aca:cd41:: with SMTP id d62-v6mr262099oig.207.1532377302953; Mon, 23 Jul 2018 13:21:42 -0700 (PDT) Received: from localhost (76-251-165-188.lightspeed.austtx.sbcglobal.net. [76.251.165.188]) by smtp.gmail.com with ESMTPSA id q63-v6sm1776773oia.54.2018.07.23.13.21.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Jul 2018 13:21:41 -0700 (PDT) From: Michael Roth To: qemu-devel@nongnu.org Date: Mon, 23 Jul 2018 15:17:34 -0500 Message-Id: <20180723201748.25573-86-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> References: <20180723201748.25573-1-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22c Subject: [Qemu-devel] [PATCH 85/99] target/arm: Fix sqrt_f16 exception raising X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-stable@nongnu.org, Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée We are meant to explicitly pass fpst, not cpu_env. Cc: qemu-stable@nongnu.org Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Tested-by: Alex Bennée Message-id: 20180512003217.9105-12-richard.henderson@linaro.org Signed-off-by: Peter Maydell (cherry picked from commit 905edee9101c54cda5b72286b7f7607cf1c3c4d1) Signed-off-by: Michael Roth --- target/arm/translate-a64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index f4587c3814..618f5268cc 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4733,7 +4733,8 @@ static void handle_fp_1src_half(DisasContext *s, int opcode, int rd, int rn) tcg_gen_xori_i32(tcg_res, tcg_op, 0x8000); break; case 0x3: /* FSQRT */ - gen_helper_sqrt_f16(tcg_res, tcg_op, cpu_env); + fpst = get_fpstatus_ptr(true); + gen_helper_sqrt_f16(tcg_res, tcg_op, fpst); break; case 0x8: /* FRINTN */ case 0x9: /* FRINTP */