Message ID | 20180718222755.9014-2-alistair.francis@wdc.com |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=wdc.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.b="Kv5Rj8pc"; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=sharedspace.onmicrosoft.com header.i=@sharedspace.onmicrosoft.com header.b="GFiUFeaQ"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41WBdX06sjz9s4r for <incoming@patchwork.ozlabs.org>; Thu, 19 Jul 2018 08:29:02 +1000 (AEST) Received: from localhost ([::1]:38489 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1ffuwM-0001mm-Ab for incoming@patchwork.ozlabs.org; Wed, 18 Jul 2018 18:28:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <prvs=730c0c5bd=Alistair.Francis@wdc.com>) id 1ffuvf-0001lz-Pr for qemu-devel@nongnu.org; Wed, 18 Jul 2018 18:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <prvs=730c0c5bd=Alistair.Francis@wdc.com>) id 1ffuvb-0002F7-AS for qemu-devel@nongnu.org; Wed, 18 Jul 2018 18:28:15 -0400 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:15044) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from <prvs=730c0c5bd=Alistair.Francis@wdc.com>) id 1ffuva-0002EN-VM for qemu-devel@nongnu.org; Wed, 18 Jul 2018 18:28:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1531952891; x=1563488891; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=tQ6wyA4KBFdQaFTRgJSx318HfuDynX1/ao6cUxz9TbE=; b=Kv5Rj8pcCyUxExvlCLrmXFxqrzLw/QBVqwoz8FTwSFDa61JX48Urr0IB NML+/t0L4I94bjgvWvd4xBVDGP76TgJzCokOkYm9WknnMexyc7AfZisiy cVGLKfIP2DyW13JI6/lNXdRpK4D+12CH+t3LXIKGQbo8hZUrh31zJm4nc GfOCaREqYCyN1IZc4EwTWdwTQtRWf9URhoMo5EI18sjgfiEENE5tv1Qfe DYq3iy/EOWMLQ+/EB3ShWecnOJlTqjMM7Zob7/rPKsVkO6kKgq1MWs7/E v5vCtcRp6x+tt7djVBp9Z0S85TkAxXRdRsnqWUH2mSc5zODCOZ2SQy5EE g==; X-IronPort-AV: E=Sophos;i="5.51,371,1526313600"; d="scan'208";a="85113746" Received: from mail-sn1nam01lp0113.outbound.protection.outlook.com (HELO NAM01-SN1-obe.outbound.protection.outlook.com) ([207.46.163.113]) by ob1.hgst.iphmx.com with ESMTP; 19 Jul 2018 06:28:07 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sharedspace.onmicrosoft.com; s=selector1-wdc-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxkuE1Wo0tsmH8fMoYw6EnJvjBhtD860D7zEoQi5Uis=; b=GFiUFeaQH0DiaPY2qrlfGKIvjBdHU5OyJwApOy/wAWf/nRfAfrPD2vJ5Yz3tZ9sNCEb3iIqMvqlhI7+l/8U0wMqEPX+yCfG++bWmhww97xt4H6k1rD77Ntc2MFuat4EF/dUzawdQ8rW17POa05/Omrn/YdVaCC8n8sYaB7M9c50= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alistair.Francis@wdc.com; Received: from risc6-mainframe.int.fusionio.com (199.255.44.250) by BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Wed, 18 Jul 2018 22:28:05 +0000 From: Alistair Francis <alistair.francis@wdc.com> To: qemu-devel@nongnu.org Date: Wed, 18 Jul 2018 15:27:51 -0700 Message-Id: <20180718222755.9014-2-alistair.francis@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180718222755.9014-1-alistair.francis@wdc.com> References: <20180718222755.9014-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [199.255.44.250] X-ClientProxiedBy: BYAPR04CA0012.namprd04.prod.outlook.com (2603:10b6:a03:40::25) To BN6PR04MB0389.namprd04.prod.outlook.com (2603:10b6:404:91::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6f3b84d-0692-4566-064d-08d5ecfdbbc4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:BN6PR04MB0389; X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 3:GC9EKbeaHc3wfNjLHOnQK6m3T4PniBQKz3RfS1I93LFVwEQVV8w9kmME5Di/964G2Rg7Nh9DgiO74zafomfs6wBqK6T5O23idyv0Z8B4hunDTMn01vGJaRyMnmutFJarv3SPpsvGKuSJSgCZaec97DYX6d1TBNhoZKVdefRESl3EYyaXX5gzlWzhtnc/5c/7P9fgF3pZJI+ogfJQ6z/0iEN8r++sA44Ho2nbU+Y6eTITXaeymRu3mH7abZzVr7wc; 25:sH85+dsy4qMSUA2DRl7H/sM1l8GGxMK3/O8ZJZ9f3wMyve3AIVWNBN0bqC1trR1N4nqyJc3t9F5Qvkk2zIi8pDXh+GccKZ3EtfXk6+5528MIExsDHXO0SIVoCeKW/cy50SDJgnLbBFzqeD3/TE9Royx4oUN4sORwsWV57FDx3dWEq7skmcXu6b4HgoHpkUpFql7CgxBCIS2BYLDThtGjTFICL4fgUWcLqeNaHFZMZ+lEBhiqX8XGJNfe2gYt2Tci/z91CuI/h5oDwja0+n9r0txn2xXIK/M7kCbfareAEWilsK/YMwcBv4gpJEJvDRimS2mT0EFdz6B1VJAHUCzBmA==; 31:bpZANHHY5vq9Sm4owZ68I437E0deC6fGPtj7ouTZOmgHeCJbhA7YrZzUU5PHSYCMckzcUjJVbwpY4VOqThnSzZDfqA5SPQyyLjcgHVUaGHJ2yUcbgXWK3eYYKrCYJp8kqNWyIZtLR2eu11LSR2TSYOPqFk3PoBMIWbJzKGs/tyjE7wqv/TDDZSiyTtmhI/k7ghJMB0SvGkDP7qKmMF1RJ4Dismh27eTJqtoaoHK+nq0= X-MS-TrafficTypeDiagnostic: BN6PR04MB0389: WDCIPOUTBOUND: EOP-TRUE X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 20:dVqtxR97/dXhAC/gape/VjYdopBWr2r0Ecjj60aYIGD/wSYwU/YqUfK9FPsyTH7uO/qVOxDTV3XAJCp6Viqy2EMW88T2sBRY1GoLJvVz6gAe3kyfnCBcZCmRXO6Ivw7eHHoNmq6QZ3Wb25jgeBZa/GxYp3zsfbldOffVOaDBUqCCEFXpZ9rS22s5mVn/7JPsAAMq+OJnIzuxQqQBDhRz1wuaYMn4ejYGsiDE+7MLqDiO8d2hyyME1TYsiMMFx0DPlDfaDX4IpXssUmWmG1/mueyyXQYVq5araU3/jPNWc5ibuNP6EUU11KINxZN3lmIAFgOnU7w1VmfJz+ZQZNyo+i6EUjOKuUTlypotzpz55VnCPWBBitkVJAQclxU30+oyV1bSWKSowev9JVBvUcSuX1bqlLJO0yg/skOLJR7/qm1wzJm7/vpX1fTtS3yFSasXbROsTi5iWhdd/PaYf+R0E7vwEHifO+D45PpnzRgtLrPk+39jE3aUXlHqSpxVbkft; 4:Z1Ipf47UNJBA8AUx+IK+OYhIPdqn29RmdibBUiHCHVxOqRkUplHA7DyFdAqJR1DIViwGt5XIng85n19VXjstKiLW+bQ2lKb3r27lufvOIQo0ubk5aXbrx7FcBQKrzWs3VoD4+0VbQYDB084EYxMao9ayg9IjdOjxk+R9ZFnm7ZS2Glx0ZSa4TdLbp7vjlHhFcwgJ4JMiISRKMqemF1TcDooHbx8q+4n9OwYPVEQ5iSTMJNgG50ClDlPTEkxdDxA6FxQRdzfBZyQClRMe6edePw== X-Microsoft-Antispam-PRVS: <BN6PR04MB038929A3BF2F59907A98C65990530@BN6PR04MB0389.namprd04.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(3231311)(944501410)(52105095)(3002001)(93006095)(93001095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:BN6PR04MB0389; BCL:0; PCL:0; RULEID:; SRVR:BN6PR04MB0389; X-Forefront-PRVS: 0737B96801 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(376002)(346002)(366004)(136003)(39860400002)(396003)(199004)(189003)(39060400002)(11346002)(956004)(97736004)(2616005)(50226002)(476003)(5660300001)(486006)(446003)(66066001)(36756003)(4326008)(316002)(44832011)(106356001)(47776003)(2361001)(6486002)(2351001)(3846002)(6116002)(1076002)(8676002)(68736007)(6512007)(53936002)(81156014)(105586002)(50466002)(25786009)(7736002)(305945005)(6666003)(8936002)(81166006)(52116002)(2870700001)(23676004)(76176011)(72206003)(86362001)(386003)(6506007)(2906002)(16526019)(26005)(186003)(6916009)(478600001); DIR:OUT; SFP:1102; SCL:1; SRVR:BN6PR04MB0389; H:risc6-mainframe.int.fusionio.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BBN6PR04MB0389=3B23=3A0TT1?= =?utf-8?q?bg2GQNkFQzOPXbnx8XbdR8fQ8va5WImadcox/ACLdNpcT5WJBYGxw0+c?= =?utf-8?q?CIugLVUqoLmaOq8ntWChbpBI1dmA9ktq0sXcvzi0bRpyyiOxvirnjB49?= =?utf-8?q?A/OWLtwr2BjiAGX62WvMMKrt+u562NQe+Yod1191pbPHDoS6A2Myq+20?= =?utf-8?q?/+U8VVw5IDC0PTJ/URxOI2hnZc69Q3tGOJE/N2I9af7lV5kYtSxW8p6l?= =?utf-8?q?8v3Ln3JoVMYmcpdhDH/ZbGJBZ9PsCnaswb2Lh7pFrTW5KsOG+FKQvipe?= =?utf-8?q?C092b7Mgtbb2lp/WPPD/j6vLnycY8BqkvNNck6thzNygVksDK7edVY1P?= =?utf-8?q?NAtPOb4byWJyKOY2cLES7JSxmy4oTF3NMMYJBBoZij2FT659qfvF3vQ0?= =?utf-8?q?2w/PZLexJMaj2DNmZutd1hajvkbmPWrhaf3FKqdYUWT/cI3tCG6F8vqu?= =?utf-8?q?MbW1SyvsrsWg5lp1F0UjW47pS1TJhhr9ayMtoG1PPOI93Nz93Qlxf9l6?= =?utf-8?q?btp9w/BYoraQTf22XIBuvxp9UU6zZiERjHPNK6kXqqXuJAWew0i4GMpZ?= =?utf-8?q?11TSxbtxXkqVwnatmv3+aX2SvJuIAbb60Yi071/eXa3tgXeORc4bsWQl?= =?utf-8?q?QEjBtGHPViwxJiEiQh4pHAy9JxwURisPZe+j2fo0DLLrHa8V1WQo+oFw?= =?utf-8?q?gmNlRbIUOGPZe5ASfjNRtnCMVEDAkGMJgLl6wZPpjTM2HdMKnNDfG5wt?= =?utf-8?q?D2xcv4sBDrb2Siedv62jPJ3sMp8QwPM04Ds5CDQlMjEflGFvxByxteBa?= =?utf-8?q?rhxnVFhfVLTPGWiy+YimRlaFdwWgbX5YIdS5XEha0XsEyP3ABn2gqdcX?= =?utf-8?q?Ji3DP4tMxRbUiod+Xjco1/t44jdfcDZgbm+0qSowPnQmWPtj0TLveDXJ?= =?utf-8?q?5w8wLi0o2RfCwsDvCZi4hbau5Pnp+NBr1xu9UnCsZUjCn6SkMVZ+tlFg?= =?utf-8?q?ANFiNVyLroF36csXlmR0wDPu+KfKbgCpbhGi3YjuqND2zjV6N0xV+Rao?= =?utf-8?q?zSuu3LIZvF6H1GgInyOsaMwK4VWwOVyPiLsoJnHlk6cHbhleb80RzG65?= =?utf-8?q?/5dd1aGjB6OrSWzaYiaE0vijpKCdV3VqplBnD06WbSCR3XAiYKHPuL4a?= =?utf-8?q?XDlfmj4YiikoZiSasdRdGjPJuu+vhOl7UUd+0Yk5WggjkIH+89d2yn85?= =?utf-8?q?zVcKKdx9+VfYiVwir15yFmB4G7IMWoLG94QAP3u/l8xNziMzfHliK41A?= =?utf-8?q?VAqI0ueZHsLTsSMFbHd6gc3LI0C3u1dhQVMp33oRLrrI?= X-Microsoft-Antispam-Message-Info: 17sbvqMCYd0DPlybvj0jqDICGyyMKBcAVuhnclQK4t/P5aoUKFcd8xo53cigXm7cZwD8QLl1VK5XMCLUBSfUG/hlA/kC5iVg+QVx3fWjyKd6QkEoajgSlVPh1MAuMF5ZpXGxwt52vVN5bgG1ZGX4uiVkd7uW9FGjB+TEwDzg9pG55Xj+r3oxocjDXddTNDsAYRqYpa18Uzksmbrif+CUFqFuJwQY2IfP78u7pIzdReGLvJByr2ngG8KoucmSe5OaRaTXViVkwERmnV1Gje1yy8sziMbbwdk4JjuZwLhR2WIRK3+HI3ESvLazTVikoapoQE9VLqPM8OdN1BE/Xz7ytjYbyTD31VM0BtVpjz2WVQw= X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 6:S4T2F/FgVD6D459X8zoJnIc3+VbRxcNLaIxycyuFz8MKOdkOpFHmZVWIcmyrp5iQ5E9stmgJUabmF4IY89SIcTfltLvXYUwLYqtEl2a+K4sbSNll1qLeCi1DZ6Cvqv1+41yfAlvia0j2aXCTqg/jEyfmf6dIrnz0d6oOKRhWcyhYSiYm1uAdev3oQvNf4yai75NsYq+s7DRqNljWe0fp6iuob/evYvQlSVhLh9g5TeJ9yOOD2z8TO9EiTFrU9ev97v2OpID0i1E9HZcMpog/WfQ5lsZk2qWP2/U39UuU6bsCwB5GxZm9Kk8zvbl0zbfxZ6GuIuu3NPUz72y0rroQnIjJaZrZ5zZWS7UI2DqDZ0a5nlzui6pr9hWZONsyABjzzoJSYr1iMtvT+pTUE1B0ugKQ3LO3JgB+BULzF1BB0LhKIWeKQ9pXvXJuB2C970CwmT2ZvEQAe/JjyqkU8M+cGw==; 5:Mo0/+zTCfceIdzzf56LxLCaIIxyTfgcmzNoniLgDSsuI3Hw+SRbkmwloP/f6bJGJclU+JSU3JV/00DBYReIUeZw+Rr7RBWm8060shBeSkJGBBpUky59eN5ziUYH7qVIH5GvDeBoyuu4htCCCELAarLYhkwuzdkxM5473Q3N6noA=; 7:Kpn8TGGZJhpf5bQryK6fALDhJAaCwrfmtJR5CcohwfK1HUFw1wAt7xuiBF8kanqNdAfTQ4Mdbw/NcW//hqpCRmposQ7PxOSl/jShBBGJRezQ/Dxz/F/bGkuTwn6xKdHbcw8g1n26jyCTYi6ktfL/j+OUCH3sc9tjUQb8jzUOBvwCTtKAn4brL/hw4nfC7FwwCoOLWezDEnIXGWLAa+HlZgPIoDAIybLVXiVJSA2RyytQI3IX6cqxBeS1k2m6OamN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR04MB0389; 20:m4UizJdEJt3PcPCijqC15gJj0UEodPE1huyAVHEkpfy/aXjhajPG7D/CmbArC8LCRmuDvm0C8BStHbUX8ePUFg9/2BVLg9qz2HcSR2+KiOf4kabGQNjnR+UU8bABbkWzxl9980lAVRVn3lKgEzqTlVR5p4v0QgQPM8rsMy+ITHE= X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2018 22:28:05.9856 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6f3b84d-0692-4566-064d-08d5ecfdbbc4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB0389 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.71.153.144 Subject: [Qemu-devel] [PULL 1/5] sifive_e: Fix crash when introspecting the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: peter.maydell@linaro.org, Alistair Francis <alistair.francis@wdc.com>, alistair23@gmail.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
[PULL,1/5] sifive_e: Fix crash when introspecting the device
|
expand
|
diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c index 8a8dbe1c00..4577d72037 100644 --- a/hw/riscv/sifive_e.c +++ b/hw/riscv/sifive_e.c @@ -105,9 +105,9 @@ static void riscv_sifive_e_init(MachineState *machine) int i; /* Initialize SoC */ - object_initialize(&s->soc, sizeof(s->soc), TYPE_RISCV_E_SOC); - object_property_add_child(OBJECT(machine), "soc", OBJECT(&s->soc), - &error_abort); + object_initialize_child(OBJECT(machine), "soc", &s->soc, + sizeof(s->soc), TYPE_RISCV_E_SOC, + &error_abort, NULL); object_property_set_bool(OBJECT(&s->soc), true, "realized", &error_abort); @@ -139,9 +139,9 @@ static void riscv_sifive_e_soc_init(Object *obj) { SiFiveESoCState *s = RISCV_E_SOC(obj); - object_initialize(&s->cpus, sizeof(s->cpus), TYPE_RISCV_HART_ARRAY); - object_property_add_child(obj, "cpus", OBJECT(&s->cpus), - &error_abort); + object_initialize_child(obj, "cpus", &s->cpus, + sizeof(s->cpus), TYPE_RISCV_HART_ARRAY, + &error_abort, NULL); object_property_set_str(OBJECT(&s->cpus), SIFIVE_E_CPU, "cpu-type", &error_abort); object_property_set_int(OBJECT(&s->cpus), smp_cpus, "num-harts",