diff mbox series

[06/32] tests/qmp-test: Test in-band command doesn't overtake

Message ID 20180702162218.13678-7-armbru@redhat.com
State New
Headers show
Series qmp: Fixes and cleanups around OOB commands | expand

Commit Message

Markus Armbruster July 2, 2018, 4:21 p.m. UTC 
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 tests/qmp-test.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Eric Blake July 2, 2018, 9:09 p.m. UTC | #1 
On 07/02/2018 11:21 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>   tests/qmp-test.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/tests/qmp-test.c b/tests/qmp-test.c
> index b4e54e8970..3932901146 100644
> --- a/tests/qmp-test.c
> +++ b/tests/qmp-test.c
> @@ -236,10 +236,12 @@ static void test_qmp_oob(void)
>       /* OOB command overtakes slow in-band command */
>       setup_blocking_cmd();
>       send_cmd_that_blocks(qts, "ib-blocks-1");
> +    qtest_async_qmp(qts, "{ 'execute': 'query-name', 'id': 'ib-quick-1' }");
>       send_oob_cmd(qts, "oob-1");
>       recv_cmd_id(qts, "oob-1");
>       unblock_blocked_cmd();
>       recv_cmd_id(qts, "ib-blocks-1");
> +    recv_cmd_id(qts, "ib-quick-1");
>       cleanup_blocking_cmd();

Nice improvement.

Reviewed-by: Eric Blake <eblake@redhat.com>
diff mbox series

Patch

diff --git a/tests/qmp-test.c b/tests/qmp-test.c
index b4e54e8970..3932901146 100644
--- a/tests/qmp-test.c
+++ b/tests/qmp-test.c
@@ -236,10 +236,12 @@  static void test_qmp_oob(void)
     /* OOB command overtakes slow in-band command */
     setup_blocking_cmd();
     send_cmd_that_blocks(qts, "ib-blocks-1");
+    qtest_async_qmp(qts, "{ 'execute': 'query-name', 'id': 'ib-quick-1' }");
     send_oob_cmd(qts, "oob-1");
     recv_cmd_id(qts, "oob-1");
     unblock_blocked_cmd();
     recv_cmd_id(qts, "ib-blocks-1");
+    recv_cmd_id(qts, "ib-quick-1");
     cleanup_blocking_cmd();
 
     qtest_quit(qts);