From patchwork Fri Jun 22 13:40:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 933394 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EEXDmLEP"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41C0cV21twz9s1B for ; Sat, 23 Jun 2018 00:02:02 +1000 (AEST) Received: from localhost ([::1]:34188 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMdT-0006Jt-RK for incoming@patchwork.ozlabs.org; Fri, 22 Jun 2018 10:01:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59709) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMJH-00067c-25 for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWMJE-0003OE-D1 for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:07 -0400 Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:40631) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWMJE-0003NV-7K; Fri, 22 Jun 2018 09:41:04 -0400 Received: by mail-qk0-x232.google.com with SMTP id b129-v6so3660966qke.7; Fri, 22 Jun 2018 06:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9sCP0/1z6bl6hGhJNNvahAaExTnmCvOayGAPqQXr47Y=; b=EEXDmLEPV6PIQuLJih3jmkeWYzOKMjAe2YEiJipUxwFsGVtHbKjjL9KFytIDmarVEH S2UzGp9TfZdSLOU8oox8Ne0B8DbyF/GIaRsTr4VTi45VYJJ6NavqaBMysg6e20aURf3g Ehy4RWG3i5g9+HAiBKi0DYPhu44amB8rAB4bEWZWlmf5OxquMA7H67P5wekkO0uItcBj Vful46VbtxoTwXxZdzf7UE3I69y0H5CoJB/fgnZVQwyzAtiz3tlH1h+99/6lOrYVwovM fFuwpJPcTLDFy7DO1/V42eoI+XsELiDkCWry2Vh0GrYEd++kAXzF8Y+hm/+pvklIU4uw KkZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=9sCP0/1z6bl6hGhJNNvahAaExTnmCvOayGAPqQXr47Y=; b=PjQpygvXBkrUsdwE9Qsdy5ogGu77gtDiTouX5KcklGlQWZfvwpyUbdGizgN2tyFPK9 jiMI27jDZwdTESjObEp6xxKeJPjbHU+pPuz6di8q/9muZItQRTVS3mBiqf0+RhJMRi2k N4prBRaTi20Z2Jx8t6D2V4FXREdcioHxmZhV1GCHjGgE0oj6wiIASGIN8DKYivjpgXaL VAd3z+/rlOCD/VQcBL5YBNq5p0d+V31QssyAZ4hAB2NeWt5Mlu1xhdSLzLgZr8qSXX/9 W6cE3M/DsmGHLOKHN2LZgP7g6UdFSRbL7eZpTcPRTqk/UeZsvZLSnkhmpL6OzvIuQihf dERg== X-Gm-Message-State: APt69E1SDWPBQLCUQCVj1M5JTxpiNbC/KvZ3kep61pvTLv4GLJidTuOe qSRPK8PNDkBpMdSHwRnscUU= X-Google-Smtp-Source: ADUXVKI4Xwf1Q57XdGU4vSSGUfJMUjSL8sx1qbNk4ujUEx/IrgBStPD0AB2DDro+42mOGut507qcVA== X-Received: by 2002:a37:2dc7:: with SMTP id t190-v6mr1258043qkh.229.1529674863464; Fri, 22 Jun 2018 06:41:03 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id s39-v6sm6006629qts.42.2018.06.22.06.41.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jun 2018 06:41:02 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Fri, 22 Jun 2018 10:40:29 -0300 Message-Id: <20180622134036.23182-8-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0.rc2 In-Reply-To: <20180622134036.23182-1-f4bug@amsat.org> References: <20180622134036.23182-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::232 Subject: [Qemu-devel] [PATCH v2 07/14] hw/i2c/omap_i2c: Use qemu_log_mask(UNIMP) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathi?= =?utf-8?b?ZXUtRGF1ZMOp?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/i2c/omap_i2c.c | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c index 26e3e5ebf6..690876e43e 100644 --- a/hw/i2c/omap_i2c.c +++ b/hw/i2c/omap_i2c.c @@ -17,6 +17,7 @@ * with this program; if not, see . */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/i2c/i2c.h" #include "hw/arm/omap.h" @@ -339,14 +340,15 @@ static void omap_i2c_write(void *opaque, hwaddr addr, } break; } - if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */ - fprintf(stderr, "%s: I^2C slave mode not supported\n", - __func__); + if ((value & (1 << 15)) && !(value & (1 << 10))) { /* MST */ + qemu_log_mask(LOG_UNIMP, "%s: I^2C slave mode not supported\n", + __func__); break; } - if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */ - fprintf(stderr, "%s: 10-bit addressing mode not supported\n", - __func__); + if ((value & (1 << 15)) && value & (1 << 8)) { /* XA */ + qemu_log_mask(LOG_UNIMP, + "%s: 10-bit addressing mode not supported\n", + __func__); break; } if ((value & (1 << 15)) && value & (1 << 0)) { /* STT */ @@ -392,8 +394,10 @@ static void omap_i2c_write(void *opaque, hwaddr addr, s->stat |= 0x3f; omap_i2c_interrupts_update(s); } - if (value & (1 << 15)) /* ST_EN */ - fprintf(stderr, "%s: System Test not supported\n", __func__); + if (value & (1 << 15)) { /* ST_EN */ + qemu_log_mask(LOG_UNIMP, + "%s: System Test not supported\n", __func__); + } break; default: