From patchwork Fri Jun 22 13:40:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 933392 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="aDSkZroW"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41C0Xk6KVkz9s1B for ; Fri, 22 Jun 2018 23:58:46 +1000 (AEST) Received: from localhost ([::1]:34153 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMaK-0003MM-ED for incoming@patchwork.ozlabs.org; Fri, 22 Jun 2018 09:58:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMJA-00060K-1a for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWMJ8-0003Bx-UG for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:00 -0400 Received: from mail-qt0-x243.google.com ([2607:f8b0:400d:c0d::243]:47057) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWMJ8-0003AW-QE; Fri, 22 Jun 2018 09:40:58 -0400 Received: by mail-qt0-x243.google.com with SMTP id h5-v6so5888896qtm.13; Fri, 22 Jun 2018 06:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0mutGa0sDmrzFg5daZsr8Rt8Y88n2i/QbM/UUL4yJrc=; b=aDSkZroWWSODVCXrLp7bVTWLYCuA+caAGKpgSKO/3tWUBDbgPkIK2gLDIU72FjbyK4 rP1IxC6p0a/nkqvV96tIJCu0L21jK6MPuECfMe7/eo2iuT7zoTSShSZWT40JCnCuDCRN UqoUUrM3WNH4JCV7f6JyCKsu1vBfKi6H2hktmW8ord4KF33Z2nGGvy3bVeIFaybMGfPQ DrSACd1eQeHu0O+5GoFQeRdtaSJHBSDCHeu8pqTlWaFyZwGYJg5e++yUaNPQOTF3sQXO 8+LGgwsQy/1O2fls/CukZRTClmAmC2Ii5Y4heJcilBkY6Dt6ydUHgdRZeiXAWFKT5w5S 1T1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=0mutGa0sDmrzFg5daZsr8Rt8Y88n2i/QbM/UUL4yJrc=; b=hwh8Kdu43BfFQfDybZbywI5XDtEhZH6WWcJsrqtwdrwNS/D+nN6yjq/bsYh92YaRxB WZezwyG9mNh6LwjxgTKmT0FONF9iar1/6SjUK//pCEj93WdUFSwUEBmJhTO9kleZHdHY LnHiZA57S55R0J8iAh/kAaFJlZGGCRMozrarCPX9qauQ/buYRZ79y3PlZp/XutRUAYWt oPQU4E56T6/PByU8dpST4QMlhnvq7agGA+Ps9AUml+VjThuidX2lYoW+sduOJq770yzG bEgR71Y2H1P4HA0pqWzGsTEq3sDeC86IWFBeSHbyeA8ryN4tPoOs4XiYsWtqSmKCS8EU yxWw== X-Gm-Message-State: APt69E0YY3fxWGPGsDL0HOT+iWh8CD5mgZad4cJM7I3rDgkr91ABGjoj wVBGhg1cn4iyjJhliwG3VsQ= X-Google-Smtp-Source: AAOMgpfJxuritr8ixVtsc7QKjgPuKnflKTzsJnVLjd986S1ffUNfD/V1yY9lCmIBrHF1wsYX+mE31w== X-Received: by 2002:a0c:f54d:: with SMTP id p13-v6mr1404371qvm.149.1529674858134; Fri, 22 Jun 2018 06:40:58 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id s39-v6sm6006629qts.42.2018.06.22.06.40.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jun 2018 06:40:57 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Fri, 22 Jun 2018 10:40:27 -0300 Message-Id: <20180622134036.23182-6-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0.rc2 In-Reply-To: <20180622134036.23182-1-f4bug@amsat.org> References: <20180622134036.23182-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::243 Subject: [Qemu-devel] [PATCH v2 05/14] hw/ssi/omap_spi: Use qemu_log_mask(GUEST_ERROR) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Crosthwaite , qemu-trivial@nongnu.org, Alistair Francis , =?utf-8?q?Philippe_Mathieu?= =?utf-8?q?-Daud=C3=A9?= , qemu-devel@nongnu.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/ssi/omap_spi.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/ssi/omap_spi.c b/hw/ssi/omap_spi.c index 34163e5646..f278a55160 100644 --- a/hw/ssi/omap_spi.c +++ b/hw/ssi/omap_spi.c @@ -20,6 +20,7 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/arm/omap.h" @@ -294,11 +295,15 @@ static void omap_mcspi_write(void *opaque, hwaddr addr, case 0x2c: /* MCSPI_CHCONF */ if ((value ^ s->ch[ch].config) & (3 << 14)) /* DMAR | DMAW */ omap_mcspi_dmarequest_update(s->ch + ch); - if (((value >> 12) & 3) == 3) /* TRM */ - fprintf(stderr, "%s: invalid TRM value (3)\n", __func__); - if (((value >> 7) & 0x1f) < 3) /* WL */ - fprintf(stderr, "%s: invalid WL value (%" PRIx64 ")\n", - __func__, (value >> 7) & 0x1f); + if (((value >> 12) & 3) == 3) { /* TRM */ + qemu_log_mask(LOG_GUEST_ERROR, "%s: invalid TRM value (3)\n", + __func__); + } + if (((value >> 7) & 0x1f) < 3) { /* WL */ + qemu_log_mask(LOG_GUEST_ERROR, + "%s: invalid WL value (%" PRIx64 ")\n", + __func__, (value >> 7) & 0x1f); + } s->ch[ch].config = value & 0x7fffff; break;