From patchwork Fri Jun 22 13:40:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 933382 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B4n3h7kL"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41C0L50YHPz9s1B for ; Fri, 22 Jun 2018 23:49:33 +1000 (AEST) Received: from localhost ([::1]:34078 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMRO-00040u-Jp for incoming@patchwork.ozlabs.org; Fri, 22 Jun 2018 09:49:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fWMJV-0006Mf-4w for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fWMJU-0003j2-Cu for qemu-devel@nongnu.org; Fri, 22 Jun 2018 09:41:21 -0400 Received: from mail-qt0-x236.google.com ([2607:f8b0:400d:c0d::236]:34695) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fWMJU-0003ib-8r; Fri, 22 Jun 2018 09:41:20 -0400 Received: by mail-qt0-x236.google.com with SMTP id d3-v6so5938063qto.1; Fri, 22 Jun 2018 06:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2Rc5TAl46HafWUsGlR1lgCO1U+OFpadWowwoZjTJ3L0=; b=B4n3h7kLsaaPHmNHddM/x3CK6hEnb4viQPRXplCplFte+rQcGdPvAqAlAopbzmY1eN XPgsNw9ay+bNkBrFYh7ip3lumyMMdWXdiwsxwBmcwzs4bjgGedUVz/IKTx38NG413gEo bnc4qImTJ6cUGNLGNol+tW8knc6nnskPNuvxjXOgUIzGNIgHskDJq/nX3IEVru99VqVH +hx0GA+RRZn/lwlvDl7MiF/I+y0MrozsHG/hoNP91LRrhJ9B6nEZ2OyEcNrvv6OfL9ah OWiMYHLRiDJsYDKnPIkHelSCx37mQkXlO/KWiFQKCEiMkWNUmxXJtHPrf4PWz0hN9/G/ zOvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2Rc5TAl46HafWUsGlR1lgCO1U+OFpadWowwoZjTJ3L0=; b=kyIeU2pTZnlq8FJrwUzdTuA3R/pf9M2CK4UtOc7O1+AR0c0tP14n9gzW6b49j5OCtR sjF2HKkRhEMky4EySR/flMapKtnvTd8Vga6HxwZp/VII66lsZCWWUXdrX8cEp84sZNDz E8GU8g8OZ5zszaQdnvEMgYVVVrAbL5Rer/h4vTzphDHhV56ZDYcSuMG/J8crufkW5hEM p+/wpaHxcmOaJkDWBdB/IuZbdcYzlvecEJ/d/y+yo1wM3l8UMofCDyq1NPbeaTANjkOs qLl+8PFrXIr6XB7TUDt+WVfxyxVdwe9vHFpC/osy3Wuvs/aoFgbBIO4mYRbU4okIrLq0 InDQ== X-Gm-Message-State: APt69E3uET2D55oSNdnLE7IWw8/+1e5+Xnp8wZuv0giCwpi8Wr9md+NT bgWi4EUZz4+RBc24ihkm0FE= X-Google-Smtp-Source: ADUXVKJSD3Z8XFCWddskcpSU9++PJjZw1I9Xm9aO3Ox1u6rmQ+8/swiAn1AT/2IpCpOBrsm0hr9YSQ== X-Received: by 2002:ac8:1285:: with SMTP id y5-v6mr1395122qti.164.1529674879570; Fri, 22 Jun 2018 06:41:19 -0700 (PDT) Received: from x1.local ([138.117.48.222]) by smtp.gmail.com with ESMTPSA id s39-v6sm6006629qts.42.2018.06.22.06.41.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jun 2018 06:41:18 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Thomas Huth Date: Fri, 22 Jun 2018 10:40:35 -0300 Message-Id: <20180622134036.23182-14-f4bug@amsat.org> X-Mailer: git-send-email 2.18.0.rc2 In-Reply-To: <20180622134036.23182-1-f4bug@amsat.org> References: <20180622134036.23182-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::236 Subject: [Qemu-devel] [PATCH v2 13/14] hw/net/smc91c111: Use qemu_log_mask(UNIMP) instead of fprintf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Jason Wang , qemu-arm@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- hw/net/smc91c111.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/net/smc91c111.c b/hw/net/smc91c111.c index 9094c0b47c..d2fd2040e8 100644 --- a/hw/net/smc91c111.c +++ b/hw/net/smc91c111.c @@ -362,10 +362,14 @@ static void smc91c111_writeb(void *opaque, hwaddr offset, SET_HIGH(gpr, value); return; case 12: /* Control */ - if (value & 1) - fprintf(stderr, "smc91c111:EEPROM store not implemented\n"); - if (value & 2) - fprintf(stderr, "smc91c111:EEPROM reload not implemented\n"); + if (value & 1) { + qemu_log_mask(LOG_UNIMP, + "smc91c111: EEPROM store not implemented\n"); + } + if (value & 2) { + qemu_log_mask(LOG_UNIMP, + "smc91c111: EEPROM reload not implemented\n"); + } value &= ~3; SET_LOW(ctr, value); return;