Message ID | 20180621180224.8312-4-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | hw/arm: use qemu_log_mask instead of fprintf | expand |
On 21.06.2018 20:02, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/dma/omap_dma.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c > index abd18c67ea..ab3a1b0451 100644 > --- a/hw/dma/omap_dma.c > +++ b/hw/dma/omap_dma.c > @@ -18,6 +18,7 @@ > * with this program; if not, see <http://www.gnu.org/licenses/>. > */ > #include "qemu/osdep.h" > +#include "qemu/log.h" > #include "qemu-common.h" > #include "qemu/timer.h" > #include "hw/arm/omap.h" > @@ -1439,8 +1440,9 @@ static int omap_dma_sys_read(struct omap_dma_s *s, int offset, > case 0x480: /* DMA_PCh0_SR */ > case 0x482: /* DMA_PCh1_SR */ > case 0x4c0: /* DMA_PChD_SR_0 */ > - printf("%s: Physical Channel Status Registers not implemented.\n", > - __func__); > + qemu_log_mask(LOG_UNIMP, > + "%s: Physical Channel Status Registers not implemented\n", > + __func__); > *ret = 0xff; > break; Reviewed-by: Thomas Huth <thuth@redhat.com>
diff --git a/hw/dma/omap_dma.c b/hw/dma/omap_dma.c index abd18c67ea..ab3a1b0451 100644 --- a/hw/dma/omap_dma.c +++ b/hw/dma/omap_dma.c @@ -18,6 +18,7 @@ * with this program; if not, see <http://www.gnu.org/licenses/>. */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "qemu-common.h" #include "qemu/timer.h" #include "hw/arm/omap.h" @@ -1439,8 +1440,9 @@ static int omap_dma_sys_read(struct omap_dma_s *s, int offset, case 0x480: /* DMA_PCh0_SR */ case 0x482: /* DMA_PCh1_SR */ case 0x4c0: /* DMA_PChD_SR_0 */ - printf("%s: Physical Channel Status Registers not implemented.\n", - __func__); + qemu_log_mask(LOG_UNIMP, + "%s: Physical Channel Status Registers not implemented\n", + __func__); *ret = 0xff; break;
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/dma/omap_dma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)