From patchwork Thu Jun 14 08:06:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Chen Hanxiao X-Patchwork-Id: 929288 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=126.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=126.com header.i=@126.com header.b="oSkWZk9U"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 415x6k4Gd9z9s1B for ; Thu, 14 Jun 2018 18:07:10 +1000 (AEST) Received: from localhost ([::1]:39116 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTNHg-0003Mz-6a for incoming@patchwork.ozlabs.org; Thu, 14 Jun 2018 04:07:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTNH7-0003Mb-Ra for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:06:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fTNH5-0001Ji-C8 for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:06:33 -0400 Received: from m15-111.126.com ([220.181.15.111]:38878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fTNH4-0001HE-Jp for qemu-devel@nongnu.org; Thu, 14 Jun 2018 04:06:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=r28Rs kfdRHzNj6yJkLKX2IYTuOc0G/uY60V5WutpQQ4=; b=oSkWZk9UuZSBedPzAgG9K G0DmNLbQ1zGn+eYxAbRqCyT7xA6VxmpeEKk6Krwz/nIe/TCN28Ype95eB/RogJki +6wDrABy7Nfs4Z2Ut5NI9B/kuVZuXctJR08VBMWyeNeG4gpNyYONqYMuv9mF7O+x cAzVwgJymLFUXk6msgOrNk= Received: from localhost.localdomain (unknown [58.213.111.46]) by smtp1 (Coremail) with SMTP id C8mowADnUSD0ISJbV4SIAQ--.22123S3; Thu, 14 Jun 2018 16:06:23 +0800 (CST) From: Chen Hanxiao To: qemu-devel@nongnu.org Date: Thu, 14 Jun 2018 16:06:06 +0800 Message-Id: <20180614080607.16604-2-chen_han_xiao@126.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180614080607.16604-1-chen_han_xiao@126.com> References: <20180614080607.16604-1-chen_han_xiao@126.com> MIME-Version: 1.0 X-CM-TRANSID: C8mowADnUSD0ISJbV4SIAQ--.22123S3 X-Coremail-Antispam: 1Uf129KBjvJXoWxWF18Gw4fCw15Cw13ur43GFg_yoW5WrW7pF 45A3WrKrW8JFn7JrsxC3W2vryFqanayryUW3y2q34YvFyDKrWS9wnI9a4v93sxu39YkF4F v3y8tw129w47ArUanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jxiSdUUUUU= X-Originating-IP: [58.213.111.46] X-CM-SenderInfo: xfkh0spkdqs5xldrqiyswou0bp/1tbiaB9lrlpD54JB5wAAsm X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 220.181.15.111 Subject: [Qemu-devel] [PATCH v5.2 1/2] qga: add mountpoint usage info to GuestFilesystemInfo X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Chen Hanxiao Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Chen Hanxiao This patch adds support for getting the usage of mounted filesystem. The usage of fs stored as used_bytes and total_bytes. It's very useful when we try to monitor guest's filesystem. Cc: Michael Roth Cc: Daniel P. Berrangé Reviewed-by: Eric Blake Signed-off-by: Chen Hanxiao --- v2: add description in qapi-schema and version numbers v3: use float for usage to get more precision. v4: make usage a best-effort query and mark it as optional. v5: report used-bytes and total-bytes in usage v5.1: unpack usage as used-bytes and total-bytes v5.2: remove useless assigments and fix doc qga/commands-posix.c | 15 +++++++++++++++ qga/qapi-schema.json | 3 +++ 2 files changed, 18 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index eae817191b..e0e7993bcf 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -46,6 +46,7 @@ extern char **environ; #include #include #include +#include #ifdef FIFREEZE #define CONFIG_FSFREEZE @@ -1072,6 +1073,8 @@ static GuestFilesystemInfo *build_guest_fsinfo(struct FsMount *mount, Error **errp) { GuestFilesystemInfo *fs = g_malloc0(sizeof(*fs)); + struct statvfs buf; + unsigned long used, nonroot_total, fr_size; char *devpath = g_strdup_printf("/sys/dev/block/%u:%u", mount->devmajor, mount->devminor); @@ -1079,7 +1082,19 @@ static GuestFilesystemInfo *build_guest_fsinfo(struct FsMount *mount, fs->type = g_strdup(mount->devtype); build_guest_fsinfo_for_device(devpath, fs, errp); + if (statvfs(fs->mountpoint, &buf) == 0) { + fr_size = buf.f_frsize; + used = buf.f_blocks - buf.f_bfree; + nonroot_total = used + buf.f_bavail; + fs->used_bytes = used * fr_size; + fs->total_bytes = nonroot_total * fr_size; + + fs->has_total_bytes = true; + fs->has_used_bytes = true; + } + g_free(devpath); + return fs; } diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json index 17884c7c70..b1bbb78c59 100644 --- a/qga/qapi-schema.json +++ b/qga/qapi-schema.json @@ -846,6 +846,8 @@ # @name: disk name # @mountpoint: mount point path # @type: file system type string +# @used-bytes: file system used bytes (since 3.0) +# @total-bytes: non-root file system total bytes (since 3.0) # @disk: an array of disk hardware information that the volume lies on, # which may be empty if the disk type is not supported # @@ -853,6 +855,7 @@ ## { 'struct': 'GuestFilesystemInfo', 'data': {'name': 'str', 'mountpoint': 'str', 'type': 'str', + '*used-bytes': 'uint64', '*total-bytes': 'uint64', 'disk': ['GuestDiskAddress']} } ##