| Message ID | 20180611121655.19616-3-david@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | pc-dimm: next bunch of cleanups | expand |
On Mon, Jun 11, 2018 at 02:16:46PM +0200, David Hildenbrand wrote: > Our parent class (PC_DIMM) provides exactly the same function. > > Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: David Gibson <david@gibson.dropbear.id.au> > --- > hw/mem/nvdimm.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c > index 4087aca25e..f974accbdd 100644 > --- a/hw/mem/nvdimm.c > +++ b/hw/mem/nvdimm.c > @@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdimm, const void *buf, > memory_region_set_dirty(mr, backend_offset, size); > } > > -static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm) > -{ > - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); > -} > - > static void nvdimm_class_init(ObjectClass *oc, void *data) > { > PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc); > @@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *data) > > ddc->realize = nvdimm_realize; > ddc->get_memory_region = nvdimm_get_memory_region; > - ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region; > > nvc->read_label_data = nvdimm_read_label_data; > nvc->write_label_data = nvdimm_write_label_data;
On Mon, 11 Jun 2018 14:16:46 +0200 David Hildenbrand <david@redhat.com> wrote: > Our parent class (PC_DIMM) provides exactly the same function. > > Signed-off-by: David Hildenbrand <david@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/mem/nvdimm.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c > index 4087aca25e..f974accbdd 100644 > --- a/hw/mem/nvdimm.c > +++ b/hw/mem/nvdimm.c > @@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdimm, const void *buf, > memory_region_set_dirty(mr, backend_offset, size); > } > > -static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm) > -{ > - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); > -} > - > static void nvdimm_class_init(ObjectClass *oc, void *data) > { > PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc); > @@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *data) > > ddc->realize = nvdimm_realize; > ddc->get_memory_region = nvdimm_get_memory_region; > - ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region; > > nvc->read_label_data = nvdimm_read_label_data; > nvc->write_label_data = nvdimm_write_label_data;
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index 4087aca25e..f974accbdd 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -166,11 +166,6 @@ static void nvdimm_write_label_data(NVDIMMDevice *nvdimm, const void *buf, memory_region_set_dirty(mr, backend_offset, size); } -static MemoryRegion *nvdimm_get_vmstate_memory_region(PCDIMMDevice *dimm) -{ - return host_memory_backend_get_memory(dimm->hostmem, &error_abort); -} - static void nvdimm_class_init(ObjectClass *oc, void *data) { PCDIMMDeviceClass *ddc = PC_DIMM_CLASS(oc); @@ -178,7 +173,6 @@ static void nvdimm_class_init(ObjectClass *oc, void *data) ddc->realize = nvdimm_realize; ddc->get_memory_region = nvdimm_get_memory_region; - ddc->get_vmstate_memory_region = nvdimm_get_vmstate_memory_region; nvc->read_label_data = nvdimm_read_label_data; nvc->write_label_data = nvdimm_write_label_data;
Our parent class (PC_DIMM) provides exactly the same function. Signed-off-by: David Hildenbrand <david@redhat.com> --- hw/mem/nvdimm.c | 6 ------ 1 file changed, 6 deletions(-)