| Message ID | 20180608143752.22718-1-yuval.shaia@oracle.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/pvrdma: Bugfix - provide the correct attr_mask to query_qp | expand |
On 06/08/2018 05:37 PM, Yuval Shaia wrote: > Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error > where backend query_qp fails to retrieve the needed QP attributes. > Fix it by providing the attr_mask we got from driver. > > Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> > --- > hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c > index 9d9dfc6b81..76df60a540 100644 > --- a/hw/rdma/vmw/pvrdma_cmd.c > +++ b/hw/rdma/vmw/pvrdma_cmd.c > @@ -524,6 +524,7 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, > struct ibv_qp_init_attr init_attr; > > pr_dbg("qp_handle=%d\n", cmd->qp_handle); > + pr_dbg("attr_mask=0x%x\n", cmd->attr_mask); > > memset(rsp, 0, sizeof(*rsp)); > rsp->hdr.response = cmd->hdr.response; > @@ -531,8 +532,8 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, > > rsp->hdr.err = rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev, > cmd->qp_handle, > - (struct ibv_qp_attr *)&resp->attrs, -1, > - &init_attr); > + (struct ibv_qp_attr *)&resp->attrs, > + cmd->attr_mask, &init_attr); > > pr_dbg("ret=%d\n", rsp->hdr.err); > return rsp->hdr.err; Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com> Thanks, Marcel
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c index 9d9dfc6b81..76df60a540 100644 --- a/hw/rdma/vmw/pvrdma_cmd.c +++ b/hw/rdma/vmw/pvrdma_cmd.c @@ -524,6 +524,7 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, struct ibv_qp_init_attr init_attr; pr_dbg("qp_handle=%d\n", cmd->qp_handle); + pr_dbg("attr_mask=0x%x\n", cmd->attr_mask); memset(rsp, 0, sizeof(*rsp)); rsp->hdr.response = cmd->hdr.response; @@ -531,8 +532,8 @@ static int query_qp(PVRDMADev *dev, union pvrdma_cmd_req *req, rsp->hdr.err = rdma_rm_query_qp(&dev->rdma_dev_res, &dev->backend_dev, cmd->qp_handle, - (struct ibv_qp_attr *)&resp->attrs, -1, - &init_attr); + (struct ibv_qp_attr *)&resp->attrs, + cmd->attr_mask, &init_attr); pr_dbg("ret=%d\n", rsp->hdr.err); return rsp->hdr.err;
Calling rdma_rm_query_qp with attr_mask equals to -1 leads to error where backend query_qp fails to retrieve the needed QP attributes. Fix it by providing the attr_mask we got from driver. Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com> --- hw/rdma/vmw/pvrdma_cmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)