From patchwork Thu Jun 7 21:08:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 926523 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lQGM5fqq"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 411ypC3t2zz9s01 for ; Fri, 8 Jun 2018 07:09:06 +1000 (AEST) Received: from localhost ([::1]:60178 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR29W-0005iH-HK for incoming@patchwork.ozlabs.org; Thu, 07 Jun 2018 17:09:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fR29D-0005iB-Qz for qemu-devel@nongnu.org; Thu, 07 Jun 2018 17:08:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fR29A-0007vN-Gx for qemu-devel@nongnu.org; Thu, 07 Jun 2018 17:08:43 -0400 Received: from mail-qt0-x241.google.com ([2607:f8b0:400d:c0d::241]:37315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fR29A-0007s5-Aw for qemu-devel@nongnu.org; Thu, 07 Jun 2018 17:08:40 -0400 Received: by mail-qt0-x241.google.com with SMTP id q13-v6so11405709qtp.4 for ; Thu, 07 Jun 2018 14:08:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NnUmkva4nycEKpaz5ATzee6WTf3yvbKrs2u8jpLrEj0=; b=lQGM5fqqCIHzl4z9Hzr3KTIqpF+35r+2R6idpQtiNYXD8hqmZ7wT3TWand0rPWCL4I PNX4arHMgV5Hku/dXWRCgsQ89o723XdBmZ89n9qVNdo6xK+nySFYwuWPemwh+Z4GkuWF QHeUEf9hIBzjzm1Dx56JwUypGJ/RXl/tASKeixzyjNR4iyBnJyn3JSqVM24/XQGgQFBw OifRtuP3I5UcJUeBjqeXfTD2pW36ZrWNTeFJJSJj0Ve8H+1e4Xj1tt3Fu5HzMzkirBUU 2Atk14RLiOeqHw4PIC81sORF+m3I4BOoCgVGIAOUAE34+DnXhVHF7spQwz5BxYNPKFMB 3vkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=NnUmkva4nycEKpaz5ATzee6WTf3yvbKrs2u8jpLrEj0=; b=tyZr8cj9tX54V8x7+ViPqdcwb8KcdAwr4C6qwp+PZR8ZLQkoto/uQEvtlappGxlOwI Z1ereFx1Bg+V/wVbnmNcX/1I+gn4QwnpC+6/p9mjuqXdpmebl1aBBLmjzwUPkWYnXXCq DdVAunGY6B79HxHeX0BntWtKBA3VHvI0dZid110mlFKOY0OKoYavGy0L8Gq7o0ptg1Io pBnFBaiMs0ppRafFzmOV9lGXAz6UDh3bQ19m1FaxYrpcGSXvZX68n1vke2c55Uq4XGFf bpjT/U5kLPGVxaPMys/wEgnVnOSJywbIQjM1lJIuzY8Luw7KhyXjGbAid5IY8cVhFVuR IFcg== X-Gm-Message-State: APt69E1XKqkg4dq+fquqOSqIzCLjrOgsK4bhgIbrPS8qhb05ITv3c3Im 8SB2v834FuxKJbRqLxuKexs= X-Google-Smtp-Source: ADUXVKIJOg1ZzEQhq1NJJWfUXPvUsOcJbCCKUxxVRIfQglxVSWzJG5+/c9MCK9SXgK9w/0kH2FLjWA== X-Received: by 2002:ac8:3fb2:: with SMTP id d47-v6mr3254588qtk.401.1528405719932; Thu, 07 Jun 2018 14:08:39 -0700 (PDT) Received: from x1.local ([190.177.146.201]) by smtp.gmail.com with ESMTPSA id c62-v6sm10388378qkf.10.2018.06.07.14.08.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jun 2018 14:08:38 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Peter Maydell , Paolo Bonzini Date: Thu, 7 Jun 2018 18:08:18 -0300 Message-Id: <20180607210818.12727-1-f4bug@amsat.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::241 Subject: [Qemu-devel] [PATCH] chardev: Restore CR,LF on stdio X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Markus Armbruster , qemu-devel@nongnu.org, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Patryk Olszewski , Laurent Desnogues , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Remove the 'stair-step output' on stdio. This partially reverts commit 12fb0ac05, which was correct on the mailing list but got corrupted by the maintainer :p Introduced-by: 3b876140-c035-dd39-75d0-d54c48128fac@redhat.com Reported-by: BALATON Zoltan Suggested-by: Thomas Huth Tested-by: Laurent Desnogues Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- See: http://lists.nongnu.org/archive/html/qemu-devel/2018-05/msg06202.html (bug) http://lists.nongnu.org/archive/html/qemu-devel/2018-06/msg01309.html (report) Peter, Can this enters directly as bug-fix? chardev/char-stdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/char-stdio.c b/chardev/char-stdio.c index d83e60e787..96375f2ab8 100644 --- a/chardev/char-stdio.c +++ b/chardev/char-stdio.c @@ -59,7 +59,7 @@ static void qemu_chr_set_echo_stdio(Chardev *chr, bool echo) if (!echo) { tty.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON); - tty.c_oflag &= ~OPOST; + tty.c_oflag |= OPOST; tty.c_lflag &= ~(ECHO | ECHONL | ICANON | IEXTEN); tty.c_cflag &= ~(CSIZE | PARENB); tty.c_cflag |= CS8;