From patchwork Mon May 28 12:46:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 921520 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="G7iVq6PA"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40vc7l6lqCz9s15 for ; Mon, 28 May 2018 22:47:14 +1000 (AEST) Received: from localhost ([::1]:56048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNHYM-0000zX-Mp for incoming@patchwork.ozlabs.org; Mon, 28 May 2018 08:47:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNHXp-0000yE-1X for qemu-devel@nongnu.org; Mon, 28 May 2018 08:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNHXj-0001AW-Ty for qemu-devel@nongnu.org; Mon, 28 May 2018 08:46:37 -0400 Received: from mail-pl0-x243.google.com ([2607:f8b0:400e:c01::243]:32827) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fNHXj-0001AD-OF; Mon, 28 May 2018 08:46:31 -0400 Received: by mail-pl0-x243.google.com with SMTP id n10-v6so7175998plp.0; Mon, 28 May 2018 05:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id; bh=/EnknxN0WvhkCqzmTeyninFC1hLj/4VSgVtjDPxAQNY=; b=G7iVq6PA5iHvcRwd8dFqWBjzMGnG/H2jREWKGtKXvSKox3QavwjOvNyRRKkODFfq8x Jf1yBMSxIs/n0FSM4APYMsmS1Ibb4mi2a+3MheSUsV/N6dcAE+kTTptYpCSY9z+wVTAJ hWocEUIpJHNVyQ5Y7N9Cis+C5WI2l3bpVu3nKWwq4NIHYIhcT/RGcELltmQL6irYES0T lPd3pg92VqhXaaju7J4hRpMT/Ln7luNOC1bszZyokUF7+KH20u2vAIcA/f0gQjbQL+Ee SI0D7STke8a6DJ70CaLD2B+U/ivL5C3N7d7qEnUXWWHxv2e1fs6Z0pQOPLmhSnSuIkAk UaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=/EnknxN0WvhkCqzmTeyninFC1hLj/4VSgVtjDPxAQNY=; b=lGNHrhbRaUst0cNHv44wFf1ihA/Kc4tER/LVLgvmdxeg262QMu81I2/6JKuKqsnKay 445FnxUfLmKtf2wTGyPqtSKIKhI54RZxX8hsx9efiR6F8HUZUjj2XbFmP0rySx2utf9R Ok0UB5XfHYtHU4d29vsBGlEhA7OK2qw5s+jfkBCWa/PuaHqWQhbDDyNUoWNYdTnB7Wal iJz1Ai5Dudb5vS469xI1/8RKA2x8Lxk7jKrPDjrTV8iohWM8ms3QXHn3Y+eg2YZIE0t+ 0yvKuY/ku9sXj4WTfr800V4aur+SW65L7mRGWtZjZelm+PARUjXys7CSAyNP+PnlizqV tV3Q== X-Gm-Message-State: ALKqPwebwS6Acra9ulcRxW7qhEt6Y3bzX4sv98keir8AHswsRX+L96ZD pVJEHXn7kq74Clf/ZXrLHK+2/+bD X-Google-Smtp-Source: AB8JxZrNVM5lTLcgyQreXfs9uP78Cnt7e0gQ2VqDd4ixhwuT123q+MqL0cNnNNHkkQAkjenc5glPAg== X-Received: by 2002:a17:902:507:: with SMTP id 7-v6mr13685304plf.259.1527511590204; Mon, 28 May 2018 05:46:30 -0700 (PDT) Received: from aurora.jms.id.au ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id s8-v6sm49880916pfh.30.2018.05.28.05.46.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 May 2018 05:46:29 -0700 (PDT) Received: by aurora.jms.id.au (sSMTP sendmail emulation); Mon, 28 May 2018 22:16:23 +0930 From: Joel Stanley To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Date: Mon, 28 May 2018 22:16:21 +0930 Message-Id: <20180528124621.22977-1-joel@jms.id.au> X-Mailer: git-send-email 2.17.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::243 Subject: [Qemu-devel] [PATCH] aspeed_scu: Implement RNG register X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Jeffery , =?utf-8?q?C=C3=A9dric_Le_Goater?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" The ASPEED SoCs contain a single register that returns random data when read. This models that register so that guests can use it. Signed-off-by: Joel Stanley --- hw/misc/aspeed_scu.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/hw/misc/aspeed_scu.c b/hw/misc/aspeed_scu.c index 5e6d5744eeca..8fa0cecf0fa1 100644 --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -16,6 +16,7 @@ #include "qapi/visitor.h" #include "qemu/bitops.h" #include "qemu/log.h" +#include "crypto/random.h" #include "trace.h" #define TO_REG(offset) ((offset) >> 2) @@ -154,6 +155,18 @@ static const uint32_t ast2500_a1_resets[ASPEED_SCU_NR_REGS] = { [BMC_DEV_ID] = 0x00002402U }; +static uint32_t aspeed_scu_get_random(void) +{ + Error *err = NULL; + uint32_t num; + + if (qcrypto_random_bytes((uint8_t *)&num, sizeof(num), &err)) { + error_report_err(err); + } + + return num; +} + static uint64_t aspeed_scu_read(void *opaque, hwaddr offset, unsigned size) { AspeedSCUState *s = ASPEED_SCU(opaque); @@ -167,6 +180,9 @@ static uint64_t aspeed_scu_read(void *opaque, hwaddr offset, unsigned size) } switch (reg) { + case RNG_DATA: + return aspeed_scu_get_random(); + break; case WAKEUP_EN: qemu_log_mask(LOG_GUEST_ERROR, "%s: Read of write-only offset 0x%" HWADDR_PRIx "\n", @@ -287,6 +303,9 @@ static void aspeed_scu_realize(DeviceState *dev, Error **errp) TYPE_ASPEED_SCU, SCU_IO_REGION_SIZE); sysbus_init_mmio(sbd, &s->iomem); + + if (qcrypto_random_init(errp)) + return; } static const VMStateDescription vmstate_aspeed_scu = {