From patchwork Sat May 12 00:42:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 912313 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fE4Ji2Bh"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40jT4y3q9Gz9s1b for ; Sat, 12 May 2018 10:54:42 +1000 (AEST) Received: from localhost ([::1]:59486 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHIo4-00046h-6m for incoming@patchwork.ozlabs.org; Fri, 11 May 2018 20:54:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33474) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fHIdN-0004g1-I5 for qemu-devel@nongnu.org; Fri, 11 May 2018 20:43:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fHIdM-0002wr-Pd for qemu-devel@nongnu.org; Fri, 11 May 2018 20:43:37 -0400 Received: from mail-pg0-x243.google.com ([2607:f8b0:400e:c05::243]:34644) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fHIdM-0002wF-Kr for qemu-devel@nongnu.org; Fri, 11 May 2018 20:43:36 -0400 Received: by mail-pg0-x243.google.com with SMTP id g20-v6so3086442pgv.1 for ; Fri, 11 May 2018 17:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jnB8tA4c5Y4Msd2PfhBNR5wBe9pwdTmI4+OOGSATPKw=; b=fE4Ji2BhX23c6muAGtx4355+/t53Mom8doTp6Lws0dvK27CyEAXmOlSfRRtKuUCYR9 4A7lxrZAcpccyOQThu7Px/ENJSRFGeYhaUJEeVJh/FYcl6uDqfXNktdbN2MbweMYHckY d8nnkOZX29PJzx844BPe207rvM7yaK+GJE+Lk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jnB8tA4c5Y4Msd2PfhBNR5wBe9pwdTmI4+OOGSATPKw=; b=oFz3AXZmz7GmyipFtwWpBkVVdW2C2US2Zzss6YSaSOG77IodfJc2m027Z/Oa9k+Oko D4DiYZfO/rn1W/5q6eV+uabGwIj6Lb1/nVyumYn5zN4lE4hzqKl5rkDfnulVKzlr0OLj VCVh/aI/6aM2rC1ddLOEblqb+i/LoxfFQ5wx9eMG8XpneuRKN/H9sL5WFcPdR8g7QqId ehqt6Sv71kq63M1uQbp9w5FBEqpPFTDznbV0/Sy+XCQrxBdTkTtr1vMwLC7lssTWp/Zb K6KcWuS8kmnWP8YyPzQ74cDQNJzSWnOobfrDXs/EE39GeJDrWo/O+f/gp07A6g0dUdyU WdIA== X-Gm-Message-State: ALKqPwcEbtbN8GcPwv1eXF5Z4Y8dTgzQ0DHry8Jf0JlY4YKue30wGMzm SQyG1wkrxFbrbqIFNa0FL6yNN+07Ytk= X-Google-Smtp-Source: AB8JxZrV1LiDSTZrUBYYTA9zCXwVnXtwTbLAN2VGSuPuYPcwBqM4NPiC8zTp1pNB5vyiu5bKYDCorw== X-Received: by 2002:a62:5754:: with SMTP id l81-v6mr996185pfb.56.1526085815409; Fri, 11 May 2018 17:43:35 -0700 (PDT) Received: from cloudburst.twiddle.net (97-113-2-170.tukw.qwest.net. [97.113.2.170]) by smtp.gmail.com with ESMTPSA id k84-v6sm10756406pfh.93.2018.05.11.17.43.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 May 2018 17:43:34 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 11 May 2018 17:42:59 -0700 Message-Id: <20180512004311.9299-16-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180512004311.9299-1-richard.henderson@linaro.org> References: <20180512004311.9299-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::243 Subject: [Qemu-devel] [PATCH v2 15/27] target/arm: Fix fp_status_f16 tininess before rounding X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell In commit d81ce0ef2c4f105 we added an extra float_status field fp_status_fp16 for Arm, but forgot to initialize it correctly by setting it to float_tininess_before_rounding. This currently will only cause problems for the new V8_FP16 feature, since the float-to-float conversion code doesn't use it yet. The effect would be that we failed to set the Underflow IEEE exception flag in all the cases where we should. Add the missing initialization. Fixes: d81ce0ef2c4f105 Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index d175c5e94f..7939c6b8ae 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -324,6 +324,8 @@ static void arm_cpu_reset(CPUState *s) &env->vfp.fp_status); set_float_detect_tininess(float_tininess_before_rounding, &env->vfp.standard_fp_status); + set_float_detect_tininess(float_tininess_before_rounding, + &env->vfp.fp_status_f16); #ifndef CONFIG_USER_ONLY if (kvm_enabled()) { kvm_arm_reset_vcpu(cpu);