Message ID | 20180419135901.30035-43-alex.bennee@linaro.org |
---|---|
State | New |
Headers | show
Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="B3X0ECM0"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Rgx14jylz9s2M for <incoming@patchwork.ozlabs.org>; Fri, 20 Apr 2018 00:15:01 +1000 (AEST) Received: from localhost ([::1]:50136 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>) id 1f9AKx-0001ph-L1 for incoming@patchwork.ozlabs.org; Thu, 19 Apr 2018 10:14:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47297) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <alex.bennee@linaro.org>) id 1f9ADt-0004Xs-OP for qemu-devel@nongnu.org; Thu, 19 Apr 2018 10:07:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <alex.bennee@linaro.org>) id 1f9ADs-0005LT-KS for qemu-devel@nongnu.org; Thu, 19 Apr 2018 10:07:41 -0400 Received: from mail-wr0-x244.google.com ([2a00:1450:400c:c0c::244]:45632) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <alex.bennee@linaro.org>) id 1f9ADs-0005HQ-9X for qemu-devel@nongnu.org; Thu, 19 Apr 2018 10:07:40 -0400 Received: by mail-wr0-x244.google.com with SMTP id u11-v6so14408163wri.12 for <qemu-devel@nongnu.org>; Thu, 19 Apr 2018 07:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mY3PXU5krKzSB4MJ2lZkE+sRdzZgSATMBkdhuzagHLY=; b=B3X0ECM0/r57krWZifBLO/f5T8jYFEaLobtZRjZFi9AoA2zGc3ugiZM3sL08OsQ773 k/5Y+/Dzr3+/W1DoSVwxG4wUndSIATkhnFqFRamxmFugDNjIRKTY193/Nj7ftLCgvFkj 4apR4z7/L4xFoUWZIN+00DvdW4hOJjxuvloUI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mY3PXU5krKzSB4MJ2lZkE+sRdzZgSATMBkdhuzagHLY=; b=aX1fHN8Bhh7Xp600y6IY/BSfGPafRRnpcBZbnBgyie+uDtJbBWTM4ZbOYfw6lbtcfz qqFQbzOszb2UhWwVGo8+0aAHUcRRESbDxXr81Tz8AZchZ17AmogxBLHpNDkQUbgjZOaW HuajjTaTl+sGHCXHdL0bv71df47UBzwqlz0t+cJjTjAmkrANmJW9mwrOIS3r8jpAvqHE wVkQHn8/sUGk1VDdLVDjrV7DEK0KYepqPkL4rMmSV8IRGunxfFUU7N3abJ9/tUqll1uW +yPp8RDZsM++SapGOYsqiy/uiYJcVp9s13aea2bhD9sEs7wnIKECabE8CImVvkdAmAjn 7t1Q== X-Gm-Message-State: ALQs6tATLRjoR/RaDEab7/BE4bEd5GvaklulsbZf/bwBPFk4qSHVdBH5 JzXXi8kb1QiLg7sPPfT6xao15g== X-Google-Smtp-Source: AIpwx49iZIY5DrWcyOiYxs0sCWeGX8c3zskWpopM4T6OIv6aFk2UDN3hBcHJnp11y5JA1CbqZE/Wtg== X-Received: by 2002:adf:e64b:: with SMTP id b11-v6mr1057397wrn.51.1524146859349; Thu, 19 Apr 2018 07:07:39 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id 2-v6sm6974056wrb.22.2018.04.19.07.07.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 07:07:35 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id B0FCA3E0A5F; Thu, 19 Apr 2018 14:59:04 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org> To: peter.maydell@linaro.org, cota@braap.org, famz@redhat.com, berrange@redhat.com, f4bug@amsat.org, richard.henderson@linaro.org, balrogg@gmail.com, aurelien@aurel32.net, agraf@suse.de Date: Thu, 19 Apr 2018 14:59:00 +0100 Message-Id: <20180419135901.30035-43-alex.bennee@linaro.org> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180419135901.30035-1-alex.bennee@linaro.org> References: <20180419135901.30035-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::244 Subject: [Qemu-devel] [PATCH v2 42/43] tests/tcg: disable fp-test for 32 bit (HACK!) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: <qemu-devel.nongnu.org> List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe> List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/> List-Post: <mailto:qemu-devel@nongnu.org> List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help> List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>, <mailto:qemu-devel-request@nongnu.org?subject=subscribe> Cc: =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> |
Series |
fix building of tests/tcg
|
expand
|
On 04/19/2018 03:59 AM, Alex Bennée wrote:
> +ifneq (,$(findstring 64,$(TARGET_NAME)))
You're only considering aarch64, x86_64, ppc64 and the like.
This fails for alpha, s390x and the like.
r~
Richard Henderson <richard.henderson@linaro.org> writes: > On 04/19/2018 03:59 AM, Alex Bennée wrote: >> +ifneq (,$(findstring 64,$(TARGET_NAME))) > > You're only considering aarch64, x86_64, ppc64 and the like. > This fails for alpha, s390x and the like. Yes, it's a temporary hack that needs a better solution. -- Alex Bennée
diff --git a/tests/tcg/multiarch/Makefile.target b/tests/tcg/multiarch/Makefile.target index 52adc18625..8bf6f3f8dc 100644 --- a/tests/tcg/multiarch/Makefile.target +++ b/tests/tcg/multiarch/Makefile.target @@ -31,6 +31,7 @@ run-test-mmap: test-mmap # # Include the fp-test from the main test suite # +ifneq (,$(findstring 64,$(TARGET_NAME))) VPATH+=$(SRC_PATH)/tests/fp VPATH+=$(SRC_PATH)/fpu @@ -46,3 +47,4 @@ fp-test.o softfloat.o: %.o: %.c fp-test: fp-test.o softfloat.o $(CC) $^ -o $@ -lm -static +endif
This prevents us trying to build fp-test for 32 bit guests as they would fail due to pollution from config-host.h when including osdep.h. As keeping softfloat.o would be useful maybe we can conditionally disabled it? Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- tests/tcg/multiarch/Makefile.target | 2 ++ 1 file changed, 2 insertions(+)