From patchwork Tue Apr 17 22:12:46 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 899746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fWVOhb8l"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40Qfdq2Gnrz9s1d for ; Wed, 18 Apr 2018 08:13:18 +1000 (AEST) Received: from localhost ([::1]:38195 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8Yqh-0000Ez-IW for incoming@patchwork.ozlabs.org; Tue, 17 Apr 2018 18:13:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8YqM-0000Ea-Ll for qemu-devel@nongnu.org; Tue, 17 Apr 2018 18:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8YqJ-0006MD-Ru for qemu-devel@nongnu.org; Tue, 17 Apr 2018 18:12:54 -0400 Received: from mail-pl0-x244.google.com ([2607:f8b0:400e:c01::244]:46097) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f8YqJ-0006K7-Lc for qemu-devel@nongnu.org; Tue, 17 Apr 2018 18:12:51 -0400 Received: by mail-pl0-x244.google.com with SMTP id 59-v6so12763915plc.13 for ; Tue, 17 Apr 2018 15:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id; bh=U2AdtGQLNYTIu55Uqg79l+maiTeJaJ6Saz41suejWZM=; b=fWVOhb8l1uhZRUDtSPCK+CtdtIr/D0t3YZDAYBuLmTeoyKOfTXsn3MnE0EByqkNfkq nYxDg1wO36byszdSU7wilRB371prxk2fdG2k8T5ItlZgWmRq8S+39HXY1v27NG0h17k9 +p26EQtxpea9Jg7pi/YaRAL9CkLN5rcWKmxIM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=U2AdtGQLNYTIu55Uqg79l+maiTeJaJ6Saz41suejWZM=; b=GX4AijEENKciVROxXDhSfJJooIxZGp9OramN7ywSY1Lg9kInVSHcDVhkUik/fHJVh/ yqSgIpIPIn+UMnW8R9LST6rdnL9xzBlG1g1UfJUD9xPOgeK0DkHa236OQCaJob7bmLaZ HMp+wkODBQQJBgnFbRAITnH8a3gAgsAE7V8qeC/7RryK47qQCFDC27YLfpmLu98f7d1j 2rBDn0tb1S4tY2SM+/QlNHACIl8H4NS3GnVzTrGB9bDNMPI0EM9w666+M6bb9rBWRPyz ofWdc2O+W3PPAYF/FaGsGmEAQ1FpIMTnOrC/FcdNRKYYasioBmfOcVXiyl9aLaKH4pRQ S13g== X-Gm-Message-State: ALQs6tC5COnQK+wnafYq7IKpRn1U7Jty3sxzyZeKft1a0jhFhaF2iPP7 6jWDZGWGD1+68zHUhQv+R4XEeloehrA= X-Google-Smtp-Source: AIpwx4/p4FdQI0rTaYEfj4sVWmtNV7rguaBfUbmqSHLWxhOCfuvanhCutlvlb0HGZ1EjPWQZkXypxw== X-Received: by 2002:a17:902:57c7:: with SMTP id g7-v6mr3599685plj.222.1524003169723; Tue, 17 Apr 2018 15:12:49 -0700 (PDT) Received: from cloudburst.ASUS (cpe-66-75-76-48.hawaii.res.rr.com. [66.75.76.48]) by smtp.gmail.com with ESMTPSA id d4sm27941610pgc.43.2018.04.17.15.12.48 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 15:12:48 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Tue, 17 Apr 2018 12:12:46 -1000 Message-Id: <20180417221246.14672-1-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::244 Subject: [Qemu-devel] [PATCH for-2.13] tcg: Allow wider vectors for cmp and mul X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" In db432672, we allow wide inputs for operations such as add. However, in 212be173 and 3774030a we didn't do the same for compare and multiply. Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- tcg/tcg-op-vec.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c index 70ec889bc1..2ca219734d 100644 --- a/tcg/tcg-op-vec.c +++ b/tcg/tcg-op-vec.c @@ -355,8 +355,8 @@ void tcg_gen_cmp_vec(TCGCond cond, unsigned vece, TCGType type = rt->base_type; int can; - tcg_debug_assert(at->base_type == type); - tcg_debug_assert(bt->base_type == type); + tcg_debug_assert(at->base_type >= type); + tcg_debug_assert(bt->base_type >= type); can = tcg_can_emit_vec_op(INDEX_op_cmp_vec, type, vece); if (can > 0) { vec_gen_4(INDEX_op_cmp_vec, type, vece, ri, ai, bi, cond); @@ -377,8 +377,8 @@ void tcg_gen_mul_vec(unsigned vece, TCGv_vec r, TCGv_vec a, TCGv_vec b) TCGType type = rt->base_type; int can; - tcg_debug_assert(at->base_type == type); - tcg_debug_assert(bt->base_type == type); + tcg_debug_assert(at->base_type >= type); + tcg_debug_assert(bt->base_type >= type); can = tcg_can_emit_vec_op(INDEX_op_mul_vec, type, vece); if (can > 0) { vec_gen_3(INDEX_op_mul_vec, type, vece, ri, ai, bi);