| Message ID | 20180319092505.20283.81523.stgit@pasha-VirtualBox |
|---|---|
| State | New |
| Headers | show |
| Series | replay: finish record/replay before closing the disks | expand |
On 19/03/2018 10:25, Pavel Dovgalyuk wrote: > After recent updates block devices cannot be closed on qemu exit. > This happens due to the block request polling when replay is not finished. > Therefore now we stop execution recording before closing the block devices. > > Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru> > --- > replay/replay.c | 2 ++ > vl.c | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/replay/replay.c b/replay/replay.c > index 8228261..58a986f 100644 > --- a/replay/replay.c > +++ b/replay/replay.c > @@ -366,6 +366,8 @@ void replay_finish(void) > g_free(replay_snapshot); > replay_snapshot = NULL; > > + replay_mode = REPLAY_MODE_NONE; > + > replay_finish_events(); > } > > diff --git a/vl.c b/vl.c > index e8bebda..f4d9153 100644 > --- a/vl.c > +++ b/vl.c > @@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp) > > /* No more vcpu or device emulation activity beyond this point */ > vm_shutdown(); > + replay_finish(); > > bdrv_close_all(); > > Queued, thanks. Paolo
diff --git a/replay/replay.c b/replay/replay.c index 8228261..58a986f 100644 --- a/replay/replay.c +++ b/replay/replay.c @@ -366,6 +366,8 @@ void replay_finish(void) g_free(replay_snapshot); replay_snapshot = NULL; + replay_mode = REPLAY_MODE_NONE; + replay_finish_events(); } diff --git a/vl.c b/vl.c index e8bebda..f4d9153 100644 --- a/vl.c +++ b/vl.c @@ -4733,6 +4733,7 @@ int main(int argc, char **argv, char **envp) /* No more vcpu or device emulation activity beyond this point */ vm_shutdown(); + replay_finish(); bdrv_close_all();
After recent updates block devices cannot be closed on qemu exit. This happens due to the block request polling when replay is not finished. Therefore now we stop execution recording before closing the block devices. Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru> --- replay/replay.c | 2 ++ vl.c | 1 + 2 files changed, 3 insertions(+)