From patchwork Fri Mar 2 18:56:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 880804 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NMRPIp54"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ztK604ftXz9s8r for ; Sat, 3 Mar 2018 06:26:00 +1100 (AEDT) Received: from localhost ([::1]:37065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erqJa-0003Fx-Lr for incoming@patchwork.ozlabs.org; Fri, 02 Mar 2018 14:25:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1erpr5-0002Cq-46 for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1erpr3-0003Yz-Hs for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:31 -0500 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]:41450) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1erpr3-0003Yp-BJ for qemu-devel@nongnu.org; Fri, 02 Mar 2018 13:56:29 -0500 Received: by mail-pl0-x242.google.com with SMTP id k8-v6so6188890pli.8 for ; Fri, 02 Mar 2018 10:56:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=37ouaMvY5pTOVrhHJUAjWDoVOcGc1UxIbP09Exhmpzk=; b=NMRPIp54BwDMko5dUNqbAjVzHIhCuUfBo0QZltytJh68Lmk/51NsxIxjipHJoVytT/ wrtproOGY+Xq0wtTQ4Y++Y6ULgFyZm2+VDsgGLPIekM+Dt3j7TQYQVkb5BuvrlKyqHlf AK6EWtfrTxy0LQ6yIAVsjsk25M0B3x/Stel+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=37ouaMvY5pTOVrhHJUAjWDoVOcGc1UxIbP09Exhmpzk=; b=ljOFYaU2maT8GXQZ/EvobbjHFyoRdpPKAMZa3o3bFFsNUk6tlIRpfL3aMm83cIYrrh F/eVqY3RoUa30ij1uDqeCSQtNlw0Mcl1RSn/Yb2VktBuIkdNyEq8SwqEg/AaCs0H8nBa 5ekQWfFqTpcp/0aWoUcu2WYHEeHrGrSr9eGfUTrTkvMFkmCQeWzt3vd67g2ESYpQmaFB GiixU9cabfn/paeAjZMG2o+Tl6R1IxTJKC2SKYhT5yvD9mbi3QLsQGup6RMcM6aJ8G6n TqAw7WToyzk8aaCmVO84DJZdJTdH6xIWIgiwoXR2bDZ12B5Gf3OB8fdvYwfaMuhmVd0I sf4g== X-Gm-Message-State: APf1xPDdllISppAdbc0woxqJV/HBW5IBJZRxH0vpDlgyvpfZdiUvt9u4 7fstrSHDMnPbMGxhMiZKcMtu6J/o8DM= X-Google-Smtp-Source: AG47ELv1PWWCSBuTb7XRdK2HhArsj0BwwenHtZGVUVL2R8YgUV6rjU0ioT/qUR5MJINkjge6Z/eTnw== X-Received: by 2002:a17:902:20e5:: with SMTP id v34-v6mr5955773plg.66.1520016987876; Fri, 02 Mar 2018 10:56:27 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-169-147.tukw.qwest.net. [97.113.169.147]) by smtp.gmail.com with ESMTPSA id o2sm10070338pgq.54.2018.03.02.10.56.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 02 Mar 2018 10:56:26 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 2 Mar 2018 10:56:20 -0800 Message-Id: <20180302185622.27780-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180302185622.27780-1-richard.henderson@linaro.org> References: <20180302185622.27780-1-richard.henderson@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c01::242 Subject: [Qemu-devel] [PULL 1/3] tcg: Improve tcg_gen_muli_i32/i64 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Convert multiplication by power of two to left shift. Reviewed-by: Emilio G. Cota Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 3467787323..34b96d68f3 100644 --- a/tcg/tcg-op.c +++ b/tcg/tcg-op.c @@ -277,9 +277,15 @@ void tcg_gen_setcondi_i32(TCGCond cond, TCGv_i32 ret, void tcg_gen_muli_i32(TCGv_i32 ret, TCGv_i32 arg1, int32_t arg2) { - TCGv_i32 t0 = tcg_const_i32(arg2); - tcg_gen_mul_i32(ret, arg1, t0); - tcg_temp_free_i32(t0); + if (arg2 == 0) { + tcg_gen_movi_i32(ret, 0); + } else if (is_power_of_2(arg2)) { + tcg_gen_shli_i32(ret, arg1, ctz32(arg2)); + } else { + TCGv_i32 t0 = tcg_const_i32(arg2); + tcg_gen_mul_i32(ret, arg1, t0); + tcg_temp_free_i32(t0); + } } void tcg_gen_div_i32(TCGv_i32 ret, TCGv_i32 arg1, TCGv_i32 arg2) @@ -1430,9 +1436,15 @@ void tcg_gen_setcondi_i64(TCGCond cond, TCGv_i64 ret, void tcg_gen_muli_i64(TCGv_i64 ret, TCGv_i64 arg1, int64_t arg2) { - TCGv_i64 t0 = tcg_const_i64(arg2); - tcg_gen_mul_i64(ret, arg1, t0); - tcg_temp_free_i64(t0); + if (arg2 == 0) { + tcg_gen_movi_i64(ret, 0); + } else if (is_power_of_2(arg2)) { + tcg_gen_shli_i64(ret, arg1, ctz64(arg2)); + } else { + TCGv_i64 t0 = tcg_const_i64(arg2); + tcg_gen_mul_i64(ret, arg1, t0); + tcg_temp_free_i64(t0); + } } void tcg_gen_div_i64(TCGv_i64 ret, TCGv_i64 arg1, TCGv_i64 arg2)