From patchwork Fri Feb 16 02:29:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 874256 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="qSTB6K9V"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zjHFb1kgVz9t3v for ; Fri, 16 Feb 2018 13:31:15 +1100 (AEDT) Received: from localhost ([::1]:57243 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emVnt-0005jL-9a for incoming@patchwork.ozlabs.org; Thu, 15 Feb 2018 21:31:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emVmx-0005g7-S5 for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:30:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emVmw-0002eY-V9 for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:30:15 -0500 Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:32842) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1emVmw-0002eO-QA for qemu-devel@nongnu.org; Thu, 15 Feb 2018 21:30:14 -0500 Received: by mail-vk0-x242.google.com with SMTP id w201so1067617vkw.0 for ; Thu, 15 Feb 2018 18:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BvyBAJjZIT72bCBUYE4Z5/a2MRITLhsyueWNHdF6kAo=; b=qSTB6K9V9YFJlt+D3mIaPhqTV2KFQ5AJZU4PF4mQgyRw+e5Q0mp5qXRHBZBoMnWrOY QekYkr261prmHpJoDoyW9cre4oWovxZ4FoHX5K6G526QsrUdDsjOiX8LIiKNR5Gb/Ae8 SFLsiLQT6gYv2b9brPrXQyUzICfKxvE2nBrwGwUDWgJhwTmbPvrR9l0XIRy/TH4FGZ6t ncw31w4KyCU3jrx58ICT0nE5ZYwK7MB5c/Ov6RaTa4BxHN9XFPb3h9d4r1ztPXGD9iV8 NgZLqO3y67D+kF7hEFDE2qJgn4+/OkGWH39vdELX5wN6f9ImFRtUHlzScsPvKK2m/p33 TqEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=BvyBAJjZIT72bCBUYE4Z5/a2MRITLhsyueWNHdF6kAo=; b=Trr6yCujcrwC81Z+WFQqXmeM7oUu9xU+TXXYDhaS+dpSq0LzqXjcrPAh/rK0yZUWPG HlEHfY9I4E+6aRmjbayCnty7/6kFmzo4roBQJCrg137FErZ12H+vTcvC1XlAyCbiZhZA zcO0HWsn0Xl+kTdEFO34efgOEIAslEs2DQCEhhtMeX1hNIMG9qw9irEh2J8/VNZDytDt rbBT91R+8O0lzsJJiJsR1c8EBUTSk90PhlPWlVyEQPfS83bqQ5i9zvwTd+ummNsIuuXI t+bQE3rRzFQd5MAyMkZxHqllREpCgclZv5VbP0QhcaDzhKtczSwXJ7COKEPXJuXe2Hlg yRFg== X-Gm-Message-State: APf1xPAphMB/XyBg7pFJFU76HvZ4h2CNcNxfC2J8o38j4MliZU7+E+7j WATLbA42968Jl6FUu79oTpY= X-Google-Smtp-Source: AH8x227YT5K26FQIxy1WGYAt36IzoQ9LmQ01yvZQBEx9BuIcwDHs2y2g3x5A3WW647FJjXIxYo4RWw== X-Received: by 10.31.174.147 with SMTP id x141mr3631711vke.41.1518748214250; Thu, 15 Feb 2018 18:30:14 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id q5sm6295200uaj.17.2018.02.15.18.30.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Feb 2018 18:30:13 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell Date: Thu, 15 Feb 2018 23:29:31 -0300 Message-Id: <20180216022933.10945-7-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180216022933.10945-1-f4bug@amsat.org> References: <20180216022933.10945-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400c:c05::242 Subject: [Qemu-devel] [PATCH v3 6/7] hw/sd: make sd_data_ready() static X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Stefan Weil , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Michael Walle Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" It belongs to the legacy API (the last user has been converted). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- include/hw/sd/sd.h | 1 - hw/sd/sd.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index bf1eb0713c..4491db98de 100644 --- a/include/hw/sd/sd.h +++ b/include/hw/sd/sd.h @@ -138,7 +138,6 @@ int sd_do_command(SDState *sd, SDRequest *req, void sd_write_data(SDState *sd, uint8_t value); uint8_t sd_read_data(SDState *sd); void sd_set_cb(SDState *sd, qemu_irq readonly, qemu_irq insert); -bool sd_data_ready(SDState *sd); /* sd_enable should not be used -- it is only used on the nseries boards, * where it is part of a broken implementation of the MMC card slot switch * (there should be two card slots which are multiplexed to a single MMC diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 9ac9b63ff8..72d32f7845 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1885,7 +1885,7 @@ uint8_t sd_read_data(SDState *sd) return ret; } -bool sd_data_ready(SDState *sd) +static bool sd_data_ready(SDState *sd) { return sd->state == sd_sendingdata_state; }