From patchwork Fri Feb 9 14:54:14 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 871439 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="mgxwE91z"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zdJFx2mpvz9s1h for ; Sat, 10 Feb 2018 02:02:45 +1100 (AEDT) Received: from localhost ([::1]:60265 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekACJ-0007dK-E8 for incoming@patchwork.ozlabs.org; Fri, 09 Feb 2018 10:02:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34013) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ekA5A-0002B1-3O for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ekA58-0005Sp-6y for qemu-devel@nongnu.org; Fri, 09 Feb 2018 09:55:20 -0500 Received: from mail-qt0-x244.google.com ([2607:f8b0:400d:c0d::244]:40828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ekA58-0005ST-1p; Fri, 09 Feb 2018 09:55:18 -0500 Received: by mail-qt0-x244.google.com with SMTP id s39so10838642qth.7; Fri, 09 Feb 2018 06:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wY//D2TOSIUxA/+3Tz/qnHcjRg6V0zzmBzdlX6DyMlw=; b=mgxwE91zGV7qQTeHjAxwLKu2ekBxwkWYW4JLMRhm0zWb545LnoALZvAe9aLv3+6lif G9ys6giKe2sUSdqkX7DFdLHyl9q/lBo6spGI6rXPiX4IzOzQoRAetNJS3GREmILns/a5 Wi4BgfokPsU1y1KWf8iSoFf5YPCaU422oJWAEeWACGFo1ff2kAf/w9vQfNQSkvlCSusw /9Lg00N8v9+S5zF/Sd6VeTtd3aEn/e8/GLPOQObt6LqLhRpRWpjZ9EJ7l9WOutr8lsEH HGSA/P83zWmNJFSVt6r+JrfjlQIXKG0GjDmh4EbaKzLgSaRckUVtfPYLMHantM2mWHxI 90UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=wY//D2TOSIUxA/+3Tz/qnHcjRg6V0zzmBzdlX6DyMlw=; b=LDrID36fCNCvO6kQEu4M63OYJAyvshO6gifh2cCBA9U6jXV+QaOX/6m1Fwt2m0hQ38 g1F6ukT4M35bFFliYhxRY4MrrXJ6o5dLVG4BzMqzGa9/LrWN3C/HVtJ+WG8EqY37K+d6 9OJk2boBE76T0qfSP+4A94dm4XJXseo0oaX01RSN6zLfCbUpKrbGNw24wPa4a8ASzQmg 6CRINmrsw7OrJjvXOWx5a2Y08jAdaCI0TfG19wMzPBCRExQv1A/JrjNUTgV606WVEM5c vyMjJ6Juu/lBgv9X1LN4OmvSSiXeJBh/lb4BytNHcpxdI3125SdErNbf41n/JE8xRCgn Zssg== X-Gm-Message-State: APf1xPAyS3rRuxeYZZhvpvZyiSu1p3k5V2gs9sLsnw/7fHGKlOGnfnbM anX46awYp6mcAt0kc1aPLWI= X-Google-Smtp-Source: AH8x226MPxzK3hVAC+7YZF+PPpX2wRaSNuEkQ91e4uvaUwA2Q9WSpGpr/i4+PSCpHaJ85InxEzNk6g== X-Received: by 10.237.55.33 with SMTP id i30mr4948536qtb.95.1518188117449; Fri, 09 Feb 2018 06:55:17 -0800 (PST) Received: from x1.local ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id b29sm747841qkb.28.2018.02.09.06.55.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Feb 2018 06:55:16 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Paolo Bonzini Date: Fri, 9 Feb 2018 11:54:14 -0300 Message-Id: <20180209145430.26007-15-f4bug@amsat.org> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180209145430.26007-1-f4bug@amsat.org> References: <20180209145430.26007-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::244 Subject: [Qemu-devel] [PATCH v12 14/30] hw/arm/exynos4210: access the 64-bit capareg with qdev_prop_set_uint64() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Peter Maydell , qemu-devel@nongnu.org, Igor Mitsyanko , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Alistair Francis , "open list:Exynos" Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" We only set a 32-bit value, but this is a good practice in case this code is used as reference. (missed in 5efc9016e52) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/arm/exynos4210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index e8e1d81e62..d89322c7ea 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -378,7 +378,7 @@ Exynos4210State *exynos4210_init(MemoryRegion *system_mem) DriveInfo *di; dev = qdev_create(NULL, TYPE_SYSBUS_SDHCI); - qdev_prop_set_uint32(dev, "capareg", EXYNOS4210_SDHCI_CAPABILITIES); + qdev_prop_set_uint64(dev, "capareg", EXYNOS4210_SDHCI_CAPABILITIES); qdev_init_nofail(dev); busdev = SYS_BUS_DEVICE(dev);