From patchwork Wed Jan 24 23:26:12 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 865595 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="cczMHoAN"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zRhbl3qpdz9t3l for ; Thu, 25 Jan 2018 10:44:51 +1100 (AEDT) Received: from localhost ([::1]:54562 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeUin-0001xa-J6 for incoming@patchwork.ozlabs.org; Wed, 24 Jan 2018 18:44:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51302) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eeURq-00050L-OK for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eeURp-000229-SZ for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:27:18 -0500 Received: from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244]:35174) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eeURp-00021z-MP for qemu-devel@nongnu.org; Wed, 24 Jan 2018 18:27:17 -0500 Received: by mail-pg0-x244.google.com with SMTP id o13so3819202pgs.2 for ; Wed, 24 Jan 2018 15:27:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=LP9OHUOYoiZv6JPSNgAYHzOXuxtIZkBZc9DCBZ38R7g=; b=cczMHoANxL2ZJf3qiYCYKv+QXkaw3zb/v68CTfAnSObryxr3D48XkF/VUwdd82fpfy tXzGLn3OWQZCzDU9TUON+102jDW3M8axHfLW1oCoKZNO93gpao2slgDv3v3akzROT7pC jsRWKLO3sDm++fbIKdrsWD4ZZTCoOktqpFiuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=LP9OHUOYoiZv6JPSNgAYHzOXuxtIZkBZc9DCBZ38R7g=; b=W9//+HtJUIZ4sq9gI2XPH8MnnWMeWe/x3MDEZNHKgBsUzAY6K8zBWjJWtLkUPLeqB2 mqom3y/quppfysOEfgAcsMr1i42FqVu5rKvPy8Sg68m1+m7gRF50v66pOrLibcVl7utr iYZuPPxa8mf7j9/JS91d/2EknZKbwm7cV+saVAh0orm3HqmqG3zu8BWv06jhEeTlm2cQ 07sxDz9DhLI7wmySBaK73u2jPVBGEL/v0BmTo59fNlMQVZjP0bY9rOSw2yusfq2nVLIK fJphb8NYZvKyqe6rbsem7NKDd0W9Kr1neB42pXF0fw9/OAAJh4kjtbqnu04DzEu4kM03 B6Yw== X-Gm-Message-State: AKwxytc8VIMuyd/kc5+bDMmA12aHcw1iUCyHviU/d9NWrmL4l+OECYpK 0MaAYhsvDVOIFWCqcAHfuaw+jWAyoeI= X-Google-Smtp-Source: AH8x224ZrpP+0OZnPfnvlNZc3RYg9Q5Ccd4Nm7WmKEaFNg+UZCOly+5tQKCKAZECSHAkvUxKCx/qwA== X-Received: by 2002:a17:902:507:: with SMTP id 7-v6mr7968298plf.0.1516836436426; Wed, 24 Jan 2018 15:27:16 -0800 (PST) Received: from cloudburst.twiddle.net (174-21-6-47.tukw.qwest.net. [174.21.6.47]) by smtp.gmail.com with ESMTPSA id z19sm9760028pfh.185.2018.01.24.15.27.15 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Jan 2018 15:27:15 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 24 Jan 2018 15:26:12 -0800 Message-Id: <20180124232625.30105-33-richard.henderson@linaro.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180124232625.30105-1-richard.henderson@linaro.org> References: <20180124232625.30105-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400e:c05::244 Subject: [Qemu-devel] [PATCH v3 32/45] target/hppa: Only use EXCP_DTLB_MISS X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Unknown why this works, but if we return EXCP_ITLB_MISS we will triple-fault the first userland instruction fetch. Is it something to do with having a combined I/DTLB? Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index c14317ebef..81bcbe45db 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -97,7 +97,9 @@ int hppa_get_physical_address(CPUHPPAState *env, vaddr addr, int mmu_idx, if (ent == NULL || !ent->entry_valid) { phys = 0; prot = 0; - ret = (ifetch ? EXCP_ITLB_MISS : EXCP_DTLB_MISS); + /* ??? Unconditionally report data tlb miss, + even if this is an instruction fetch. */ + ret = EXCP_DTLB_MISS; goto egress; }