From patchwork Tue Jan 23 03:30:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 864578 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GKiANfDC"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zQYsd5QGrz9s72 for ; Tue, 23 Jan 2018 14:37:57 +1100 (AEDT) Received: from localhost ([::1]:59529 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpPH-0000Ap-Ry for incoming@patchwork.ozlabs.org; Mon, 22 Jan 2018 22:37:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1edpIq-0003Yc-FM for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:31:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1edpIp-00084y-M5 for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:31:16 -0500 Received: from mail-qt0-x242.google.com ([2607:f8b0:400d:c0d::242]:33536) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1edpIp-00084e-Hl for qemu-devel@nongnu.org; Mon, 22 Jan 2018 22:31:15 -0500 Received: by mail-qt0-x242.google.com with SMTP id d8so17866422qtm.0 for ; Mon, 22 Jan 2018 19:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nvvDKzovusnuZEAxGj2seKlCqdYmVR93Sr58vqI5BW8=; b=GKiANfDCNJmnuDmuOz5peBByoj7BRdPP2HB3jAoO8cVElA7Lq673qT7ZJzHGdusp4c 5SsCOQAOUu0c+lMJasf7JAjcRQkJp7GP9KOt+b1wKXJKcInEqj1t+F5kO20N/CjbTm85 VypRAASvjGyJY6tX+kIoH4p0qC0VJeIee8SXsIdAHTCOvmoQ51BvINuqaxIlozjmxgbZ AaB4SkLiLENVwxrZ+lRjW7u3QNUM9OTeFwX5kvW+LJxYjN566sSAlk8omKKD1rYa7p2U 9lGPsr6GfNoFAHPZiwyqJ6zNT9mHw6j8GHxnIW7XeOP9qjOIuruD/UCtXrFC4A4ThTTZ 0cYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=nvvDKzovusnuZEAxGj2seKlCqdYmVR93Sr58vqI5BW8=; b=ruIoGxylr3IuaC9RpCxGRtyUq6YcUXNsQEpgeBZRDT4Ke287MrulAJb/cTE0HEMdRV XEf0hyS82krzIKbw9AvFR6lmaK0Ak/53WudzyG2VuSjFBo7O9VDnq/29GN2Xgo8fXVAj po/X9lGMfkzBL5GkxfOwnM1dSHsR6TbonR26fgaucamCTCpxCAGjRmxsdCs3EZurBQ69 4azzDkjoq6LBCln/d7q4zLRtFKwRCyVUaMLefUVXuwOSiHunbZV81HHs/BuIjq8mJQoc 9kFRn9qlq8quzHd33/rmbpjsSDume0DpU3LAzPLhjoaJs/WYajTi1npFhfVhRBYwSZ+h LbUQ== X-Gm-Message-State: AKwxytdMP2h/hVqStRczXXLjVc6Ak5wQNYQLncaDmrJDcjw+2b/+ehGq Vj73usdvan0qdykNQdSQ51w= X-Google-Smtp-Source: AH8x227QKlEuIyCnfKZIJJjP25S5KkbObUxLaZKhyzxk7to5EFj/xRXhTTywswyZ//kuEhSVh0AvbQ== X-Received: by 10.237.34.10 with SMTP id n10mr1735114qtc.105.1516678275132; Mon, 22 Jan 2018 19:31:15 -0800 (PST) Received: from x1.lan ([138.117.48.219]) by smtp.gmail.com with ESMTPSA id w8sm3848586qka.2.2018.01.22.19.31.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 19:31:14 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Alistair Francis , Peter Maydell , Igor Mitsyanko Date: Tue, 23 Jan 2018 00:30:27 -0300 Message-Id: <20180123033034.29493-12-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180123033034.29493-1-f4bug@amsat.org> References: <20180123033034.29493-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::242 Subject: [Qemu-devel] [PATCH v3 11/18] sdcard: check the card is in correct state for APP CMD (CMD55) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Prasad J Pandit , Peter Crosthwaite , =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- hw/sd/sd.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index bbf9496e8a..434d1fbc47 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1389,6 +1389,14 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req) /* Application specific commands (Class 8) */ case 55: /* CMD55: APP_CMD */ + switch (sd->state) { + case sd_ready_state: + case sd_identification_state: + case sd_inactive_state: + return sd_illegal; + default: + break; + } if (!sd->spi) { if (sd->rca != rca) { return sd_r0;