[v2,15/25] sdcard: add missing CMD54 SDIO command

Message ID	20180103212436.15762-16-f4bug@amsat.org
State	New
Headers	show Return-Path: <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org> From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org> To: Alistair Francis <alistair.francis@xilinx.com>, Peter Maydell <peter.maydell@linaro.org>, Igor Mitsyanko <i.mitsyanko@gmail.com>, Andrew Baumann <Andrew.Baumann@microsoft.com>, Olbrich <m.olbrich@pengutronix.de>, Andrzej Zaborowski <balrogg@gmail.com> Date: Wed, 3 Jan 2018 18:24:26 -0300 Message-Id: <20180103212436.15762-16-f4bug@amsat.org> In-Reply-To: <20180103212436.15762-1-f4bug@amsat.org> References: <20180103212436.15762-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v2 15/25] sdcard: add missing CMD54 SDIO command Precedence: list Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>, Prasad J Pandit <pjp@fedoraproject.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, =?utf-8?q?Philippe_M?= =?utf-8?q?athieu-Daud=C3=A9?= <f4bug@amsat.org>, qemu-devel@nongnu.org, Paul Brook <paul@codesourcery.com>, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= <marcandre.lureau@redhat.com> Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" <qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>
Series	SDCard: housekeeping, improve SPI, introduce new Specs \| expand [v2,00/25] SDCard: housekeeping, improve SPI, introduce new Specs [v2,01/25] sdcard: reorder SDState struct members [v2,02/25] sdcard: replace DPRINTF() by trace events [v2,03/25] sdcard: add more trace events [v2,04/25] sdcard: define SDCARD_CMD_MAX instead of using the magic '64' [v2,05/25] sdcard: display command name when tracing CMD/ACMD [v2,06/25] sdcard: let cmd_valid_while_locked() returns a bool [v2,07/25] sdcard: rename sd_set_$REG() functions called once as sd_reset_$REG() [v2,08/25] sdcard: use the registerfields API to access the OCR register [v2,09/25] sdcard: use G_BYTE from cutils [v2,10/25] sdcard: remove unreachable code [v2,11/25] sdcard: replace switch(unique case) statements -> if(case) [v2,12/25] sdcard: use a 16-bit integer for the 16-bit RCA register [v2,13/25] sdcard: let function handling response codes returns the response size [v2,14/25] sdcard: add missing command CMD55 [v2,15/25] sdcard: add missing CMD54 SDIO command [RFC,v2,16/25] sdcard: add missing SPI legal commands [RFC,v2,17/25] sdcard: fix SPI response length [v2,18/25] sdcard: add an enum for the SD PHY Spec version [v2,19/25] sdcard: check if the card capacity is supported [v2,20/25] sdcard: Don't always set the high capacity bit [v2,21/25] sdcard: add cmd_version_supported(), improve cmd_class_supported() [v2,22/25] sdcard: remove unreachable SPI commands [RFC,v2,23/25] sdcard: store the bus protocol in an enum [v2,24/25] sdcard: introduce Spec v3.01 SD commands [v2,25/25] sdcard: introduce Spec v4.51 & v5.1 MMC commands

Message ID

20180103212436.15762-16-f4bug@amsat.org

State

New

Headers

From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <f4bug@amsat.org>
To: Alistair Francis <alistair.francis@xilinx.com>,
	Peter Maydell <peter.maydell@linaro.org>,
	Igor Mitsyanko <i.mitsyanko@gmail.com>,
	Andrew Baumann <Andrew.Baumann@microsoft.com>,
	Olbrich <m.olbrich@pengutronix.de>,
	Andrzej Zaborowski <balrogg@gmail.com>
Date: Wed,  3 Jan 2018 18:24:26 -0300
Message-Id: <20180103212436.15762-16-f4bug@amsat.org>
In-Reply-To: <20180103212436.15762-1-f4bug@amsat.org>
References: <20180103212436.15762-1-f4bug@amsat.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: [Qemu-devel] [PATCH v2 15/25] sdcard: add missing CMD54 SDIO command
Precedence: list
Cc: "Edgar E . Iglesias" <edgar.iglesias@xilinx.com>, Prasad J Pandit
	<pjp@fedoraproject.org>, 
	Peter Crosthwaite <crosthwaite.peter@gmail.com>, =?utf-8?q?Philippe_M?=
	=?utf-8?q?athieu-Daud=C3=A9?= <f4bug@amsat.org>, qemu-devel@nongnu.org,
	Paul Brook <paul@codesourcery.com>, =?utf-8?q?Marc-Andr=C3=A9_Lureau?=
	<marcandre.lureau@redhat.com>
Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org
Sender: "Qemu-devel"
	<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>

Series

SDCard: housekeeping, improve SPI, introduce new Specs | expand

Commit Message

Philippe Mathieu-Daudé Jan. 3, 2018, 9:24 p.m. UTC

we don't implement it, but can see firmwares using it via UNIMP logs.

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 hw/sd/sd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 2b4254802f..d2a0baa0a7 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -1295,9 +1295,8 @@  static sd_rsp_type_t sd_normal_command(SDState *sd, SDRequest req)
         }
         break;
 
-    case 52:
-    case 53:
-        /* CMD52, CMD53: reserved for SDIO cards
+    case 52 ... 54:
+        /* CMD52, CMD53, CMD54: reserved for SDIO cards
          * (see the SDIO Simplified Specification V2.0)
          * Handle as illegal command but do not complain
          * on stderr, as some OSes may use these in their

[v2,15/25] sdcard: add missing CMD54 SDIO command

Commit Message

Patch