Message ID | 20180103162400.10396-2-f4bug@amsat.org |
---|---|
State | New |
Headers | show |
Series | SDHCI: convert legacy devices to the SDBus API | expand |
On Wed, Jan 3, 2018 at 8:23 AM, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/sd/milkymist-memcard.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c > index 4008c81002..5de3e00e2f 100644 > --- a/hw/sd/milkymist-memcard.c > +++ b/hw/sd/milkymist-memcard.c > @@ -26,7 +26,7 @@ > #include "hw/sysbus.h" > #include "sysemu/sysemu.h" > #include "trace.h" > -#include "qemu/error-report.h" > +#include "include/qapi/error.h" > #include "sysemu/block-backend.h" > #include "sysemu/blockdev.h" > #include "hw/sd/sd.h" > @@ -138,8 +138,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, > } else { > r = s->response[s->response_read_ptr++]; > if (s->response_read_ptr > s->response_len) { > - error_report("milkymist_memcard: " > - "read more cmd bytes than available. Clipping."); > + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " > + "read more cmd bytes than available. Clipping."); > s->response_read_ptr = 0; > } > } > @@ -163,8 +163,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, > break; > > default: > - error_report("milkymist_memcard: read access to unknown register 0x" > - TARGET_FMT_plx, addr << 2); > + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " > + "read access to unknown register 0x%" HWADDR_PRIx "\n", > + addr << 2); > break; > } > > @@ -220,8 +221,9 @@ static void memcard_write(void *opaque, hwaddr addr, uint64_t value, > break; > > default: > - error_report("milkymist_memcard: write access to unknown register 0x" > - TARGET_FMT_plx, addr << 2); > + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " > + "write access to unknown register 0x%" HWADDR_PRIx " " > + "(value 0x%" PRIx64 ")\n", addr << 2, value); Can you fix up the secondary lines indentation? After that: Reviewed-by: Alistair Francis <alistair.francis@xilinx.com> Alistair > break; > } > } > -- > 2.15.1 > >
I'm too comfortable with the 'log' trace backend and again forgot to add the "qemu/log.h" dependency ... /home/travis/build/philmd/qemu/hw/sd/milkymist-memcard.c:141:17: error: implicit declaration of function ‘qemu_log_mask’ [-Werror=implicit-function-declaration] qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " ^ hw/sd/milkymist-memcard.c:141:31: error: ‘LOG_GUEST_ERROR’ undeclared (first use in this function) qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " ^ hw/sd/milkymist-memcard.c:166:23: error: ‘LOG_UNIMP’ undeclared (first use in this function) qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " ^ On 01/03/2018 01:23 PM, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > hw/sd/milkymist-memcard.c | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c > index 4008c81002..5de3e00e2f 100644 > --- a/hw/sd/milkymist-memcard.c > +++ b/hw/sd/milkymist-memcard.c > @@ -26,7 +26,7 @@ > #include "hw/sysbus.h" > #include "sysemu/sysemu.h" > #include "trace.h" > -#include "qemu/error-report.h" > +#include "include/qapi/error.h" > #include "sysemu/block-backend.h" > #include "sysemu/blockdev.h" > #include "hw/sd/sd.h" > @@ -138,8 +138,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, > } else { > r = s->response[s->response_read_ptr++]; > if (s->response_read_ptr > s->response_len) { > - error_report("milkymist_memcard: " > - "read more cmd bytes than available. Clipping."); > + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " > + "read more cmd bytes than available. Clipping."); > s->response_read_ptr = 0; > } > } > @@ -163,8 +163,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, > break; > > default: > - error_report("milkymist_memcard: read access to unknown register 0x" > - TARGET_FMT_plx, addr << 2); > + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " > + "read access to unknown register 0x%" HWADDR_PRIx "\n", > + addr << 2); > break; > } > > @@ -220,8 +221,9 @@ static void memcard_write(void *opaque, hwaddr addr, uint64_t value, > break; > > default: > - error_report("milkymist_memcard: write access to unknown register 0x" > - TARGET_FMT_plx, addr << 2); > + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " > + "write access to unknown register 0x%" HWADDR_PRIx " " > + "(value 0x%" PRIx64 ")\n", addr << 2, value); > break; > } > } >
diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c index 4008c81002..5de3e00e2f 100644 --- a/hw/sd/milkymist-memcard.c +++ b/hw/sd/milkymist-memcard.c @@ -26,7 +26,7 @@ #include "hw/sysbus.h" #include "sysemu/sysemu.h" #include "trace.h" -#include "qemu/error-report.h" +#include "include/qapi/error.h" #include "sysemu/block-backend.h" #include "sysemu/blockdev.h" #include "hw/sd/sd.h" @@ -138,8 +138,8 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, } else { r = s->response[s->response_read_ptr++]; if (s->response_read_ptr > s->response_len) { - error_report("milkymist_memcard: " - "read more cmd bytes than available. Clipping."); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_memcard: " + "read more cmd bytes than available. Clipping."); s->response_read_ptr = 0; } } @@ -163,8 +163,9 @@ static uint64_t memcard_read(void *opaque, hwaddr addr, break; default: - error_report("milkymist_memcard: read access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "read access to unknown register 0x%" HWADDR_PRIx "\n", + addr << 2); break; } @@ -220,8 +221,9 @@ static void memcard_write(void *opaque, hwaddr addr, uint64_t value, break; default: - error_report("milkymist_memcard: write access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_UNIMP, "milkymist_memcard: " + "write access to unknown register 0x%" HWADDR_PRIx " " + "(value 0x%" PRIx64 ")\n", addr << 2, value); break; } }
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- hw/sd/milkymist-memcard.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-)