From patchwork Wed Dec 13 20:44:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 848235 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="JEs6jtaE"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yxpd34lqbz9s81 for ; Thu, 14 Dec 2017 07:46:15 +1100 (AEDT) Received: from localhost ([::1]:37559 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePDuv-0004Ej-KJ for incoming@patchwork.ozlabs.org; Wed, 13 Dec 2017 15:46:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39359) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ePDth-00041V-7W for qemu-devel@nongnu.org; Wed, 13 Dec 2017 15:45:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ePDtg-0006JR-CN for qemu-devel@nongnu.org; Wed, 13 Dec 2017 15:44:57 -0500 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:46193) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ePDtg-0006Io-7X; Wed, 13 Dec 2017 15:44:56 -0500 Received: by mail-qk0-x243.google.com with SMTP id b184so3685800qkc.13; Wed, 13 Dec 2017 12:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DlmG7hzRagDkTdI6MyP5XoC2NlvDV7RMExcPXGV1dZs=; b=JEs6jtaEPbOD2z/PQicPhupCN8Q05Zw4PPfWCC31wtKMLDbQlVXHp+Kg0DwDFKkHvj QgYhQYgfQ0UbwqcmXK+SbllbIT1iYurRElX0yh4TsbBV9iW+folRevDKTMfA2MPHDyJZ v+Gze7F9LIGKOdrEib930sfTmguDe8G6eLejFdqY/YJI8yc/T8yEjCTcmd0y2rMBT54t yipeYICJ4d/XXr6m2ufxo1LVYjeeDl0IuT3RsQkGM0gAwOheuWrQoTKjAlYYGhWcSEIG 0spq39HlDHgZXJePiZocq/8cfkRsdNj3kEE2RM8s/eA1u1VYjhLtUkwbRRTCnbZUOw6i dU0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=DlmG7hzRagDkTdI6MyP5XoC2NlvDV7RMExcPXGV1dZs=; b=bqR3UJGzRhqZfhefZQl2WqumrGKn7YRHfz9ZGb1kmbjLbr7nCrr9WM4krMVMGRjx61 Se/dTibBYTBPJ0by8ivxzDAWMV1g9Lhx9m0a2wXciY+HGysBiTO6AvCKC5ZI6cEAF8Qb w++g8YWbgoiEZOmzVUcKqia/tHL/QZCry2oDY4vlI8FZOw7qrLTXVyGqxbENBf8U84gv JBcOPNQ6TNjvNbSH4YfOHr2sLpLGjMNVtCXZHo+PE0tVyQR1U4sioNK9Ox2lbqcrtXlT vwlPtLetlyRuchfb9fx2QRoUQuPdi7e69IasMdoWh9nUupEcDFszVT+xf/mJpMoyRXCF eORg== X-Gm-Message-State: AKGB3mJKyNyBtlxFiwgx2SyIeWVhJlw71oMaW8/3xs4WAveZMnH6wsxu O5JIAH6dAuzktllHMSu1WKM= X-Google-Smtp-Source: ACJfBovOJxTy69GWf/3retgpYWIs+U3v0J4CDW5I68NZsGmglvYCAp663z6D+rsaILVxqWe316jglA== X-Received: by 10.55.104.198 with SMTP id d189mr12344526qkc.190.1513197895673; Wed, 13 Dec 2017 12:44:55 -0800 (PST) Received: from x1.local ([138.117.48.211]) by smtp.gmail.com with ESMTPSA id n64sm1507938qkd.97.2017.12.13.12.44.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Dec 2017 12:44:55 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: Alistair Francis , "Edgar E . Iglesias" , Prasad J Pandit , Peter Maydell , Andrew Baumann , Andrey Smirnov , Andrey Yurovsky , Clement Deschamps Date: Wed, 13 Dec 2017 17:44:27 -0300 Message-Id: <20171213204436.5379-3-f4bug@amsat.org> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20171213204436.5379-1-f4bug@amsat.org> References: <20171213204436.5379-1-f4bug@amsat.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::243 Subject: [Qemu-devel] [PATCH 02/11] bcm2835_peripherals: move GPIO 'sdbus' property link from init() -> realize() X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Pavan Boddu , Peter Crosthwaite , qemu-arm@nongnu.org, =?utf-8?q?Philipp?= =?utf-8?q?e_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" We can then use dynamic sdbus creation (from realized HCI devices). Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alistair Francis --- hw/arm/bcm2835_peripherals.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/hw/arm/bcm2835_peripherals.c b/hw/arm/bcm2835_peripherals.c index 12e0dd11af..7f30f19c4c 100644 --- a/hw/arm/bcm2835_peripherals.c +++ b/hw/arm/bcm2835_peripherals.c @@ -112,11 +112,6 @@ static void bcm2835_peripherals_init(Object *obj) object_initialize(&s->gpio, sizeof(s->gpio), TYPE_BCM2835_GPIO); object_property_add_child(obj, "gpio", OBJECT(&s->gpio), NULL); qdev_set_parent_bus(DEVICE(&s->gpio), sysbus_get_default()); - - object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhci", - OBJECT(&s->sdhci.sdbus), &error_abort); - object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhost", - OBJECT(&s->sdhost.sdbus), &error_abort); } static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) @@ -314,6 +309,10 @@ static void bcm2835_peripherals_realize(DeviceState *dev, Error **errp) } /* GPIO */ + object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhci", + OBJECT(&s->sdhci.sdbus), &error_abort); + object_property_add_const_link(OBJECT(&s->gpio), "sdbus-sdhost", + OBJECT(&s->sdhost.sdbus), &error_abort); object_property_set_bool(OBJECT(&s->gpio), true, "realized", &err); if (err) { error_propagate(errp, err);