diff mbox series

[v3,16/42] i386/hax: remove duplicated include

Message ID 20171017164426.25277-17-f4bug@amsat.org
State Superseded, archived
Headers show
Series remove i386/pc dependency from non-PC world (part 1) | expand

Commit Message

Philippe Mathieu-Daudé Oct. 17, 2017, 4:44 p.m. UTC 
this file in include in "target/i386/hax-i386.h":

    #ifdef CONFIG_WIN32
    #include "target/i386/hax-windows.h"
    #endif

which guaranty than sysemu/os-win32.h is previously included (CONFIG_WIN32)

Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 target/i386/hax-windows.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Thomas Huth Oct. 18, 2017, 12:12 p.m. UTC | #1 
On 17.10.2017 18:44, Philippe Mathieu-Daudé wrote:
> this file in include in "target/i386/hax-i386.h":
> 
>     #ifdef CONFIG_WIN32
>     #include "target/i386/hax-windows.h"
>     #endif
> 
> which guaranty than sysemu/os-win32.h is previously included (CONFIG_WIN32)

which guaranties that ... ?

 Thomas
Philippe Mathieu-Daudé Oct. 18, 2017, 12:18 p.m. UTC | #2 
On 10/18/2017 09:12 AM, Thomas Huth wrote:
> On 17.10.2017 18:44, Philippe Mathieu-Daudé wrote:
>> this file in include in "target/i386/hax-i386.h":
>>
>>     #ifdef CONFIG_WIN32
>>     #include "target/i386/hax-windows.h"
>>     #endif
>>
>> which guaranty than sysemu/os-win32.h is previously included (CONFIG_WIN32)
> 
> which guaranties that ... ?

Oh :(
Michael if you take the whole series, do you mind changing this
description or do you want me to respin it? (if there is no further
functional change asked).

Regards,

Phil.
diff mbox series

Patch

diff --git a/target/i386/hax-windows.h b/target/i386/hax-windows.h
index f7c3e99246..004f867694 100644
--- a/target/i386/hax-windows.h
+++ b/target/i386/hax-windows.h
@@ -20,7 +20,6 @@ 
 #ifndef TARGET_I386_HAX_WINDOWS_H
 #define TARGET_I386_HAX_WINDOWS_H
 
-#include <windows.h>
 #include <memory.h>
 #include <malloc.h>
 #include <winioctl.h>