From patchwork Mon Oct 2 12:40:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthoine Bourgeois X-Patchwork-Id: 820471 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FqCZvSU6"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3y5MH954Lmz9sMN for ; Mon, 2 Oct 2017 23:41:41 +1100 (AEDT) Received: from localhost ([::1]:52105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz02V-0001Me-Pn for incoming@patchwork.ozlabs.org; Mon, 02 Oct 2017 08:41:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dz01y-0001K4-Nz for qemu-devel@nongnu.org; Mon, 02 Oct 2017 08:41:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dz01t-0007jA-Oq for qemu-devel@nongnu.org; Mon, 02 Oct 2017 08:41:06 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:52841) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dz01t-0007in-Iv; Mon, 02 Oct 2017 08:41:01 -0400 Received: by mail-wm0-x242.google.com with SMTP id k4so8181377wmc.1; Mon, 02 Oct 2017 05:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=m7lUxMQowDA06v2jRVxPP5F8VipmBDG8Bgi9g2IZseE=; b=FqCZvSU69MazZEkCEihhCZtM/T/jOB7Y/upNxmo0Zf1NXzAAM/mmM/hXDDQM80L/6p e+D5mMKs8nEqjVCtxYWGr1J4eH/Ik3ccF7X3b5gbdkv6btq9u6SS9v7OvM0Th+HcDRO9 aP4teI3xiMlei2h99mFmitlAfbpcMT9sQ35FrWKC6M2cNAzLRl/PdfaMP5G3klM+Wbt/ mANys6iWB7PzucyTyp/d/ljMtIMUNhi0jXEffEYa8LY4GF1/09MQSE04GWNcwRIewWtH rODsJZkEkWxYuePRMf4QHz5RrSXKZdSRqH9tYr6Zk+L3SDYRhv1S5ziKBsiKwROfOl1z zdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m7lUxMQowDA06v2jRVxPP5F8VipmBDG8Bgi9g2IZseE=; b=pFIj4D5PZqX7XkNdu0v/NtSlqn85Xmiw/Ve86GrFbZULa6khRO0lqMFGqYdOkfi2Y2 zOnYRZ+v1tslHZ+0ZZUQYqq3lpOq84MyG0AAUZwo/LQCbG2VuAW2T/7U16g6ihrNief0 FDg2EGF2j0CleD+s3h0nDeC7LTl9O2jhO/bvc4Hqw4XLcDAsgsSEfl2fu6NX2rzhWHHi P5X5kkMcXq0LirvdfeZoYCddyhKmUJxEm0YSTWSM5jUHu9at3upuUI3u52G1k4qMK52V QaAhiK4ikB17iQ8y8/PkEBRSR0DdS78zBVfm9QF/QQ/nuC8chM83MszNAr9MC4R6ihlJ C00Q== X-Gm-Message-State: AMCzsaV0Lb9celWy9c1jdhElzEmfwm81N9tnxh9pC5/ly8iy9FfqJVZK RF7I4umQdsdqH6ejRXRDLOSorw== X-Google-Smtp-Source: AOwi7QDqSvwItfAIgNdKCow7V6XVINIwDXMgI84hpztyxwSzWzc/c+vjRZyhnDu/BZURkT1bXIzAvg== X-Received: by 10.28.68.130 with SMTP id r124mr9394451wma.96.1506948059856; Mon, 02 Oct 2017 05:40:59 -0700 (PDT) Received: from localhost.localdomain ([178.208.16.32]) by smtp.gmail.com with ESMTPSA id j73sm26719718wmf.15.2017.10.02.05.40.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Oct 2017 05:40:59 -0700 (PDT) From: Anthoine Bourgeois To: qemu-devel@nongnu.org Date: Mon, 2 Oct 2017 14:40:52 +0200 Message-Id: <20171002124052.13829-1-anthoine.bourgeois@gmail.com> X-Mailer: git-send-email 2.9.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::242 Subject: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer X-BeenThere: qemu-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Anthoine Bourgeois Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@gnu.org Sender: "Qemu-devel" From: Anthoine Bourgeois The gd_gl_area_scanout_texture must destroy framebuffer if there is no texture id instead of no framebuffer id. The effect was a black screen with "-vga virtio -display gtk,gl=on" options. The bug was introduce by a4f113fd "gtk: use framebuffer helper functions." Signed-off-by: Anthoine Bourgeois --- ui/gtk-gl-area.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 18b298f..026b7d7 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -178,8 +178,7 @@ void gd_gl_area_scanout_texture(DisplayChangeListener *dcl, gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); - if (vc->gfx.guest_fb.framebuffer == 0 || - vc->gfx.w == 0 || vc->gfx.h == 0) { + if (backing_id == 0 || vc->gfx.w == 0 || vc->gfx.h == 0) { gtk_gl_area_set_scanout_mode(vc, false); return; }