| Message ID | 20170912140149.7692-4-lvivier@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hmp: fix "dump-quest-memory" segfault | expand |
On 12.09.2017 16:01, Laurent Vivier wrote: > and add a test case of dump-guest-memory without > "[begin length]" parameters. > > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > --- > tests/test-hmp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index 729c0339f7..6b2dd5f8b8 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { > "mouse_button 0", > "device_del mouse1", > "dump-guest-memory /dev/null 0 4096", > + "dump-guest-memory /dev/null", > "gdbserver", > "host_net_add user id=net0", > "hostfwd_add tcp::43210-:43210", > @@ -159,5 +160,8 @@ int main(int argc, char **argv) > > qtest_cb_for_every_machine(add_machine_test_case); > > + /* as none machine has no memory, add a test case with memory */ > + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); > + > return g_test_run(); > } > Reviewed-by: Thomas Huth <thuth@redhat.com>
On Tue, 12 Sep 2017 16:01:49 +0200 Laurent Vivier <lvivier@redhat.com> wrote: > and add a test case of dump-guest-memory without > "[begin length]" parameters. > > Signed-off-by: Laurent Vivier <lvivier@redhat.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > --- > tests/test-hmp.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tests/test-hmp.c b/tests/test-hmp.c > index 729c0339f7..6b2dd5f8b8 100644 > --- a/tests/test-hmp.c > +++ b/tests/test-hmp.c > @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { > "mouse_button 0", > "device_del mouse1", > "dump-guest-memory /dev/null 0 4096", > + "dump-guest-memory /dev/null", > "gdbserver", > "host_net_add user id=net0", > "hostfwd_add tcp::43210-:43210", > @@ -159,5 +160,8 @@ int main(int argc, char **argv) > > qtest_cb_for_every_machine(add_machine_test_case); > > + /* as none machine has no memory, add a test case with memory */ s/no memory/no memory by default/ ? > + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); > + > return g_test_run(); > } Regardless, Reviewed-by: Cornelia Huck <cohuck@redhat.com>
diff --git a/tests/test-hmp.c b/tests/test-hmp.c index 729c0339f7..6b2dd5f8b8 100644 --- a/tests/test-hmp.c +++ b/tests/test-hmp.c @@ -35,6 +35,7 @@ static const char *hmp_cmds[] = { "mouse_button 0", "device_del mouse1", "dump-guest-memory /dev/null 0 4096", + "dump-guest-memory /dev/null", "gdbserver", "host_net_add user id=net0", "hostfwd_add tcp::43210-:43210", @@ -159,5 +160,8 @@ int main(int argc, char **argv) qtest_cb_for_every_machine(add_machine_test_case); + /* as none machine has no memory, add a test case with memory */ + qtest_add_data_func("hmp/none+2MB", g_strdup("none -m 2"), test_machine); + return g_test_run(); }