| Message ID | 20170907081158.4063-3-famz@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | docker: Update ubuntu and test-full for more coverage | expand |
On 09/07/2017 03:11 AM, Fam Zheng wrote: > Also avoid "set -e". > > Signed-off-by: Fam Zheng <famz@redhat.com> > --- > tests/docker/test-full | 80 ++++++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 75 insertions(+), 5 deletions(-) > > diff --git a/tests/docker/test-full b/tests/docker/test-full > index 05f0d491d1..bd095ad91b 100755 > --- a/tests/docker/test-full > +++ b/tests/docker/test-full > @@ -1,8 +1,8 @@ > -#!/bin/bash -e > +#!/bin/bash When you drop 'set -e'... > # > -# Compile all the targets. > +# Compile all the targets with as many features enabled as possible > # > -# Copyright (c) 2016 Red Hat Inc. > +# Copyright 2016, 2017 Red Hat Inc. > # > # Authors: > # Fam Zheng <famz@redhat.com> > @@ -15,5 +15,75 @@ > > cd "$BUILD_DIR" ...then you should explicitly check for failure after commands where you really do not want to continue execution if they failed. I'd write this: cd "$BUILD_DIR" || exit 1 or else use && to chain it to... > > -build_qemu > -make check $MAKEFLAGS > +build_qemu \ > + --enable-attr \ > + --enable-xfsctl \ > +&& make check $MAKEFLAGS the rest of your chain.
On Thu, 09/07 08:37, Eric Blake wrote: > On 09/07/2017 03:11 AM, Fam Zheng wrote: > > Also avoid "set -e". > > > > Signed-off-by: Fam Zheng <famz@redhat.com> > > --- > > tests/docker/test-full | 80 ++++++++++++++++++++++++++++++++++++++++++++++---- > > 1 file changed, 75 insertions(+), 5 deletions(-) > > > > diff --git a/tests/docker/test-full b/tests/docker/test-full > > index 05f0d491d1..bd095ad91b 100755 > > --- a/tests/docker/test-full > > +++ b/tests/docker/test-full > > @@ -1,8 +1,8 @@ > > -#!/bin/bash -e > > +#!/bin/bash > > When you drop 'set -e'... > > > # > > -# Compile all the targets. > > +# Compile all the targets with as many features enabled as possible > > # > > -# Copyright (c) 2016 Red Hat Inc. > > +# Copyright 2016, 2017 Red Hat Inc. > > # > > # Authors: > > # Fam Zheng <famz@redhat.com> > > @@ -15,5 +15,75 @@ > > > > cd "$BUILD_DIR" > > ...then you should explicitly check for failure after commands where you > really do not want to continue execution if they failed. I'd write this: We can probably tolerate the failure of cd, but it might be better if we are strict on that. Will update. Fam
diff --git a/tests/docker/test-full b/tests/docker/test-full index 05f0d491d1..bd095ad91b 100755 --- a/tests/docker/test-full +++ b/tests/docker/test-full @@ -1,8 +1,8 @@ -#!/bin/bash -e +#!/bin/bash # -# Compile all the targets. +# Compile all the targets with as many features enabled as possible # -# Copyright (c) 2016 Red Hat Inc. +# Copyright 2016, 2017 Red Hat Inc. # # Authors: # Fam Zheng <famz@redhat.com> @@ -15,5 +15,75 @@ cd "$BUILD_DIR" -build_qemu -make check $MAKEFLAGS +build_qemu \ + --enable-attr \ + --enable-bluez \ + --enable-brlapi \ + --enable-bsd-user \ + --enable-bzip2 \ + --enable-cap-ng \ + --enable-coroutine-pool \ + --enable-crypto-afalg \ + --enable-curl \ + --enable-curses \ + --enable-debug \ + --enable-debug-info \ + --enable-debug-tcg \ + --enable-docs \ + --enable-fdt \ + --enable-gcrypt \ + --enable-glusterfs \ + --enable-gnutls \ + --enable-gprof \ + --enable-gtk \ + --enable-guest-agent \ + --enable-jemalloc \ + --enable-kvm \ + --enable-libiscsi \ + --enable-libnfs \ + --enable-libssh2 \ + --enable-libusb \ + --enable-linux-aio \ + --enable-linux-user \ + --enable-live-block-migration \ + --enable-lzo \ + --enable-modules \ + --enable-numa \ + --enable-opengl \ + --enable-pie \ + --enable-profiler \ + --enable-qom-cast-debug \ + --enable-rbd \ + --enable-rdma \ + --enable-replication \ + --enable-sdl \ + --enable-seccomp \ + --enable-smartcard \ + --enable-snappy \ + --enable-spice \ + --enable-stack-protector \ + --enable-system \ + --enable-tcg \ + --enable-tcg-interpreter \ + --enable-tools \ + --enable-tpm \ + --enable-trace-backend=ftrace \ + --enable-usb-redir \ + --enable-user \ + --enable-vde \ + --enable-vhost-net \ + --enable-vhost-scsi \ + --enable-vhost-user \ + --enable-vhost-vsock \ + --enable-virtfs \ + --enable-vnc \ + --enable-vnc-jpeg \ + --enable-vnc-png \ + --enable-vnc-sasl \ + --enable-vte \ + --enable-werror \ + --enable-xen \ + --enable-xen-pci-passthrough \ + --enable-xen-pv-domain-build \ + --enable-xfsctl \ +&& make check $MAKEFLAGS
Also avoid "set -e". Signed-off-by: Fam Zheng <famz@redhat.com> --- tests/docker/test-full | 80 ++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 75 insertions(+), 5 deletions(-)