diff mbox series

[v6,01/12] gitignore: Ignore vm test images

Message ID 20170905021201.25684-2-famz@redhat.com
State New
Headers show
Series tests: Add VM based build tests (for non-x86_64 and/or non-Linux) | expand

Commit Message

Fam Zheng Sept. 5, 2017, 2:11 a.m. UTC 
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 .gitignore       | 1 +
 tests/.gitignore | 1 +
 2 files changed, 2 insertions(+)

Comments

Alex Bennée Sept. 8, 2017, 2:12 p.m. UTC | #1 
Fam Zheng <famz@redhat.com> writes:

> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  .gitignore       | 1 +
>  tests/.gitignore | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index cf65316863..40acfcb9e2 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -52,6 +52,7 @@
>  /vscclient
>  /vhost-user-scsi
>  /fsdev/virtfs-proxy-helper
> +*.tmp

I'm not sure we should be dumping anything in the rootdir, .gitignored
or not.

>  *.[1-9]
>  *.a
>  *.aux
> diff --git a/tests/.gitignore b/tests/.gitignore
> index fed0189a5a..cf6d99c91e 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -95,3 +95,4 @@ test-filter-mirror
>  test-filter-redirector
>  *-test
>  qapi-schema/*.test.*
> +vm/*.img


--
Alex Bennée
Fam Zheng Sept. 8, 2017, 11:12 p.m. UTC | #2 
On Fri, 09/08 15:12, Alex Bennée wrote:
> 
> Fam Zheng <famz@redhat.com> writes:
> 
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  .gitignore       | 1 +
> >  tests/.gitignore | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index cf65316863..40acfcb9e2 100644
> > --- a/.gitignore
> > +++ b/.gitignore
> > @@ -52,6 +52,7 @@
> >  /vscclient
> >  /vhost-user-scsi
> >  /fsdev/virtfs-proxy-helper
> > +*.tmp
> 
> I'm not sure we should be dumping anything in the rootdir, .gitignored
> or not.

It used to be /tests/vm/*.tmp but Philippe asked for a generic rule in previous
reviewing. I think it makes sense, we can also unify the docker-src.* pattern by
making the directory names to have a .tmp suffix later.

Fam
diff mbox series

Patch

diff --git a/.gitignore b/.gitignore
index cf65316863..40acfcb9e2 100644
--- a/.gitignore
+++ b/.gitignore
@@ -52,6 +52,7 @@ 
 /vscclient
 /vhost-user-scsi
 /fsdev/virtfs-proxy-helper
+*.tmp
 *.[1-9]
 *.a
 *.aux
diff --git a/tests/.gitignore b/tests/.gitignore
index fed0189a5a..cf6d99c91e 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -95,3 +95,4 @@  test-filter-mirror
 test-filter-redirector
 *-test
 qapi-schema/*.test.*
+vm/*.img