diff mbox

bios-tables-test: use strlen instead of sizeof

Message ID 20170815050414.29222-1-wei.yang@ucloud.cn
State New
Headers show

Commit Message

wei.yang@ucloud.cn Aug. 15, 2017, 5:04 a.m. UTC 
From: Wei Yang <wei.yang@ucloud.cn>

sizeof(BLOCK_NAME_END) is actually 2.  it can work
because there's a space after ,. but It is better to
replace it with strlen so it will work without a space too.

Signed-off-by: Wei Yang <wei.yang@ucloud.cn>
CC: Michael S. Tsirkin <mst@redhat.com>
CC: qemu-devel@nongnu.org
---
 tests/bios-tables-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox

Patch

diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
index 88dbf97853..d1f31b19d3 100644
--- a/tests/bios-tables-test.c
+++ b/tests/bios-tables-test.c
@@ -352,7 +352,7 @@  static GString *normalize_asl(gchar *asl_code)
         block_name = g_strstr_len(asl->str, asl->len, BLOCK_NAME_END);
         g_assert(block_name);
         asl = g_string_erase(asl, 0,
-                             block_name + sizeof(BLOCK_NAME_END) - asl->str);
+                             block_name + strlen(BLOCK_NAME_END) - asl->str);
     }
 
     return asl;