| Message ID | 20170807203007.19033-4-eblake@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 08/07/2017 05:30 PM, Eric Blake wrote: > It's been #if 0'd since its introduction in 2006, commit 585f8587. > We can revive dead code if we need it, but in the meantime, it has > bit-rotted (for example, not checking for failure in bdrv_getlength()). > > Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > block/qcow2.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index d7c600b5a2..99407403ea 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3798,27 +3798,6 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs) > return spec_info; > } > > -#if 0 > -static void dump_refcounts(BlockDriverState *bs) > -{ > - BDRVQcow2State *s = bs->opaque; > - int64_t nb_clusters, k, k1, size; > - int refcount; > - > - size = bdrv_getlength(bs->file->bs); > - nb_clusters = size_to_clusters(s, size); > - for(k = 0; k < nb_clusters;) { > - k1 = k; > - refcount = get_refcount(bs, k); > - k++; > - while (k < nb_clusters && get_refcount(bs, k) == refcount) > - k++; > - printf("%" PRId64 ": refcount=%d nb=%" PRId64 "\n", k, refcount, > - k - k1); > - } > -} > -#endif > - > static int qcow2_save_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, > int64_t pos) > { >
On Mon, Aug 07, 2017 at 03:30:06PM -0500, Eric Blake wrote: > It's been #if 0'd since its introduction in 2006, commit 585f8587. > We can revive dead code if we need it, but in the meantime, it has > bit-rotted (for example, not checking for failure in bdrv_getlength()). > > Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Jeff Cody <jcody@redhat.com> > --- > block/qcow2.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/block/qcow2.c b/block/qcow2.c > index d7c600b5a2..99407403ea 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -3798,27 +3798,6 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs) > return spec_info; > } > > -#if 0 > -static void dump_refcounts(BlockDriverState *bs) > -{ > - BDRVQcow2State *s = bs->opaque; > - int64_t nb_clusters, k, k1, size; > - int refcount; > - > - size = bdrv_getlength(bs->file->bs); > - nb_clusters = size_to_clusters(s, size); > - for(k = 0; k < nb_clusters;) { > - k1 = k; > - refcount = get_refcount(bs, k); > - k++; > - while (k < nb_clusters && get_refcount(bs, k) == refcount) > - k++; > - printf("%" PRId64 ": refcount=%d nb=%" PRId64 "\n", k, refcount, > - k - k1); > - } > -} > -#endif > - > static int qcow2_save_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, > int64_t pos) > { > -- > 2.13.4 > >
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben: > It's been #if 0'd since its introduction in 2006, commit 585f8587. > We can revive dead code if we need it, but in the meantime, it has > bit-rotted (for example, not checking for failure in bdrv_getlength()). > > Signed-off-by: Eric Blake <eblake@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com>
diff --git a/block/qcow2.c b/block/qcow2.c index d7c600b5a2..99407403ea 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -3798,27 +3798,6 @@ static ImageInfoSpecific *qcow2_get_specific_info(BlockDriverState *bs) return spec_info; } -#if 0 -static void dump_refcounts(BlockDriverState *bs) -{ - BDRVQcow2State *s = bs->opaque; - int64_t nb_clusters, k, k1, size; - int refcount; - - size = bdrv_getlength(bs->file->bs); - nb_clusters = size_to_clusters(s, size); - for(k = 0; k < nb_clusters;) { - k1 = k; - refcount = get_refcount(bs, k); - k++; - while (k < nb_clusters && get_refcount(bs, k) == refcount) - k++; - printf("%" PRId64 ": refcount=%d nb=%" PRId64 "\n", k, refcount, - k - k1); - } -} -#endif - static int qcow2_save_vmstate(BlockDriverState *bs, QEMUIOVector *qiov, int64_t pos) {
It's been #if 0'd since its introduction in 2006, commit 585f8587. We can revive dead code if we need it, but in the meantime, it has bit-rotted (for example, not checking for failure in bdrv_getlength()). Signed-off-by: Eric Blake <eblake@redhat.com> --- block/qcow2.c | 21 --------------------- 1 file changed, 21 deletions(-)