Message ID | 20170721054210.GA16334@flamenco |
---|---|
State | New |
Headers | show |
On 21 July 2017 at 06:42, Emilio G. Cota <cota@braap.org> wrote: > const leak! patch below -- cut with `git am --scissors'. > > Emilio > > ---8<--- > > Signed-off-by: Emilio G. Cota <cota@braap.org> > --- Applied to target-arm.next, thanks -- but in future could you send patches as proper patch emails, please (output of git format-patch, sent as its own top level email, not a reply to an existing thread) ? Otherwise the automated tools don't recognise them as patches and it requires some tedious manual application at this end. thanks -- PMM
On Fri, Jul 21, 2017 at 14:16:46 +0100, Peter Maydell wrote: > On 21 July 2017 at 06:42, Emilio G. Cota <cota@braap.org> wrote: > > const leak! patch below -- cut with `git am --scissors'. > > > > Emilio > > > > ---8<--- > > > > Signed-off-by: Emilio G. Cota <cota@braap.org> > > --- > > Applied to target-arm.next, thanks -- but in future could you > send patches as proper patch emails, please (output of > git format-patch, sent as its own top level email, not a > reply to an existing thread) ? Otherwise the automated tools > don't recognise them as patches and it requires some tedious > manual application at this end. Will do, sorry about that. E.
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 883e9df..58ed4c6 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -4044,20 +4044,21 @@ static void handle_rev16(DisasContext *s, unsigned int sf, TCGv_i64 tcg_tmp = tcg_temp_new_i64(); TCGv_i64 tcg_rn = read_cpu_reg(s, rn, sf); TCGv_i64 mask = tcg_const_i64(sf ? 0x00ff00ff00ff00ffull : 0x00ff00ff); tcg_gen_shri_i64(tcg_tmp, tcg_rn, 8); tcg_gen_and_i64(tcg_rd, tcg_rn, mask); tcg_gen_and_i64(tcg_tmp, tcg_tmp, mask); tcg_gen_shli_i64(tcg_rd, tcg_rd, 8); tcg_gen_or_i64(tcg_rd, tcg_rd, tcg_tmp); + tcg_temp_free_i64(mask); tcg_temp_free_i64(tcg_tmp); } /* C3.5.7 Data-processing (1 source) * 31 30 29 28 21 20 16 15 10 9 5 4 0 * +----+---+---+-----------------+---------+--------+------+------+ * | sf | 1 | S | 1 1 0 1 0 1 1 0 | opcode2 | opcode | Rn | Rd | * +----+---+---+-----------------+---------+--------+------+------+ */ static void disas_data_proc_1src(DisasContext *s, uint32_t insn)