| Message ID | 20170720162815.19802-5-ldoktor@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Thu, Jul 20, 2017 at 06:28:08PM +0200, Lukáš Doktor wrote: > The QMP key conversion consist of '_'s to be replaced with '-'s, which > can easily be done by a single `str.replace` method which is faster and > does not require `string` module import. > > Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
diff --git a/scripts/qemu.py b/scripts/qemu.py index 7e95c25..5948e19 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -13,7 +13,6 @@ # import errno -import string import os import sys import subprocess @@ -180,14 +179,12 @@ class QEMUMachine(object): self._load_io_log() self._post_shutdown() - underscore_to_dash = string.maketrans('_', '-') - def qmp(self, cmd, conv_keys=True, **args): '''Invoke a QMP command and return the result dict''' qmp_args = dict() for key, value in args.iteritems(): if conv_keys: - qmp_args[key.translate(self.underscore_to_dash)] = value + qmp_args[key.replace('_', '-')] = value else: qmp_args[key] = value
The QMP key conversion consist of '_'s to be replaced with '-'s, which can easily be done by a single `str.replace` method which is faster and does not require `string` module import. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> --- scripts/qemu.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)