From patchwork Thu Jul 20 15:04:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 791651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="TaPEhtu3"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xCyJv04j9z9s4q for ; Fri, 21 Jul 2017 01:20:47 +1000 (AEST) Received: from localhost ([::1]:38573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYDFs-0002nS-Id for incoming@patchwork.ozlabs.org; Thu, 20 Jul 2017 11:20:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYD81-00036p-KV for qemu-devel@nongnu.org; Thu, 20 Jul 2017 11:12:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYD80-0004J4-QW for qemu-devel@nongnu.org; Thu, 20 Jul 2017 11:12:37 -0400 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:36680) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYD80-0004H7-LA for qemu-devel@nongnu.org; Thu, 20 Jul 2017 11:12:36 -0400 Received: by mail-wm0-x22c.google.com with SMTP id k69so27176765wmc.1 for ; Thu, 20 Jul 2017 08:12:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+T9h9ZaO+gsZ2+2zBxKOd6pKrG7Qn1jmeQZqqoNyBgA=; b=TaPEhtu3vg9H0D5Teaw71R8uLhr0v0vkEFQET7YjGw+08tJsFiiGW9H8xeQPSBecy6 zH8vs2RrNUEded2S5asROylWTrjKgR9WlZHfx9bhJjGzPRjqKJpBid9DEUxXimwHIQNv 8N6YhfDTiNDSuL9TraNT8J6Ux7YZOqnpDIa1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+T9h9ZaO+gsZ2+2zBxKOd6pKrG7Qn1jmeQZqqoNyBgA=; b=mzN0VFo3KITpvxXjyGD0WvQOJ+91wlJ4IB9rqQWualyqiqhe2+8G6GLjjyToxWPMaW KAYCqw5z8lTb9URJa1NLvnxe4V3d1BSWO6XL+WgOVzyl+JuRVBEerDl6S4Md2/p4soa9 WWHn+wghFZOpFe2biN2113dc0yGh+os/cF0ES81oEc08bpa/1vZX7QH707b0+hkQ+5Ol SQ7s59aA8uUHC2vzE/kpkipV+UGscAF5aTa8NdCFKAQfENXhTYfM/k+03156ErlNBKrN RPKKs9HxnM4SlQzPZqoaCFz68bXr75BFWFlVG76jrj95MHvarZ1b6O0kk+2U3fr7uVJ2 NioA== X-Gm-Message-State: AIVw112DEy6s7bLP3/dQk1AGqXCN/TiNYjqUZwDhYApDjLNlpbHu2Vaw 1uwudCzfIPjGEj4BShtmWA== X-Received: by 10.28.28.6 with SMTP id c6mr1576149wmc.21.1500563555740; Thu, 20 Jul 2017 08:12:35 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id d20sm3795035wrc.96.2017.07.20.08.12.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jul 2017 08:12:32 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 0AEC53E0BC6; Thu, 20 Jul 2017 16:04:34 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: peter.maydell@linaro.org Date: Thu, 20 Jul 2017 16:04:25 +0100 Message-Id: <20170720150426.12393-23-alex.bennee@linaro.org> X-Mailer: git-send-email 2.13.0 In-Reply-To: <20170720150426.12393-1-alex.bennee@linaro.org> References: <20170720150426.12393-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [RFC PATCH for 2.11 22/23] fpu/softfloat2a: improve comments on ARM NaN propagation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-devel@nongnu.org, Aurelien Jarno , rth@twiddle.net Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée --- fpu/softfloat2a/softfloat-specialize.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fpu/softfloat2a/softfloat-specialize.h b/fpu/softfloat2a/softfloat-specialize.h index c8282b8bf7..2ccd4abe11 100644 --- a/fpu/softfloat2a/softfloat-specialize.h +++ b/fpu/softfloat2a/softfloat-specialize.h @@ -445,14 +445,14 @@ static float32 commonNaNToFloat32(commonNaNT a, float_status *status) #if defined(TARGET_ARM) static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN, - flag aIsLargerSignificand) + flag aIsLargerSignificand) { - /* ARM mandated NaN propagation rules: take the first of: - * 1. A if it is signaling - * 2. B if it is signaling + /* ARM mandated NaN propagation rules (see FPProcessNaNs()), take the first of: + * 1. A if it is signalling + * 2. B if it is signalling * 3. A (quiet) * 4. B (quiet) - * A signaling NaN is always quietened before returning it. + * A signalling NaN is always quietened before returning it. */ if (aIsSNaN) { return 0;