From patchwork Wed Jul 19 23:34:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 791293 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="A91UhHgJ"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xCYTm6kC8z9t2x for ; Thu, 20 Jul 2017 09:42:04 +1000 (AEST) Received: from localhost ([::1]:35412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXybS-0004i7-Em for incoming@patchwork.ozlabs.org; Wed, 19 Jul 2017 19:42:02 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXyVl-0008KI-3Z for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXyVk-0006rA-0l for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:09 -0400 Received: from mail-qk0-x244.google.com ([2607:f8b0:400d:c09::244]:38200) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXyVj-0006qu-Sy for qemu-devel@nongnu.org; Wed, 19 Jul 2017 19:36:07 -0400 Received: by mail-qk0-x244.google.com with SMTP id t2so1003893qkc.5 for ; Wed, 19 Jul 2017 16:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3EsWG4fo+Rdv5s67aI3AP/nroTyABuVAxdOadFLvU+Q=; b=A91UhHgJByQsF23bDFxue1JDi61VVQU6MlDHHEVNsu139W/UbeGliO4aqQFCqw70nE nmGDh4cakluSR4mtu8QZSCzXsaySXDKyE5vxLOuFbMlhDcKvNUmZafqzh58/0pzut1NT xeIqcHqxtfBzgnsOIRwquxiy9My5feXGO0uOCD4onrxi0Z3pqVx/41DpiMJW9OsgFh93 qQ+gXEcfZFcp62KD4V4Tf66VaRunamKGQ+TgoGLrZ9/YvXnByDJc1pQybJNEUUZslNmS 12pgvotoQ6IC7qf5y6vubXU2CQ70p8RI9II9zZ6H7XoomRYmIXPAL6y6LyummmLWX34X 8dCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=3EsWG4fo+Rdv5s67aI3AP/nroTyABuVAxdOadFLvU+Q=; b=cKIy6OVZm4VVHYpzm6fW0uuZRy2EAfA+WDfIiWjUiDKzoi+PO0uzvqyQg+NmRjONbp hHpWtLd0cdbSgiucvnTTBDP8XMWXIUYYP36Np3hJ1BXCWWPqCZTyzIVOy9sGYbEjtQRG lwnrUX+DKyuMOUoi+s7UZORIjpJ6yYOGUn9xk8z6lugRDNxF/Ks9+qs3XJJ6eiysl/Xq oPqodds+6I5LHM4cDlw8NG8ncbDMYzEmIpzmYlBQ9Or5XiSVoTghZG6LBnZIl59mCo6b +ZinaOHgI/iqAj/M23UB+JpI7JfbFZ6UdvSZYPs+xHo5cVnvgvT0/zXSgy6526jVGWwH q+SA== X-Gm-Message-State: AIVw1126V88tmvk2nvks6UcFkaqAO6WacDxSU+COBaBlCXZuniR8GEOZ WuQFokRc2LivaA5K8xQ= X-Received: by 10.55.152.194 with SMTP id a185mr2620297qke.26.1500507367195; Wed, 19 Jul 2017 16:36:07 -0700 (PDT) Received: from bigtime.com ([203.221.203.174]) by smtp.gmail.com with ESMTPSA id w33sm857130qth.96.2017.07.19.16.36.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Jul 2017 16:36:06 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Wed, 19 Jul 2017 13:34:51 -1000 Message-Id: <20170719233455.8740-11-rth@twiddle.net> X-Mailer: git-send-email 2.13.3 In-Reply-To: <20170719233455.8740-1-rth@twiddle.net> References: <20170719233455.8740-1-rth@twiddle.net> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::244 Subject: [Qemu-devel] [PULL v2 10/14] target/sparc: optimize various functions using extract op X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Done with the Coccinelle semantic patch scripts/coccinelle/tcg_gen_extract.cocci. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/sparc/translate.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index aa6734d54e..67a83b77cc 100644 --- a/target/sparc/translate.c +++ b/target/sparc/translate.c @@ -380,29 +380,25 @@ static inline void gen_goto_tb(DisasContext *s, int tb_num, static inline void gen_mov_reg_N(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_NEG_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_NEG_SHIFT, 1); } static inline void gen_mov_reg_Z(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_ZERO_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_ZERO_SHIFT, 1); } static inline void gen_mov_reg_V(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_OVF_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_OVF_SHIFT, 1); } static inline void gen_mov_reg_C(TCGv reg, TCGv_i32 src) { tcg_gen_extu_i32_tl(reg, src); - tcg_gen_shri_tl(reg, reg, PSR_CARRY_SHIFT); - tcg_gen_andi_tl(reg, reg, 0x1); + tcg_gen_extract_tl(reg, reg, PSR_CARRY_SHIFT, 1); } static inline void gen_op_add_cc(TCGv dst, TCGv src1, TCGv src2) @@ -638,8 +634,7 @@ static inline void gen_op_mulscc(TCGv dst, TCGv src1, TCGv src2) // env->y = (b2 << 31) | (env->y >> 1); tcg_gen_andi_tl(r_temp, cpu_cc_src, 0x1); tcg_gen_shli_tl(r_temp, r_temp, 31); - tcg_gen_shri_tl(t0, cpu_y, 1); - tcg_gen_andi_tl(t0, t0, 0x7fffffff); + tcg_gen_extract_tl(t0, cpu_y, 1, 31); tcg_gen_or_tl(t0, t0, r_temp); tcg_gen_andi_tl(cpu_y, t0, 0xffffffff);