diff mbox

[RESEND,5/8] tcg/tci: enable bswap16_i64

Message ID 20170629010300.2848-6-f4bug@amsat.org
State New
Headers show

Commit Message

Philippe Mathieu-Daudé June 29, 2017, 1:02 a.m. UTC 
remove some copy/paste leftover, code seems sane.

while running Alex Bennée's image aarch64-linux-3.15rc2-buildroot.img:

Trace 0x7fa1904b0890 [0: ffffffc00036cd04]
----------------
IN:
0xffffffc00036cd24:  5ac00694      rev16 w20, w20

OP:
 ---- ffffffc00036cd24 0000000000000000 0000000000000000
 ext32u_i64 tmp3,x20
 ext16u_i64 tmp2,tmp3
 bswap16_i64 x20,tmp2
 movi_i64 tmp4,$0x10
 shr_i64 tmp2,tmp3,tmp4
 ext16u_i64 tmp2,tmp2
 bswap16_i64 tmp2,tmp2
 deposit_i64 x20,x20,tmp2,$0x10,$0x10

Linking TBs 0x7fa1904b0890 [ffffffc00036cd04] index 0 -> 0x7fa1904b0aa0 [ffffffc00036cd24]
Trace 0x7fa1904b0aa0 [0: ffffffc00036cd24]
TODO qemu/tci.c:1049: tcg_qemu_tb_exec()
qemu/tci.c:1049: tcg fatal error
Aborted

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
 tcg/tci.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Eric Blake June 29, 2017, 4:29 p.m. UTC | #1 
On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
> remove some copy/paste leftover, code seems sane.
> 

> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Double-sob seems odd.

> ---
>  tcg/tci.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Otherwise,
Reviewed-by: Eric Blake <eblake@redhat.com>
Philippe Mathieu-Daudé June 29, 2017, 4:41 p.m. UTC | #2 
On 06/29/2017 01:29 PM, Eric Blake wrote:
> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> Double-sob seems odd.
> 

eh you never know... I need to improve my mailing skills :|

>> ---
>>   tcg/tci.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
> 
> Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>

Thanks.
Stefan Weil June 29, 2017, 4:52 p.m. UTC | #3 
Am 29.06.2017 um 18:29 schrieb Eric Blake:
> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>> remove some copy/paste leftover, code seems sane.
>>
> 
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> Double-sob seems odd.

Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).

> 
>> ---
>>  tcg/tci.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
> 
> Otherwise,
> Reviewed-by: Eric Blake <eblake@redhat.com>
> 

Note from the author: it's not a copy/paste leftover, but was
there on purpose: that code part was simply never executed
before, and I only removed the TODO() statements from tested
code.

So you are the first one who found a test case. Congratulations.

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Philippe Mathieu-Daudé June 29, 2017, 5:02 p.m. UTC | #4 
On 06/29/2017 01:52 PM, Stefan Weil wrote:
> Am 29.06.2017 um 18:29 schrieb Eric Blake:
>> On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote:
>>> remove some copy/paste leftover, code seems sane.
>>>
>>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Double-sob seems odd.
> 
> Maybe that double SOB can be cleaned by qemu-trivial (cc'ed).
> 
>>
>>> ---
>>>   tcg/tci.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>
>> Otherwise,
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>
> 
> Note from the author: it's not a copy/paste leftover, but was
> there on purpose: that code part was simply never executed
> before, and I only removed the TODO() statements from tested
> code.

I'll reword the commit message in my tci-fixes-for-2.10-v2 series.

> So you are the first one who found a test case. Congratulations.

Oh nice :)

> Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thank.
diff mbox

Patch

diff --git a/tcg/tci.c b/tcg/tci.c
index 4bdc645f2a..f39bfb95c0 100644
--- a/tcg/tci.c
+++ b/tcg/tci.c
@@ -1046,7 +1046,6 @@  uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr)
             break;
 #if TCG_TARGET_HAS_bswap16_i64
         case INDEX_op_bswap16_i64:
-            TODO();
             t0 = *tb_ptr++;
             t1 = tci_read_r16(&tb_ptr);
             tci_write_reg64(t0, bswap16(t1));