| Message ID | 20170622033231.19344-2-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > This allow a one liner from fresh repository clone, i.e.: > > ./configure && make -j check-qtest-aarch64 TIL -j doesn't need a number and GNU Make has a -l option ;-) Reviewed-by: Alex Bennée <alex.bennee@linaro.org> > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 77da9b7f4b..f7c8f3eddb 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -823,7 +823,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,) > # gtester tests, possibly with verbose output > > .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) > -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) > +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ > QTEST_QEMU_IMG=qemu-img$(EXESUF) \ -- Alex Bennée
On Thu, Jun 22, 2017 at 12:32:11AM -0300, Philippe Mathieu-Daudé wrote: > This allow a one liner from fresh repository clone, i.e.: > > ./configure && make -j check-qtest-aarch64 > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
On 06/22/2017 06:55 AM, Alex Bennée wrote: > > Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > >> This allow a one liner from fresh repository clone, i.e.: >> >> ./configure && make -j check-qtest-aarch64 > > TIL -j doesn't need a number and GNU Make has a -l option ;-) Also since 2.8 (2016) git fetch has -j option, but Travis is using a release version 1.8 (from the git-core PPA) on my debian/unstable git version 2.13.1 I can do: $ git submodule update --init --recursive --depth 1 -j ${PARALLEL_JOBS}
On 06/21/2017 11:32 PM, Philippe Mathieu-Daudé wrote: > This allow a one liner from fresh repository clone, i.e.: > > ./configure && make -j check-qtest-aarch64 > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > tests/Makefile.include | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/Makefile.include b/tests/Makefile.include > index 77da9b7f4b..f7c8f3eddb 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -823,7 +823,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,) > # gtester tests, possibly with verbose output > > .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) > -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) > +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) > $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) > $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ > QTEST_QEMU_IMG=qemu-img$(EXESUF) \ > I'm on board, it's nice to have proper dependencies. Reviewed-by: John Snow <jsnow@redhat.com>
diff --git a/tests/Makefile.include b/tests/Makefile.include index 77da9b7f4b..f7c8f3eddb 100644 --- a/tests/Makefile.include +++ b/tests/Makefile.include @@ -823,7 +823,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,) # gtester tests, possibly with verbose output .PHONY: $(patsubst %, check-qtest-%, $(QTEST_TARGETS)) -$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) +$(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: subdir-%-softmmu $(check-qtest-y) $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ QTEST_QEMU_IMG=qemu-img$(EXESUF) \
This allow a one liner from fresh repository clone, i.e.: ./configure && make -j check-qtest-aarch64 Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- tests/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)